aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMaciej Sosnowski2012-05-23 10:27:07 -0500
committerGreg Kroah-Hartman2013-02-28 08:32:27 -0600
commit7a9a20ea77e7508c795dead9ab2f6c98a617762d (patch)
tree80c42e50d234f3041fa4a8ed38e1f7c198ef18c7
parentae593067dbed83010fee8ad59bab7948f3d3601f (diff)
downloadkernel-common-7a9a20ea77e7508c795dead9ab2f6c98a617762d.tar.gz
kernel-common-7a9a20ea77e7508c795dead9ab2f6c98a617762d.tar.xz
kernel-common-7a9a20ea77e7508c795dead9ab2f6c98a617762d.zip
dca: check against empty dca_domains list before unregister provider
commit c419fcfd071cf34ba00f9f65282583772d2655e7 upstream. When providers get blocked unregister_dca_providers() is called ending up with dca_providers and dca_domain lists emptied. Dca should be prevented from trying to unregister any provider if dca_domain list is found empty. Reported-by: Jiang Liu <jiang.liu@huawei.com> Tested-by: Gaohuai Han <hangaohuai@huawei.com> Signed-off-by: Maciej Sosnowski <maciej.sosnowski@intel.com> Signed-off-by: Dan Williams <djbw@fb.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/dca/dca-core.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/dca/dca-core.c b/drivers/dca/dca-core.c
index 4abd089a094..7065851d0b7 100644
--- a/drivers/dca/dca-core.c
+++ b/drivers/dca/dca-core.c
@@ -409,6 +409,11 @@ void unregister_dca_provider(struct dca_provider *dca, struct device *dev)
409 409
410 spin_lock_irqsave(&dca_lock, flags); 410 spin_lock_irqsave(&dca_lock, flags);
411 411
412 if (list_empty(&dca_domains)) {
413 raw_spin_unlock_irqrestore(&dca_lock, flags);
414 return;
415 }
416
412 list_del(&dca->node); 417 list_del(&dca->node);
413 418
414 pci_rc = dca_pci_rc_from_dev(dev); 419 pci_rc = dca_pci_rc_from_dev(dev);