aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike Snitzer2012-08-01 03:44:28 -0500
committerJens Axboe2012-08-01 03:44:28 -0500
commitfe86cdcef73ba19a2246a124f0ddbd19b14fb549 (patch)
tree3e947ceddc7ffb9073c2b7c3797cdf0d2e1c833a /block/blk-settings.c
parenta051661ca6d134c18599498b185b667859d4339b (diff)
downloadkernel-common-fe86cdcef73ba19a2246a124f0ddbd19b14fb549.tar.gz
kernel-common-fe86cdcef73ba19a2246a124f0ddbd19b14fb549.tar.xz
kernel-common-fe86cdcef73ba19a2246a124f0ddbd19b14fb549.zip
block: do not artificially constrain max_sectors for stacking drivers
blk_set_stacking_limits is intended to allow stacking drivers to build up the limits of the stacked device based on the underlying devices' limits. But defaulting 'max_sectors' to BLK_DEF_MAX_SECTORS (1024) doesn't allow the stacking driver to inherit a max_sectors larger than 1024 -- due to blk_stack_limits' use of min_not_zero. It is now clear that this artificial limit is getting in the way so change blk_set_stacking_limits's max_sectors to UINT_MAX (which allows stacking drivers like dm-multipath to inherit 'max_sectors' from the underlying paths). Reported-by: Vijay Chauhan <vijay.chauhan@netapp.com> Tested-by: Vijay Chauhan <vijay.chauhan@netapp.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-settings.c')
-rw-r--r--block/blk-settings.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/block/blk-settings.c b/block/blk-settings.c
index d3234fc494a..565a6786032 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -143,8 +143,7 @@ void blk_set_stacking_limits(struct queue_limits *lim)
143 lim->discard_zeroes_data = 1; 143 lim->discard_zeroes_data = 1;
144 lim->max_segments = USHRT_MAX; 144 lim->max_segments = USHRT_MAX;
145 lim->max_hw_sectors = UINT_MAX; 145 lim->max_hw_sectors = UINT_MAX;
146 146 lim->max_sectors = UINT_MAX;
147 lim->max_sectors = BLK_DEF_MAX_SECTORS;
148} 147}
149EXPORT_SYMBOL(blk_set_stacking_limits); 148EXPORT_SYMBOL(blk_set_stacking_limits);
150 149