aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoe Perches2012-12-17 18:01:47 -0600
committerLinus Torvalds2012-12-17 19:15:18 -0600
commit5023d3472d444747bfa12e9798d7993e7efb8287 (patch)
tree384454623fc76da468021e0d58846debec536014 /scripts
parent0ad50c3896afbb3c103409a18260e601b87a744c (diff)
downloadkernel-omap-5023d3472d444747bfa12e9798d7993e7efb8287.tar.gz
kernel-omap-5023d3472d444747bfa12e9798d7993e7efb8287.tar.xz
kernel-omap-5023d3472d444747bfa12e9798d7993e7efb8287.zip
checkpatch: warn on unnecessary line continuations
When the previous line is not a line continuation and the current line has a line continuation but is not a #define, emit a warning. Signed-off-by: Joe Perches <joe@perches.com> Cc: Peter Hurley <peter@hurleysoftware.com> Cc: Andy Whitcroft <apw@canonical.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts')
-rwxr-xr-xscripts/checkpatch.pl9
1 files changed, 9 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f18750e3bd6c..d4f61a6fed5d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3013,6 +3013,15 @@ sub process {
3013 "Macros with complex values should be enclosed in parenthesis\n" . "$herectx"); 3013 "Macros with complex values should be enclosed in parenthesis\n" . "$herectx");
3014 } 3014 }
3015 } 3015 }
3016
3017# check for line continuations outside of #defines
3018
3019 } else {
3020 if ($prevline !~ /^..*\\$/ &&
3021 $line =~ /^\+.*\\$/) {
3022 WARN("LINE_CONTINUATIONS",
3023 "Avoid unnecessary line continuations\n" . $herecurr);
3024 }
3016 } 3025 }
3017 3026
3018# do {} while (0) macro tests: 3027# do {} while (0) macro tests: