aboutsummaryrefslogtreecommitdiffstats
path: root/exynos
diff options
context:
space:
mode:
authorTobias Jakobi2015-09-08 10:22:31 -0500
committerEmil Velikov2015-09-21 11:43:14 -0500
commit6a4479da71e93ef5141d9c493c235c2beb64170a (patch)
treeb074e905534eb6b2e1a8cd8212c3209f0af65cb8 /exynos
parent76d1c6b15725f1e7de3c60b0398639e06bf295be (diff)
downloadexternal-libgbm-6a4479da71e93ef5141d9c493c235c2beb64170a.tar.gz
external-libgbm-6a4479da71e93ef5141d9c493c235c2beb64170a.tar.xz
external-libgbm-6a4479da71e93ef5141d9c493c235c2beb64170a.zip
exynos/fimg2d: remove superfluous initialization of g2d_point_val
The g2d_point_val union consists of two coordinates of 16 bits. Whenever this union is used though, both coordinates are explicitly set. Hence prior initialization is unnecessary. Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Diffstat (limited to 'exynos')
-rw-r--r--exynos/exynos_fimg2d.c19
1 files changed, 0 insertions, 19 deletions
diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c
index d7cbb243..fbc77a3d 100644
--- a/exynos/exynos_fimg2d.c
+++ b/exynos/exynos_fimg2d.c
@@ -380,15 +380,12 @@ g2d_solid_fill(struct g2d_context *ctx, struct g2d_image *img,
380 if (y + h > img->height) 380 if (y + h > img->height)
381 h = img->height - y; 381 h = img->height - y;
382 382
383 pt.val = 0;
384 pt.data.x = x; 383 pt.data.x = x;
385 pt.data.y = y; 384 pt.data.y = y;
386 g2d_add_cmd(ctx, DST_LEFT_TOP_REG, pt.val); 385 g2d_add_cmd(ctx, DST_LEFT_TOP_REG, pt.val);
387 386
388 pt.val = 0;
389 pt.data.x = x + w; 387 pt.data.x = x + w;
390 pt.data.y = y + h; 388 pt.data.y = y + h;
391
392 g2d_add_cmd(ctx, DST_RIGHT_BOTTOM_REG, pt.val); 389 g2d_add_cmd(ctx, DST_RIGHT_BOTTOM_REG, pt.val);
393 390
394 g2d_add_cmd(ctx, SF_COLOR_REG, img->color); 391 g2d_add_cmd(ctx, SF_COLOR_REG, img->color);
@@ -460,20 +457,16 @@ g2d_copy(struct g2d_context *ctx, struct g2d_image *src,
460 g2d_add_base_addr(ctx, src, g2d_src); 457 g2d_add_base_addr(ctx, src, g2d_src);
461 g2d_add_cmd(ctx, SRC_STRIDE_REG, src->stride); 458 g2d_add_cmd(ctx, SRC_STRIDE_REG, src->stride);
462 459
463 pt.val = 0;
464 pt.data.x = src_x; 460 pt.data.x = src_x;
465 pt.data.y = src_y; 461 pt.data.y = src_y;
466 g2d_add_cmd(ctx, SRC_LEFT_TOP_REG, pt.val); 462 g2d_add_cmd(ctx, SRC_LEFT_TOP_REG, pt.val);
467 pt.val = 0;
468 pt.data.x = src_x + w; 463 pt.data.x = src_x + w;
469 pt.data.y = src_y + h; 464 pt.data.y = src_y + h;
470 g2d_add_cmd(ctx, SRC_RIGHT_BOTTOM_REG, pt.val); 465 g2d_add_cmd(ctx, SRC_RIGHT_BOTTOM_REG, pt.val);
471 466
472 pt.val = 0;
473 pt.data.x = dst_x; 467 pt.data.x = dst_x;
474 pt.data.y = dst_y; 468 pt.data.y = dst_y;
475 g2d_add_cmd(ctx, DST_LEFT_TOP_REG, pt.val); 469 g2d_add_cmd(ctx, DST_LEFT_TOP_REG, pt.val);
476 pt.val = 0;
477 pt.data.x = dst_x + w; 470 pt.data.x = dst_x + w;
478 pt.data.y = dst_y + h; 471 pt.data.y = dst_y + h;
479 g2d_add_cmd(ctx, DST_RIGHT_BOTTOM_REG, pt.val); 472 g2d_add_cmd(ctx, DST_RIGHT_BOTTOM_REG, pt.val);
@@ -581,20 +574,16 @@ g2d_copy_with_scale(struct g2d_context *ctx, struct g2d_image *src,
581 g2d_add_cmd(ctx, SRC_YSCALE_REG, scale_y); 574 g2d_add_cmd(ctx, SRC_YSCALE_REG, scale_y);
582 } 575 }
583 576
584 pt.val = 0;
585 pt.data.x = src_x; 577 pt.data.x = src_x;
586 pt.data.y = src_y; 578 pt.data.y = src_y;
587 g2d_add_cmd(ctx, SRC_LEFT_TOP_REG, pt.val); 579 g2d_add_cmd(ctx, SRC_LEFT_TOP_REG, pt.val);
588 pt.val = 0;
589 pt.data.x = src_x + src_w; 580 pt.data.x = src_x + src_w;
590 pt.data.y = src_y + src_h; 581 pt.data.y = src_y + src_h;
591 g2d_add_cmd(ctx, SRC_RIGHT_BOTTOM_REG, pt.val); 582 g2d_add_cmd(ctx, SRC_RIGHT_BOTTOM_REG, pt.val);
592 583
593 pt.val = 0;
594 pt.data.x = dst_x; 584 pt.data.x = dst_x;
595 pt.data.y = dst_y; 585 pt.data.y = dst_y;
596 g2d_add_cmd(ctx, DST_LEFT_TOP_REG, pt.val); 586 g2d_add_cmd(ctx, DST_LEFT_TOP_REG, pt.val);
597 pt.val = 0;
598 pt.data.x = dst_x + dst_w; 587 pt.data.x = dst_x + dst_w;
599 pt.data.y = dst_y + dst_h; 588 pt.data.y = dst_y + dst_h;
600 g2d_add_cmd(ctx, DST_RIGHT_BOTTOM_REG, pt.val); 589 g2d_add_cmd(ctx, DST_RIGHT_BOTTOM_REG, pt.val);
@@ -700,20 +689,16 @@ g2d_blend(struct g2d_context *ctx, struct g2d_image *src,
700 g2d_add_cmd(ctx, BITBLT_COMMAND_REG, bitblt.val); 689 g2d_add_cmd(ctx, BITBLT_COMMAND_REG, bitblt.val);
701 g2d_add_cmd(ctx, BLEND_FUNCTION_REG, blend.val); 690 g2d_add_cmd(ctx, BLEND_FUNCTION_REG, blend.val);
702 691
703 pt.val = 0;
704 pt.data.x = src_x; 692 pt.data.x = src_x;
705 pt.data.y = src_y; 693 pt.data.y = src_y;
706 g2d_add_cmd(ctx, SRC_LEFT_TOP_REG, pt.val); 694 g2d_add_cmd(ctx, SRC_LEFT_TOP_REG, pt.val);
707 pt.val = 0;
708 pt.data.x = src_x + w; 695 pt.data.x = src_x + w;
709 pt.data.y = src_y + h; 696 pt.data.y = src_y + h;
710 g2d_add_cmd(ctx, SRC_RIGHT_BOTTOM_REG, pt.val); 697 g2d_add_cmd(ctx, SRC_RIGHT_BOTTOM_REG, pt.val);
711 698
712 pt.val = 0;
713 pt.data.x = dst_x; 699 pt.data.x = dst_x;
714 pt.data.y = dst_y; 700 pt.data.y = dst_y;
715 g2d_add_cmd(ctx, DST_LEFT_TOP_REG, pt.val); 701 g2d_add_cmd(ctx, DST_LEFT_TOP_REG, pt.val);
716 pt.val = 0;
717 pt.data.x = dst_x + w; 702 pt.data.x = dst_x + w;
718 pt.data.y = dst_y + h; 703 pt.data.y = dst_y + h;
719 g2d_add_cmd(ctx, DST_RIGHT_BOTTOM_REG, pt.val); 704 g2d_add_cmd(ctx, DST_RIGHT_BOTTOM_REG, pt.val);
@@ -829,20 +814,16 @@ g2d_scale_and_blend(struct g2d_context *ctx, struct g2d_image *src,
829 g2d_add_cmd(ctx, BITBLT_COMMAND_REG, bitblt.val); 814 g2d_add_cmd(ctx, BITBLT_COMMAND_REG, bitblt.val);
830 g2d_add_cmd(ctx, BLEND_FUNCTION_REG, blend.val); 815 g2d_add_cmd(ctx, BLEND_FUNCTION_REG, blend.val);
831 816
832 pt.val = 0;
833 pt.data.x = src_x; 817 pt.data.x = src_x;
834 pt.data.y = src_y; 818 pt.data.y = src_y;
835 g2d_add_cmd(ctx, SRC_LEFT_TOP_REG, pt.val); 819 g2d_add_cmd(ctx, SRC_LEFT_TOP_REG, pt.val);
836 pt.val = 0;
837 pt.data.x = src_x + src_w; 820 pt.data.x = src_x + src_w;
838 pt.data.y = src_y + src_h; 821 pt.data.y = src_y + src_h;
839 g2d_add_cmd(ctx, SRC_RIGHT_BOTTOM_REG, pt.val); 822 g2d_add_cmd(ctx, SRC_RIGHT_BOTTOM_REG, pt.val);
840 823
841 pt.val = 0;
842 pt.data.x = dst_x; 824 pt.data.x = dst_x;
843 pt.data.y = dst_y; 825 pt.data.y = dst_y;
844 g2d_add_cmd(ctx, DST_LEFT_TOP_REG, pt.val); 826 g2d_add_cmd(ctx, DST_LEFT_TOP_REG, pt.val);
845 pt.val = 0;
846 pt.data.x = dst_x + dst_w; 827 pt.data.x = dst_x + dst_w;
847 pt.data.y = dst_y + dst_h; 828 pt.data.y = dst_y + dst_h;
848 g2d_add_cmd(ctx, DST_RIGHT_BOTTOM_REG, pt.val); 829 g2d_add_cmd(ctx, DST_RIGHT_BOTTOM_REG, pt.val);