net: ti: prueth_switch: Offload multicast filtering for host port

Prueth switch firmware supports offloading of filtering of multicast
traffic just for CPU port. The programming model is similar to Dual EMAC
mode. Therefore reuse the code to implement offload support in switch
mode.

Note that in switch mode multicast filtering is always enabled.
Currently, therefore no way to disable filter completely because setting
ALLMULTI flag on bridge device is no-op. (See net/bridge/br_device.c
bridge device's ndo_set_rx_mode is set to br_dev_set_multicast_list()
which is an empty function).

Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>

3 files changed, 99 insertions, 12 deletions

diff --git a/drivers/net/ethernet/ti/prueth.h b/drivers/net/ethernet/ti/prueth.h
index ab6fcfe769cb..6720b25a4751 100644
--- a/drivers/net/ethernet/ti/prueth.h
+++ b/drivers/net/ethernet/ti/prueth.h
@@ -505,4 +505,7 @@ static inline void emac_finish_napi(struct prueth_emac *emac,
         enable_irq(irq);
 }
 
+void emac_mc_filter_bin_allow(struct prueth_emac *emac, u8 hash);
+void emac_mc_filter_bin_disallow(struct prueth_emac *emac, u8 hash);
+u8 emac_get_mc_hash(u8 *mac, u8 *mask);
 #endif /* __NET_TI_PRUETH_H */
diff --git a/drivers/net/ethernet/ti/prueth_core.c b/drivers/net/ethernet/ti/prueth_core.c
index 0d06ac433ad3..644014f8349d 100644
--- a/drivers/net/ethernet/ti/prueth_core.c
+++ b/drivers/net/ethernet/ti/prueth_core.c
@@ -2072,7 +2072,7 @@ static void emac_mc_filter_hashmask(struct prueth_emac *emac,
                     ICSS_EMAC_FW_MULTICAST_FILTER_MASK_SIZE_BYTES);
 }
 
-static void emac_mc_filter_bin_allow(struct prueth_emac *emac, u8 hash)
+static void emac_mc_filter_bin_update(struct prueth_emac *emac, u8 hash, u8 val)
 {
         struct prueth *prueth = emac->prueth;
         u32 mc_filter_tbl_base = prueth->fw_offsets->mc_filter_tbl;
@@ -2083,11 +2083,20 @@ static void emac_mc_filter_bin_allow(struct prueth_emac *emac, u8 hash)
                 ram = prueth->mem[PRUETH_MEM_DRAM1].va;
 
         mc_filter_tbl = ram + mc_filter_tbl_base;
-        writeb(ICSS_EMAC_FW_MULTICAST_FILTER_HOST_RCV_ALLOWED,
-               mc_filter_tbl + hash);
+        writeb(val, mc_filter_tbl + hash);
 }
 
-static u8 emac_get_mc_hash(u8 *mac, u8 *mask)
+void emac_mc_filter_bin_allow(struct prueth_emac *emac, u8 hash)
+{
+        emac_mc_filter_bin_update(emac, hash, ICSS_EMAC_FW_MULTICAST_FILTER_HOST_RCV_ALLOWED);
+}
+
+void emac_mc_filter_bin_disallow(struct prueth_emac *emac, u8 hash)
+{
+        emac_mc_filter_bin_update(emac, hash, ICSS_EMAC_FW_MULTICAST_FILTER_HOST_RCV_NOT_ALLOWED);
+}
+
+u8 emac_get_mc_hash(u8 *mac, u8 *mask)
 {
         int j;
         u8 hash;
@@ -2117,13 +2126,6 @@ static void emac_ndo_set_rx_mode(struct net_device *ndev)
         u32 mask;
         u8 hash;
 
-        if (PRUETH_IS_SWITCH(prueth)) {
-                netdev_dbg(ndev,
-                           "%s: promisc/mc filtering not supported for switch\n",
-                           __func__);
-                return;
-        }
-
         if (promisc && PRUETH_IS_LRE(prueth)) {
                 netdev_dbg(ndev,
                            "%s: promisc mode not supported for LRE\n",
@@ -2166,7 +2168,7 @@ static void emac_ndo_set_rx_mode(struct net_device *ndev)
                         goto unlock;
         }
 
-        if (ndev->flags & IFF_ALLMULTI)
+        if (ndev->flags & IFF_ALLMULTI && !PRUETH_IS_SWITCH(prueth))
                 goto unlock;
 
         emac_mc_filter_ctrl(emac, true);        /* all multicast blocked */
@@ -2178,6 +2180,14 @@ static void emac_ndo_set_rx_mode(struct net_device *ndev)
                 hash = emac_get_mc_hash(ha->addr, emac->mc_filter_mask);
                 emac_mc_filter_bin_allow(emac, hash);
         }
+
+        /* Add bridge device's MC addresses as well */
+        if (prueth->hw_bridge_dev) {
+                netdev_for_each_mc_addr(ha, prueth->hw_bridge_dev) {
+                        hash = emac_get_mc_hash(ha->addr, emac->mc_filter_mask);
+                        emac_mc_filter_bin_allow(emac, hash);
+                }
+        }
 unlock:
         spin_unlock_irqrestore(&emac->addr_lock, flags);
 }
diff --git a/drivers/net/ethernet/ti/prueth_switch.c b/drivers/net/ethernet/ti/prueth_switch.c
index f5891306baad..edb9473928b7 100644
--- a/drivers/net/ethernet/ti/prueth_switch.c
+++ b/drivers/net/ethernet/ti/prueth_switch.c
@@ -1075,6 +1075,68 @@ static int prueth_switchdev_attr_set(struct net_device *ndev,
         return err;
 }
 
+static int prueth_switchdev_obj_add(struct net_device *ndev,
+                                    const struct switchdev_obj *obj,
+                                    struct switchdev_trans *trans,
+                                    struct netlink_ext_ack *extack)
+{
+        struct prueth_emac *emac = netdev_priv(ndev);
+        struct prueth *prueth = emac->prueth;
+        struct switchdev_obj_port_mdb *mdb;
+        int ret = 0;
+        u8 hash;
+
+        if (switchdev_trans_ph_prepare(trans))
+                return 0;
+
+        switch (obj->id) {
+        case SWITCHDEV_OBJ_ID_HOST_MDB:
+                mdb = SWITCHDEV_OBJ_PORT_MDB(obj);
+                dev_dbg(prueth->dev, "MDB add: %s: vid %u:%pM  port: %x\n",
+                        ndev->name, mdb->vid, mdb->addr, emac->port_id);
+                hash = emac_get_mc_hash(mdb->addr, emac->mc_filter_mask);
+                emac_mc_filter_bin_allow(emac, hash);
+                break;
+        default:
+                ret = -EOPNOTSUPP;
+                break;
+        }
+
+        return ret;
+}
+
+static int prueth_switchdev_obj_del(struct net_device *ndev,
+                                    const struct switchdev_obj *obj)
+{
+        struct prueth_emac *emac = netdev_priv(ndev);
+        struct prueth *prueth = emac->prueth;
+        struct switchdev_obj_port_mdb *mdb;
+        struct netdev_hw_addr *ha;
+        u8 hash, tmp_hash;
+        int ret = 0;
+
+        switch (obj->id) {
+        case SWITCHDEV_OBJ_ID_HOST_MDB:
+                mdb = SWITCHDEV_OBJ_PORT_MDB(obj);
+                dev_dbg(prueth->dev, "MDB del: %s: vid %u:%pM  port: %x\n",
+                        ndev->name, mdb->vid, mdb->addr, emac->port_id);
+                hash = emac_get_mc_hash(mdb->addr, emac->mc_filter_mask);
+                netdev_for_each_mc_addr(ha, prueth->hw_bridge_dev) {
+                        tmp_hash = emac_get_mc_hash(ha->addr, emac->mc_filter_mask);
+                        /* Another MC address is in the bin. Don't disable. */
+                        if (tmp_hash == hash)
+                                return 0;
+                }
+                emac_mc_filter_bin_disallow(emac, hash);
+                break;
+        default:
+                ret = -EOPNOTSUPP;
+                break;
+        }
+
+        return ret;
+}
+
 /* switchdev notifiers */
 static int prueth_sw_switchdev_blocking_event(struct notifier_block *unused,
                                               unsigned long event, void *ptr)
@@ -1093,6 +1155,18 @@ static int prueth_sw_switchdev_blocking_event(struct notifier_block *unused,
                                                      prueth_sw_port_dev_check,
                                                      prueth_switchdev_attr_set);
                 return notifier_from_errno(err);
+
+        case SWITCHDEV_PORT_OBJ_ADD:
+                err = switchdev_handle_port_obj_add(ndev, ptr,
+                                                    prueth_sw_port_dev_check,
+                                                    prueth_switchdev_obj_add);
+                return notifier_from_errno(err);
+
+        case SWITCHDEV_PORT_OBJ_DEL:
+                err = switchdev_handle_port_obj_del(ndev, ptr,
+                                                    prueth_sw_port_dev_check,
+                                                    prueth_switchdev_obj_del);
+                return notifier_from_errno(err);
         default:
                 break;
         }