diff options
author | Takashi Iwai | 2020-04-24 01:12:22 -0500 |
---|---|---|
committer | Greg Kroah-Hartman | 2020-05-10 03:31:31 -0500 |
commit | 85701f4768a11de54f45fcad14de47460ab44e35 (patch) | |
tree | 1e7b2c46acd8ef07c6239fa564d014dbd3363d95 | |
parent | b8b42c8dcf44be39321542d1403e19343ea8224a (diff) | |
download | kernel-85701f4768a11de54f45fcad14de47460ab44e35.tar.gz kernel-85701f4768a11de54f45fcad14de47460ab44e35.tar.xz kernel-85701f4768a11de54f45fcad14de47460ab44e35.zip |
ALSA: hda: Match both PCI ID and SSID for driver blacklist
commit 977dfef40c8996b69afe23a9094d184049efb7bb upstream.
The commit 3c6fd1f07ed0 ("ALSA: hda: Add driver blacklist") added a
new blacklist for the devices that are known to have empty codecs, and
one of the entries was ASUS ROG Zenith II (PCI SSID 1043:874f).
However, it turned out that the very same PCI SSID is used for the
previous model that does have the valid HD-audio codecs and the change
broke the sound on it.
Since the empty codec problem appear on the certain AMD platform (PCI
ID 1022:1487), this patch changes the blacklist matching to both PCI
ID and SSID using pci_match_id(). Also, the entry that was removed by
the previous fix for ASUS ROG Zenigh II is re-added.
Link: https://lore.kernel.org/r/20200424061222.19792-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | sound/pci/hda/hda_intel.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 1673479b4eef..612441508e80 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c | |||
@@ -2023,9 +2023,10 @@ static void pcm_mmap_prepare(struct snd_pcm_substream *substream, | |||
2023 | * some HD-audio PCI entries are exposed without any codecs, and such devices | 2023 | * some HD-audio PCI entries are exposed without any codecs, and such devices |
2024 | * should be ignored from the beginning. | 2024 | * should be ignored from the beginning. |
2025 | */ | 2025 | */ |
2026 | static const struct snd_pci_quirk driver_blacklist[] = { | 2026 | static const struct pci_device_id driver_blacklist[] = { |
2027 | SND_PCI_QUIRK(0x1462, 0xcb59, "MSI TRX40 Creator", 0), | 2027 | { PCI_DEVICE_SUB(0x1022, 0x1487, 0x1043, 0x874f) }, /* ASUS ROG Zenith II / Strix */ |
2028 | SND_PCI_QUIRK(0x1462, 0xcb60, "MSI TRX40", 0), | 2028 | { PCI_DEVICE_SUB(0x1022, 0x1487, 0x1462, 0xcb59) }, /* MSI TRX40 Creator */ |
2029 | { PCI_DEVICE_SUB(0x1022, 0x1487, 0x1462, 0xcb60) }, /* MSI TRX40 */ | ||
2029 | {} | 2030 | {} |
2030 | }; | 2031 | }; |
2031 | 2032 | ||
@@ -2064,7 +2065,7 @@ static int azx_probe(struct pci_dev *pci, | |||
2064 | bool schedule_probe; | 2065 | bool schedule_probe; |
2065 | int err; | 2066 | int err; |
2066 | 2067 | ||
2067 | if (snd_pci_quirk_lookup(pci, driver_blacklist)) { | 2068 | if (pci_match_id(driver_blacklist, pci)) { |
2068 | dev_info(&pci->dev, "Skipping the blacklisted device\n"); | 2069 | dev_info(&pci->dev, "Skipping the blacklisted device\n"); |
2069 | return -ENODEV; | 2070 | return -ENODEV; |
2070 | } | 2071 | } |