summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKrzysztof Kozlowski2020-10-26 10:36:20 -0500
committerGreg Kroah-Hartman2020-12-08 03:17:34 -0600
commitd36c515e54cd0c2c0cb3abde1fe7df804a3c1042 (patch)
tree28801a339810302554e5466348cc1516a7bbf73f
parent7dc552407c7e8221e22d3128aa0fab71b8ab2f98 (diff)
downloadkernel-d36c515e54cd0c2c0cb3abde1fe7df804a3c1042.tar.gz
kernel-d36c515e54cd0c2c0cb3abde1fe7df804a3c1042.tar.xz
kernel-d36c515e54cd0c2c0cb3abde1fe7df804a3c1042.zip
dt-bindings: net: correct interrupt flags in examples
[ Upstream commit 4d521943f76bd0d1e68ea5e02df7aadd30b2838a ] GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is: ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH Fixes: a1a8b4594f8d ("NFC: pn544: i2c: Add DTS Documentation") Fixes: 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI driver") Fixes: e3b329221567 ("dt-bindings: can: tcan4x5x: Update binding to use interrupt property") Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Acked-by: Rob Herring <robh@kernel.org> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> # for tcan4x5x.txt Link: https://lore.kernel.org/r/20201026153620.89268-1-krzk@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--Documentation/devicetree/bindings/net/nfc/nxp-nci.txt2
-rw-r--r--Documentation/devicetree/bindings/net/nfc/pn544.txt2
2 files changed, 2 insertions, 2 deletions
diff --git a/Documentation/devicetree/bindings/net/nfc/nxp-nci.txt b/Documentation/devicetree/bindings/net/nfc/nxp-nci.txt
index 92486733df71..8ebc5200032a 100644
--- a/Documentation/devicetree/bindings/net/nfc/nxp-nci.txt
+++ b/Documentation/devicetree/bindings/net/nfc/nxp-nci.txt
@@ -26,7 +26,7 @@ Example (for ARM-based BeagleBone with NPC100 NFC controller on I2C2):
26 clock-frequency = <100000>; 26 clock-frequency = <100000>;
27 27
28 interrupt-parent = <&gpio1>; 28 interrupt-parent = <&gpio1>;
29 interrupts = <29 GPIO_ACTIVE_HIGH>; 29 interrupts = <29 IRQ_TYPE_LEVEL_HIGH>;
30 30
31 enable-gpios = <&gpio0 30 GPIO_ACTIVE_HIGH>; 31 enable-gpios = <&gpio0 30 GPIO_ACTIVE_HIGH>;
32 firmware-gpios = <&gpio0 31 GPIO_ACTIVE_HIGH>; 32 firmware-gpios = <&gpio0 31 GPIO_ACTIVE_HIGH>;
diff --git a/Documentation/devicetree/bindings/net/nfc/pn544.txt b/Documentation/devicetree/bindings/net/nfc/pn544.txt
index 538a86f7b2b0..982d4dd4eba3 100644
--- a/Documentation/devicetree/bindings/net/nfc/pn544.txt
+++ b/Documentation/devicetree/bindings/net/nfc/pn544.txt
@@ -26,7 +26,7 @@ Example (for ARM-based BeagleBone with PN544 on I2C2):
26 clock-frequency = <400000>; 26 clock-frequency = <400000>;
27 27
28 interrupt-parent = <&gpio1>; 28 interrupt-parent = <&gpio1>;
29 interrupts = <17 GPIO_ACTIVE_HIGH>; 29 interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
30 30
31 enable-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; 31 enable-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>;
32 firmware-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>; 32 firmware-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;