aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYoshisato Yanagisawa2019-01-09 22:58:33 -0600
committerYoshisato Yanagisawa2019-01-09 23:29:45 -0600
commitf07f721235e9f074cdb7c470ad52d2f240d4e706 (patch)
treef05c4c6d0a8b5eb0c0081ae614f4295e44b01ade
parenteeeb9f96c8995c6c8213cb13a790296281291665 (diff)
downloadplatform-build-f07f721235e9f074cdb7c470ad52d2f240d4e706.tar.gz
platform-build-f07f721235e9f074cdb7c470ad52d2f240d4e706.tar.xz
platform-build-f07f721235e9f074cdb7c470ad52d2f240d4e706.zip
Remove code to start Goma compiler_proxy.
Since the code to start compiler proxy is implemented in soong now (https://android-review.googlesource.com/c/platform/build/soong/+/839293). We do not need to do that in goma.mk. Bug: 118390303 Test: After staring goma client, executed followings: Test: USE_GOMA=true make -j 4 Change-Id: If3da9908483e183f539c0d6ef9dc5826200b0d6b Signed-off-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
-rw-r--r--core/goma.mk14
1 files changed, 1 insertions, 13 deletions
diff --git a/core/goma.mk b/core/goma.mk
index 3787dfd19..f5064e621 100644
--- a/core/goma.mk
+++ b/core/goma.mk
@@ -17,6 +17,7 @@
17# Notice: this works only with Google's Goma build infrastructure. 17# Notice: this works only with Google's Goma build infrastructure.
18ifneq ($(filter-out false,$(USE_GOMA)),) 18ifneq ($(filter-out false,$(USE_GOMA)),)
19 # Goma requires a lot of processes and file descriptors. 19 # Goma requires a lot of processes and file descriptors.
20 # TODO(yyanagisawa): move these code to build/soong/uil/build/goma.go
20 ifeq ($(shell echo $$(($$(ulimit -u) < 2500 || $$(ulimit -n) < 16000))),1) 21 ifeq ($(shell echo $$(($$(ulimit -u) < 2500 || $$(ulimit -n) < 16000))),1)
21 $(warning Max user processes and/or open files are insufficient) 22 $(warning Max user processes and/or open files are insufficient)
22 ifeq ($(shell uname),Darwin) 23 ifeq ($(shell uname),Darwin)
@@ -31,26 +32,13 @@ ifneq ($(filter-out false,$(USE_GOMA)),)
31 else 32 else
32 goma_dir := $(HOME)/goma 33 goma_dir := $(HOME)/goma
33 endif 34 endif
34 goma_ctl := $(goma_dir)/goma_ctl.py
35 GOMA_CC := $(goma_dir)/gomacc 35 GOMA_CC := $(goma_dir)/gomacc
36 36
37 $(if $(wildcard $(goma_ctl)),, \
38 $(warning You should have goma in $$GOMA_DIR or $(HOME)/goma) \
39 $(error See go/ma/how-to-use-goma/how-to-use-goma-for-android for detail))
40
41 # Append gomacc to existing *_WRAPPER variables so it's possible to 37 # Append gomacc to existing *_WRAPPER variables so it's possible to
42 # use both ccache and gomacc. 38 # use both ccache and gomacc.
43 CC_WRAPPER := $(strip $(CC_WRAPPER) $(GOMA_CC)) 39 CC_WRAPPER := $(strip $(CC_WRAPPER) $(GOMA_CC))
44 CXX_WRAPPER := $(strip $(CXX_WRAPPER) $(GOMA_CC)) 40 CXX_WRAPPER := $(strip $(CXX_WRAPPER) $(GOMA_CC))
45 JAVAC_WRAPPER := $(strip $(JAVAC_WRAPPER) $(GOMA_CC)) 41 JAVAC_WRAPPER := $(strip $(JAVAC_WRAPPER) $(GOMA_CC))
46 42
47 # gomacc can start goma client's daemon process automatically, but
48 # it is safer and faster to start up it beforehand. We run this as a
49 # background process so this won't slow down the build.
50 ifndef NOSTART_GOMA
51 $(shell ( $(goma_ctl) ensure_start ) &> /dev/null &)
52 endif
53
54 goma_ctl :=
55 goma_dir := 43 goma_dir :=
56endif 44endif