summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Wright2018-02-23 15:21:26 -0600
committerMichael Wright2018-03-01 16:15:13 -0600
commit47cde04edda4f9144ff5f2aa14e571b3ec458915 (patch)
tree8b6d03ea04ce92b4a593329432a5dd7b84baaacf /vibrator/1.2/vts/functional
parent668583d52900b1f653bbd9c66c91cd318e0b9b46 (diff)
downloadplatform-hardware-interfaces-47cde04edda4f9144ff5f2aa14e571b3ec458915.tar.gz
platform-hardware-interfaces-47cde04edda4f9144ff5f2aa14e571b3ec458915.tar.xz
platform-hardware-interfaces-47cde04edda4f9144ff5f2aa14e571b3ec458915.zip
Add functional tests for bad input to 1.2
Bug: 73336721 Test: run vts Change-Id: Idec3fe2c168fe56d9d51a2460ac3b39ae4a05416
Diffstat (limited to 'vibrator/1.2/vts/functional')
-rw-r--r--vibrator/1.2/vts/functional/VtsHalVibratorV1_2TargetTest.cpp58
1 files changed, 54 insertions, 4 deletions
diff --git a/vibrator/1.2/vts/functional/VtsHalVibratorV1_2TargetTest.cpp b/vibrator/1.2/vts/functional/VtsHalVibratorV1_2TargetTest.cpp
index d8df18bb..3ed689aa 100644
--- a/vibrator/1.2/vts/functional/VtsHalVibratorV1_2TargetTest.cpp
+++ b/vibrator/1.2/vts/functional/VtsHalVibratorV1_2TargetTest.cpp
@@ -33,6 +33,8 @@ using ::android::hardware::Return;
33using ::android::hardware::Void; 33using ::android::hardware::Void;
34using ::android::sp; 34using ::android::sp;
35 35
36#define EXPECT_OK(ret) ASSERT_TRUE((ret).isOk())
37
36// Test environment for Vibrator HIDL HAL. 38// Test environment for Vibrator HIDL HAL.
37class VibratorHidlEnvironment : public ::testing::VtsHalHidlTargetTestEnvBase { 39class VibratorHidlEnvironment : public ::testing::VtsHalHidlTargetTestEnvBase {
38 public: 40 public:
@@ -65,22 +67,70 @@ class VibratorHidlTest_1_2 : public ::testing::VtsHalHidlTargetTestBase {
65static void validatePerformEffect(Status status, uint32_t lengthMs) { 67static void validatePerformEffect(Status status, uint32_t lengthMs) {
66 ASSERT_TRUE(status == Status::OK || status == Status::UNSUPPORTED_OPERATION); 68 ASSERT_TRUE(status == Status::OK || status == Status::UNSUPPORTED_OPERATION);
67 if (status == Status::OK) { 69 if (status == Status::OK) {
68 ASSERT_GT(lengthMs, static_cast<uint32_t>(0)) 70 ASSERT_LT(static_cast<uint32_t>(0), lengthMs)
69 << "Effects that return OK must return a non-zero duration"; 71 << "Effects that return OK must return a positive duration";
70 } else { 72 } else {
71 ASSERT_EQ(lengthMs, static_cast<uint32_t>(0)) 73 ASSERT_EQ(static_cast<uint32_t>(0), lengthMs)
72 << "Effects that return UNSUPPORTED_OPERATION must have a duration of zero"; 74 << "Effects that return UNSUPPORTED_OPERATION must have a duration of zero";
73 } 75 }
74} 76}
75 77
78static void validatePerformEffectBadInput(Status status, uint32_t lengthMs) {
79 ASSERT_EQ(Status::UNSUPPORTED_OPERATION, status);
80 ASSERT_EQ(static_cast<uint32_t>(0), lengthMs)
81 << "Effects that return UNSUPPORTED_OPERATION must have a duration of zero";
82}
83
84/*
85 * Test to make sure effects within the valid range return are either supported and return OK with
86 * a valid duration, or are unsupported and return UNSUPPORTED_OPERATION with a duration of 0.
87 */
76TEST_F(VibratorHidlTest_1_2, PerformEffect_1_2) { 88TEST_F(VibratorHidlTest_1_2, PerformEffect_1_2) {
77 for (const auto& effect : hidl_enum_iterator<Effect>()) { 89 for (const auto& effect : hidl_enum_iterator<Effect>()) {
78 for (const auto& strength : hidl_enum_iterator<EffectStrength>()) { 90 for (const auto& strength : hidl_enum_iterator<EffectStrength>()) {
79 vibrator->perform_1_2(effect, strength, validatePerformEffect); 91 EXPECT_OK(vibrator->perform_1_2(effect, strength, validatePerformEffect));
80 } 92 }
81 } 93 }
82} 94}
83 95
96/*
97 * Test to make sure effect values above the valid range are rejected.
98 */
99TEST_F(VibratorHidlTest_1_2, PerformEffect_1_2_BadEffects_AboveValidRange) {
100 Effect effect = *std::prev(hidl_enum_iterator<Effect>().end());
101 Effect badEffect = static_cast<Effect>(static_cast<int32_t>(effect) + 1);
102 EXPECT_OK(
103 vibrator->perform_1_2(badEffect, EffectStrength::LIGHT, validatePerformEffectBadInput));
104}
105
106/*
107 * Test to make sure effect values below the valid range are rejected.
108 */
109TEST_F(VibratorHidlTest_1_2, PerformEffect_1_2_BadEffects_BelowValidRange) {
110 Effect effect = *hidl_enum_iterator<Effect>().begin();
111 Effect badEffect = static_cast<Effect>(static_cast<int32_t>(effect) - 1);
112 EXPECT_OK(
113 vibrator->perform_1_2(badEffect, EffectStrength::LIGHT, validatePerformEffectBadInput));
114}
115
116/*
117 * Test to make sure strength values above the valid range are rejected.
118 */
119TEST_F(VibratorHidlTest_1_2, PerformEffect_1_2_BadStrength_AboveValidRange) {
120 EffectStrength strength = *std::prev(hidl_enum_iterator<EffectStrength>().end());
121 EffectStrength badStrength = static_cast<EffectStrength>(static_cast<int32_t>(strength) + 1);
122 EXPECT_OK(vibrator->perform_1_2(Effect::THUD, badStrength, validatePerformEffectBadInput));
123}
124
125/*
126 * Test to make sure strength values below the valid range are rejected.
127 */
128TEST_F(VibratorHidlTest_1_2, PerformEffect_1_2_BadStrength_BelowValidRange) {
129 EffectStrength strength = *hidl_enum_iterator<EffectStrength>().begin();
130 EffectStrength badStrength = static_cast<EffectStrength>(static_cast<int32_t>(strength) - 1);
131 EXPECT_OK(vibrator->perform_1_2(Effect::THUD, badStrength, validatePerformEffectBadInput));
132}
133
84int main(int argc, char** argv) { 134int main(int argc, char** argv) {
85 ::testing::AddGlobalTestEnvironment(VibratorHidlEnvironment::Instance()); 135 ::testing::AddGlobalTestEnvironment(VibratorHidlEnvironment::Instance());
86 ::testing::InitGoogleTest(&argc, argv); 136 ::testing::InitGoogleTest(&argc, argv);