summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristopher Ferris2015-10-14 15:20:10 -0500
committerChristopher Ferris2015-10-14 16:03:29 -0500
commit634df89db65374a035fdd4a0bc62ec37d295c466 (patch)
treeb7df301c516714bb23d3c13b89ce857407135367 /libcutils/tests
parentba0005118b78dc8ff456492bb1e16947ab26be9e (diff)
downloadplatform-system-core-634df89db65374a035fdd4a0bc62ec37d295c466.tar.gz
platform-system-core-634df89db65374a035fdd4a0bc62ec37d295c466.tar.xz
platform-system-core-634df89db65374a035fdd4a0bc62ec37d295c466.zip
Make allocations use unique_ptr.
Change-Id: I4b84b8106faeaeb61847f8f9d13fd6444f474efd
Diffstat (limited to 'libcutils/tests')
-rw-r--r--libcutils/tests/MemsetTest.cpp12
1 files changed, 6 insertions, 6 deletions
diff --git a/libcutils/tests/MemsetTest.cpp b/libcutils/tests/MemsetTest.cpp
index 45efc519c..a98485faa 100644
--- a/libcutils/tests/MemsetTest.cpp
+++ b/libcutils/tests/MemsetTest.cpp
@@ -20,6 +20,8 @@
20#include <sys/mman.h> 20#include <sys/mman.h>
21#include <sys/types.h> 21#include <sys/types.h>
22 22
23#include <memory>
24
23#include <cutils/memory.h> 25#include <cutils/memory.h>
24#include <gtest/gtest.h> 26#include <gtest/gtest.h>
25 27
@@ -127,14 +129,14 @@ void RunMemsetTests(test_e test_type, uint32_t value, int align[][2], size_t num
127 min_incr = 2; 129 min_incr = 2;
128 value |= value << 16; 130 value |= value << 16;
129 } 131 }
130 uint32_t* expected_buf = new uint32_t[MAX_TEST_SIZE/sizeof(uint32_t)]; 132 std::unique_ptr<uint32_t[]> expected_buf(new uint32_t[MAX_TEST_SIZE/sizeof(uint32_t)]);
131 for (size_t i = 0; i < MAX_TEST_SIZE/sizeof(uint32_t); i++) { 133 for (size_t i = 0; i < MAX_TEST_SIZE/sizeof(uint32_t); i++) {
132 expected_buf[i] = value; 134 expected_buf[i] = value;
133 } 135 }
134 136
135 // Allocate one large buffer with lots of extra space so that we can 137 // Allocate one large buffer with lots of extra space so that we can
136 // guarantee that all possible alignments will fit. 138 // guarantee that all possible alignments will fit.
137 uint8_t *buf = new uint8_t[3*MAX_TEST_SIZE]; 139 std::unique_ptr<uint8_t[]> buf(new uint8_t[3*MAX_TEST_SIZE]);
138 uint8_t *buf_align; 140 uint8_t *buf_align;
139 for (size_t i = 0; i < num_aligns; i++) { 141 for (size_t i = 0; i < num_aligns; i++) {
140 size_t incr = min_incr; 142 size_t incr = min_incr;
@@ -142,7 +144,7 @@ void RunMemsetTests(test_e test_type, uint32_t value, int align[][2], size_t num
142 incr = GetIncrement(len, min_incr); 144 incr = GetIncrement(len, min_incr);
143 145
144 buf_align = reinterpret_cast<uint8_t*>(GetAlignedPtr( 146 buf_align = reinterpret_cast<uint8_t*>(GetAlignedPtr(
145 buf+FENCEPOST_LENGTH, align[i][0], align[i][1])); 147 buf.get()+FENCEPOST_LENGTH, align[i][0], align[i][1]));
146 148
147 SetFencepost(&buf_align[-FENCEPOST_LENGTH]); 149 SetFencepost(&buf_align[-FENCEPOST_LENGTH]);
148 SetFencepost(&buf_align[len]); 150 SetFencepost(&buf_align[len]);
@@ -153,15 +155,13 @@ void RunMemsetTests(test_e test_type, uint32_t value, int align[][2], size_t num
153 } else { 155 } else {
154 android_memset32(reinterpret_cast<uint32_t*>(buf_align), value, len); 156 android_memset32(reinterpret_cast<uint32_t*>(buf_align), value, len);
155 } 157 }
156 ASSERT_EQ(0, memcmp(expected_buf, buf_align, len)) 158 ASSERT_EQ(0, memcmp(expected_buf.get(), buf_align, len))
157 << "Failed size " << len << " align " << align[i][0] << " " << align[i][1] << "\n"; 159 << "Failed size " << len << " align " << align[i][0] << " " << align[i][1] << "\n";
158 160
159 VerifyFencepost(&buf_align[-FENCEPOST_LENGTH]); 161 VerifyFencepost(&buf_align[-FENCEPOST_LENGTH]);
160 VerifyFencepost(&buf_align[len]); 162 VerifyFencepost(&buf_align[len]);
161 } 163 }
162 } 164 }
163 delete expected_buf;
164 delete buf;
165} 165}
166 166
167TEST(libcutils, android_memset16_non_zero) { 167TEST(libcutils, android_memset16_non_zero) {