summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Willemsen2016-05-25 15:19:49 -0500
committerDan Willemsen2016-06-01 15:41:23 -0500
commitee2da03e2666dcb01721b55aa4767e371120f4fb (patch)
treeb628830902bfb84f00c39cb391971e608a640252 /libnativebridge
parent58ea31cc9013b8aab168cb828571ffc44721d9ef (diff)
downloadplatform-system-core-ee2da03e2666dcb01721b55aa4767e371120f4fb.tar.gz
platform-system-core-ee2da03e2666dcb01721b55aa4767e371120f4fb.tar.xz
platform-system-core-ee2da03e2666dcb01721b55aa4767e371120f4fb.zip
Remove invalid uses of -l and -I
LOCAL_LDLIBS should only be used with -l flags for NDK and some host libraries. Other uses should use LOCAL_SHARED_LIBRARIES. LOCAL_LDFLAGS should not contain -l entries, they should be in LOCAL_LDLIBS instead. LOCAL_CFLAGS should not contain -I entries, those should use LOCAL_C_INCLUDES instead. Change-Id: Ic901aa14651572ac682166becd4f0cd86baecc34
Diffstat (limited to 'libnativebridge')
-rw-r--r--libnativebridge/Android.mk3
-rw-r--r--libnativebridge/tests/Android.nativebridge-dummy.mk4
2 files changed, 3 insertions, 4 deletions
diff --git a/libnativebridge/Android.mk b/libnativebridge/Android.mk
index d20d44cc2..b88621e7d 100644
--- a/libnativebridge/Android.mk
+++ b/libnativebridge/Android.mk
@@ -10,12 +10,11 @@ include $(CLEAR_VARS)
10LOCAL_MODULE:= libnativebridge 10LOCAL_MODULE:= libnativebridge
11 11
12LOCAL_SRC_FILES:= $(NATIVE_BRIDGE_COMMON_SRC_FILES) 12LOCAL_SRC_FILES:= $(NATIVE_BRIDGE_COMMON_SRC_FILES)
13LOCAL_SHARED_LIBRARIES := liblog 13LOCAL_SHARED_LIBRARIES := liblog libdl
14LOCAL_CLANG := true 14LOCAL_CLANG := true
15LOCAL_CPP_EXTENSION := .cc 15LOCAL_CPP_EXTENSION := .cc
16LOCAL_CFLAGS += -Werror -Wall 16LOCAL_CFLAGS += -Werror -Wall
17LOCAL_CPPFLAGS := -std=gnu++11 -fvisibility=protected 17LOCAL_CPPFLAGS := -std=gnu++11 -fvisibility=protected
18LOCAL_LDFLAGS := -ldl
19LOCAL_MULTILIB := both 18LOCAL_MULTILIB := both
20 19
21include $(BUILD_SHARED_LIBRARY) 20include $(BUILD_SHARED_LIBRARY)
diff --git a/libnativebridge/tests/Android.nativebridge-dummy.mk b/libnativebridge/tests/Android.nativebridge-dummy.mk
index 2efc17659..551765a39 100644
--- a/libnativebridge/tests/Android.nativebridge-dummy.mk
+++ b/libnativebridge/tests/Android.nativebridge-dummy.mk
@@ -13,7 +13,7 @@ LOCAL_SRC_FILES:= $(NATIVE_BRIDGE_COMMON_SRC_FILES)
13LOCAL_CLANG := true 13LOCAL_CLANG := true
14LOCAL_CFLAGS += -Werror -Wall 14LOCAL_CFLAGS += -Werror -Wall
15LOCAL_CPPFLAGS := -std=gnu++11 -fvisibility=protected 15LOCAL_CPPFLAGS := -std=gnu++11 -fvisibility=protected
16LOCAL_LDFLAGS := -ldl 16LOCAL_SHARED_LIBRARIES := libdl
17LOCAL_MULTILIB := both 17LOCAL_MULTILIB := both
18 18
19include $(BUILD_SHARED_LIBRARY) 19include $(BUILD_SHARED_LIBRARY)
@@ -49,7 +49,7 @@ LOCAL_SRC_FILES:= $(NATIVE_BRIDGE2_COMMON_SRC_FILES)
49LOCAL_CLANG := true 49LOCAL_CLANG := true
50LOCAL_CFLAGS += -Werror -Wall 50LOCAL_CFLAGS += -Werror -Wall
51LOCAL_CPPFLAGS := -std=gnu++11 -fvisibility=protected 51LOCAL_CPPFLAGS := -std=gnu++11 -fvisibility=protected
52LOCAL_LDFLAGS := -ldl 52LOCAL_SHARED_LIBRARIES := libdl
53LOCAL_MULTILIB := both 53LOCAL_MULTILIB := both
54 54
55include $(BUILD_SHARED_LIBRARY) 55include $(BUILD_SHARED_LIBRARY)