summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add volatile to temporary variable.Daichi Hirono2017-06-231-1/+3
| | | | | | | | | | | | | | | | FuseBuffer::HandleNotImpl save the value of |request.header.unique| to the temporary variable, clear the buffer which is a union of |request| and |response|, then write back the unique value to response.header.unique. Before the CL, the temporary variable was wrongly removed by the compiler optimization, and response.header.unique was always 0. The CL adds volatile modifier as workaround to prevent the compiler optimization from removing the temporary value. Bug: 62429763 Test: libappfuse_tests Change-Id: Ia853f805633f646f316f585a35c7b018000b6eb3 (cherry picked from commit a6dee5e279de56751238f750d12f8a6237992043)
* Add more logs for writing failures.Daichi Hirono2017-06-111-1/+4
| | | | | | Bug: 62429763 Test: libappfuse_test Change-Id: Ie0eabd09ae9ad3f8ba8c4f38f871dad16b5c58ff
* Merge "Change the CHECK failure into function failure." into oc-devTreeHugger Robot2017-05-161-1/+6
|\
| * Change the CHECK failure into function failure.Daichi Hirono2017-05-161-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously we have CHECK in WriteInternal function to observe short writing. However it turns out short write can happen according to the bug report. To prevent app from crashing due to CHECK failure, the CL removes the CHECK and let WriteInternal return a failure value. Bug: 37561460 Test: libappfuse_tests, manually re-wrote the return value of write() and checked logcat. Change-Id: I6a1e233c3ddb8eb68f59e7c606ad0459b5ca2c6e
* | Use SO_SNDBUFFORCE instead of SO_SNDBUFDaichi Hirono2017-04-281-2/+2
|/ | | | | | | | | | When /proc/sys/net/core/wmem_max is smaller than kMaxMessageSize, we need to override the limitation. Bug: 37561460 Test: libappfuse_tests Change-Id: Ibaac8db61290d661459fdc46f0ae8416f7db1d9e
* Retry write operation when getting ENOBUFS.Daichi Hirono2017-03-301-21/+30
| | | | | | | | | | | | Previously libappfuse set SO_SNDBUF to the maximum message size. However it does not prevent ENOBUF and it made AppFusePerfTest#testReadWriteFile flaky. The CL let FuseBuffer retry write operation when getting ENOBUFS. Bug: 34903085 Test: libappfuse Change-Id: I1602474d852e1599f6e69103bcf6f18277a5644b
* Add FuseMessage::WriteWithBody functionDaichi Hirono2017-03-221-21/+43
| | | | | | | | | The funciton is going to be used to write FUSE header with external body. Bug: 35229514 Test: libappfuse_tests Change-Id: I303022b555deca960b8e08f26140a5ef10133efe
* Add ReadOrAgain and WriteOrAgain methods to FuseMessage.Daichi Hirono2017-03-131-51/+106
| | | | | | | | | | | | | These methods return kAgain if operation cannot be done without blocking the current thread. The CL also introduecs new helper function SetupMessageSockets so that FuseMessages are always transfered via sockets that save message boundaries. Bug: 34903085 Test: libappfuse_test Change-Id: I34544372cc1b0c7bc9622e581ae16c018a123fa9
* Support SOCK_STREAM for bridge between system and appDaichi Hirono2016-12-111-28/+37
| | | | | | | | | | | | | Previously AppFuse use SOCK_SEQPACKET for sockets communicating system and app. However SOCK_SEQPACKET requires the buffer of message size in the kernel and sometimes failed to write with ENOBUF. The CL updates libappfuse so that it can use SOCK_STREAM instead of SOCK_SEQPACKET. Bug: 33279206 Test: libappfuse_test Change-Id: I622ada9ac1d71d0c57b6cfff0904c7829cea7995
* Fix checks for reading and writing FuseMessage.Daichi Hirono2016-12-111-12/+25
| | | | | | | | | | | Previously FuseMessage were checking result of read/write operation after checking header.len value is valid. This was wrong because header.len does not contain correct value when read function does not read any bytes and returns zero. Bug: 33278098 Test: libappfuse_test Change-Id: Icf998ca6c3eeee20cbc4aa2f65195a87e59ffc27
* Merge "Use FUSE_COMPAT_22_INIT_OUT_SIZE always if available."Treehugger Robot2016-11-151-10/+5
|\
| * Use FUSE_COMPAT_22_INIT_OUT_SIZE always if available.Daichi Hirono2016-11-151-10/+5
| | | | | | | | | | | | | | | | | | | | | | We return the minor version number 15 to FUSE_INIT since we don't handle BATCH_FORGET. Thus the kernel does not accept the latest size of fuse_init_out. Instead we need to use FUSE_COMPAT_22_INIT_OUT_SIZE. Bug: 32779923 Test: libappfuse_test Change-Id: I5c979d0e45344ca8adfe3ad3f4a9561442abcb3a
* | Add static assert to check if FuseBuffer is standard layout union.Daichi Hirono2016-11-141-11/+19
| | | | | | | | | | | | Bug: 32260320 Test: libappfuse_test Change-Id: I6430c11fdeb2405996410c97044b4260c25209b8
* | Add FuseAppLoop to libappfuse.Daichi Hirono2016-11-141-1/+11
|/ | | | | | | | | The class is used at the app side (StorageManager) to parse FUSE commands. Bug: 32260320 Test: libappfuse_test Change-Id: I1ae2904d3290a041f1efbf8fc10ba032eda5449c
* Add FuseBridgeLoop to libappfuse.Daichi Hirono2016-10-271-0/+136
The CL adds FuseBridgeLoop class to libappfuse, which is used in the system service to proxy fuse commands to applications. Bug: 29970149 Test: libappfuse_test Change-Id: I0708f608b3868721ab16ba4028fd2c17a6735af7