summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYifan Hong2017-04-17 13:20:41 -0500
committerYifan Hong2017-04-17 14:43:45 -0500
commit383f94505b0089176bc7053991c95d29438b5143 (patch)
tree3c2044b695578eb2971ff336986e63c04316e632 /parse_xml.cpp
parent19e0a2a660d69377a32e52084858e5162a34f154 (diff)
downloadplatform-system-libvintf-383f94505b0089176bc7053991c95d29438b5143.tar.gz
platform-system-libvintf-383f94505b0089176bc7053991c95d29438b5143.tar.xz
platform-system-libvintf-383f94505b0089176bc7053991c95d29438b5143.zip
Remove a TODO comment
<sepolicy> can be missing because it can be determined by build time flag instead of hard-coded in the XML file. Test: pass Bug: 36456394 Change-Id: Ifcbe7bd6aad680a0e350cd58d6d5e2fbea2a58bd Merged-In: Ifcbe7bd6aad680a0e350cd58d6d5e2fbea2a58bd
Diffstat (limited to 'parse_xml.cpp')
-rw-r--r--parse_xml.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/parse_xml.cpp b/parse_xml.cpp
index 81e9b42..82e96d3 100644
--- a/parse_xml.cpp
+++ b/parse_xml.cpp
@@ -618,7 +618,8 @@ struct HalManifestConverter : public XmlNodeConverter<HalManifest> {
618 } 618 }
619 if (object->mType == SchemaType::DEVICE) { 619 if (object->mType == SchemaType::DEVICE) {
620 // tags for device hal manifest only. 620 // tags for device hal manifest only.
621 // TODO(b/36456394): should not allow <sepolicy> to be missing. 621 // <sepolicy> can be missing because it can be determined at build time, not hard-coded
622 // in the XML file.
622 if (!parseOptionalChild(root, halManifestSepolicyConverter, {}, 623 if (!parseOptionalChild(root, halManifestSepolicyConverter, {},
623 &object->device.mSepolicyVersion)) { 624 &object->device.mSepolicyVersion)) {
624 return false; 625 return false;