From c81841f975705f37bfffec7e1d84a9b461539bb3 Mon Sep 17 00:00:00 2001 From: Yifan Hong Date: Mon, 16 Oct 2017 16:21:05 -0700 Subject: Allow native HALs to have tag. assemble_vintf should not drop the empty tag for native HALs, otherwise older versions of libvintf cannot parse the file. Test: m system_manifest.xml -j and manually look at the file Test: sideload package from O DR Bug: 67653129 Change-Id: I403031f1546e7a26b0ad40b992d191ee3c7b80c6 --- parse_xml.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/parse_xml.cpp b/parse_xml.cpp index 3e495fd..0094f81 100644 --- a/parse_xml.cpp +++ b/parse_xml.cpp @@ -588,9 +588,7 @@ struct ManifestHalConverter : public XmlNodeConverter { void mutateNode(const ManifestHal &hal, NodeType *root, DocType *d) const override { appendAttr(root, "format", hal.format); appendTextElement(root, "name", hal.name, d); - if (!hal.transportArch.empty()) { - appendChild(root, transportArchConverter(hal.transportArch, d)); - } + appendChild(root, transportArchConverter(hal.transportArch, d)); appendChildren(root, versionConverter, hal.versions, d); appendChildren(root, halInterfaceConverter, iterateValues(hal.interfaces), d); } -- cgit v1.2.3-54-g00ecf