From 3aeba6c3b4f09c29b75ec8c18b46507ecd69293c Mon Sep 17 00:00:00 2001
From: Sohani Rao
Date: Mon, 21 Aug 2017 16:56:46 -0700
Subject: Wificond: Remove mannual memory management in OffloadScanManager

Bug: 64853991
Test: Unit tests and on-device testing for finding APs in Offloaded PNO
      scans

Change-Id: I88fcbaed00627a7d282b6214f93419a761764da6
---
 scanning/offload/offload_scan_manager.cpp | 8 +++-----
 scanning/offload/offload_scan_manager.h   | 2 +-
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/scanning/offload/offload_scan_manager.cpp b/scanning/offload/offload_scan_manager.cpp
index 2592aee..9bcbb0f 100644
--- a/scanning/offload/offload_scan_manager.cpp
+++ b/scanning/offload/offload_scan_manager.cpp
@@ -76,7 +76,6 @@ OffloadScanManager::OffloadScanManager(
       wifi_offload_callback_(nullptr),
       death_recipient_(nullptr),
       offload_status_(OffloadScanManager::kError),
-      cached_scan_results_(new std::vector<NativeScanResult>()),
       service_available_(false),
       offload_service_utils_(utils),
       offload_callback_handlers_(new OffloadCallbackHandlersImpl(this)),
@@ -239,7 +238,7 @@ OffloadScanManager::StatusCode OffloadScanManager::getOffloadStatus() const {
 
 bool OffloadScanManager::getScanResults(
     std::vector<NativeScanResult>* out_scan_results) {
-  for (auto scan_result : *cached_scan_results_) {
+  for (const auto& scan_result : cached_scan_results_) {
     out_scan_results->push_back(scan_result);
   }
   return true;
@@ -261,14 +260,13 @@ OffloadScanManager::~OffloadScanManager() {
   if (wifi_offload_hal_ != nullptr) {
     wifi_offload_hal_->unlinkToDeath(death_recipient_);
   }
-  delete cached_scan_results_;
 }
 
 void OffloadScanManager::ReportScanResults(
     const vector<ScanResult>& scanResult) {
-  cached_scan_results_->clear();
+  cached_scan_results_.clear();
   if (!OffloadScanUtils::convertToNativeScanResults(scanResult,
-                                                    cached_scan_results_)) {
+                                                    &cached_scan_results_)) {
     LOG(WARNING) << "Unable to convert scan results to native format";
     return;
   }
diff --git a/scanning/offload/offload_scan_manager.h b/scanning/offload/offload_scan_manager.h
index 6be3ec0..2c4fa96 100644
--- a/scanning/offload/offload_scan_manager.h
+++ b/scanning/offload/offload_scan_manager.h
@@ -147,7 +147,7 @@ class OffloadScanManager {
   android::sp<OffloadCallback> wifi_offload_callback_;
   android::sp<OffloadDeathRecipient> death_recipient_;
   StatusCode offload_status_;
-  std::vector<::com::android::server::wifi::wificond::NativeScanResult>*
+  std::vector<::com::android::server::wifi::wificond::NativeScanResult>
       cached_scan_results_;
   bool service_available_;
 
-- 
cgit v1.2.3-54-g00ecf