diff options
authorBin Meng2018-10-24 08:36:38 -0500
committerSimon Glass2018-11-14 11:16:28 -0600
commite3245e4254e1e5caae24b33e203810db7307edfb (patch)
treec729b8f28621344b4e32ad6cd7a6a93452a9a33e /drivers
parentef329a6a736ba1bbfb940edc34ceaa14d3f45b53 (diff)
video: simplefb: Remove DM_FLAG_PRE_RELOC flag
When a driver declares DM_FLAG_PRE_RELOC flag, it wishes to be bound before relocation. However due to a bug in the DM core, the flag only takes effect when devices are statically declared via U_BOOT_DEVICE(). This bug has been fixed recently by commit "dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in lists_bind_fdt()", but with the fix, it has a side effect that all existing drivers that declared DM_FLAG_PRE_RELOC flag will be bound before relocation now. This may expose potential boot failure on some boards due to insufficient memory during the pre-relocation stage. To mitigate this potential impact, the following changes are implemented: - Remove DM_FLAG_PRE_RELOC flag in the driver, if the driver only supports configuration from device tree (OF_CONTROL) - Keep DM_FLAG_PRE_RELOC flag in the driver only if the device is statically declared via U_BOOT_DEVICE() - Surround DM_FLAG_PRE_RELOC flag with OF_CONTROL check, for drivers that support both statically declared devices and configuration from device tree Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'drivers')
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c
index 3b8da808bd..1679d20002 100644
--- a/drivers/video/simplefb.c
+++ b/drivers/video/simplefb.c
@@ -68,5 +68,4 @@ U_BOOT_DRIVER(simple_video) = {
68 .id = UCLASS_VIDEO, 68 .id = UCLASS_VIDEO,
69 .of_match = simple_video_ids, 69 .of_match = simple_video_ids,
70 .probe = simple_video_probe, 70 .probe = simple_video_probe,
71 .flags = DM_FLAG_PRE_RELOC,
72}; 71};