aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBin Meng2018-10-24 08:36:37 -0500
committerSimon Glass2018-11-14 11:16:28 -0600
commitef329a6a736ba1bbfb940edc34ceaa14d3f45b53 (patch)
tree514c9766277a6361529909028edab158df9befa6 /drivers
parent4687919684e0e4390b9fc20d1809ecaa9dc3cb81 (diff)
downloadu-boot-ef329a6a736ba1bbfb940edc34ceaa14d3f45b53.tar.gz
u-boot-ef329a6a736ba1bbfb940edc34ceaa14d3f45b53.tar.xz
u-boot-ef329a6a736ba1bbfb940edc34ceaa14d3f45b53.zip
sysreset: Remove DM_FLAG_PRE_RELOC flag in various drivers
When a driver declares DM_FLAG_PRE_RELOC flag, it wishes to be bound before relocation. However due to a bug in the DM core, the flag only takes effect when devices are statically declared via U_BOOT_DEVICE(). This bug has been fixed recently by commit "dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in lists_bind_fdt()", but with the fix, it has a side effect that all existing drivers that declared DM_FLAG_PRE_RELOC flag will be bound before relocation now. This may expose potential boot failure on some boards due to insufficient memory during the pre-relocation stage. To mitigate this potential impact, the following changes are implemented: - Remove DM_FLAG_PRE_RELOC flag in the driver, if the driver only supports configuration from device tree (OF_CONTROL) - Keep DM_FLAG_PRE_RELOC flag in the driver only if the device is statically declared via U_BOOT_DEVICE() - Surround DM_FLAG_PRE_RELOC flag with OF_CONTROL check, for drivers that support both statically declared devices and configuration from device tree Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/sysreset/sysreset_x86.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/sysreset/sysreset_x86.c b/drivers/sysreset/sysreset_x86.c
index 5943a63854..20b958cfd4 100644
--- a/drivers/sysreset/sysreset_x86.c
+++ b/drivers/sysreset/sysreset_x86.c
@@ -45,5 +45,4 @@ U_BOOT_DRIVER(x86_sysreset) = {
45 .id = UCLASS_SYSRESET, 45 .id = UCLASS_SYSRESET,
46 .of_match = x86_sysreset_ids, 46 .of_match = x86_sysreset_ids,
47 .ops = &x86_sysreset_ops, 47 .ops = &x86_sysreset_ops,
48 .flags = DM_FLAG_PRE_RELOC,
49}; 48};