mpeg4dec: Workaround: Artifacts when frame-drop logic is activatedgst-0.10

mpeg4videoparse element does not correctly mark key frames vs non
key frames for frame drop logic in gst-ducati to work. As a
workaround, frame drops are disabled for mpeg4.

Signed-off-by: Harinarayan Bhatta <harinarayan@ti.com>

1 files changed, 15 insertions, 0 deletions

diff --git a/src/gstducatimpeg4dec.c b/src/gstducatimpeg4dec.c
index 212a4b8..8d38378 100644
--- a/src/gstducatimpeg4dec.c
+++ b/src/gstducatimpeg4dec.c
@@ -63,6 +63,19 @@ static GstStaticPadTemplate sink_factory = GST_STATIC_PAD_TEMPLATE ("sink",
 
 /* GstDucatiVidDec vmethod implementations */
 
+static gboolean
+gst_ducati_mpeg4dec_can_drop_frame (GstDucatiVidDec * self, GstBuffer * buf,
+    gint64 diff)
+{
+  /* The mpeg4 video parser element (mpeg4videoparse) does not do a correct job
+     in identifying key-frames for some interlaced streams.
+     This produces undesirable artifacts when frames are dropped due to QOS.
+     This workaround asks the base class to not drop (avoid decoding) any mpeg4 
+     frames based on buffer flags.
+     TODO: Implement a parser to check if a frame is skippable or not
+   */
+  return FALSE;
+}
 static void
 gst_ducati_mpeg4dec_update_buffer_size (GstDucatiVidDec * self)
 {
@@ -352,6 +365,8 @@ gst_ducati_mpeg4dec_class_init (GstDucatiMpeg4DecClass * klass)
   bclass->allocate_params =
       GST_DEBUG_FUNCPTR (gst_ducati_mpeg4dec_allocate_params);
   bclass->push_input = GST_DEBUG_FUNCPTR (gst_ducati_mpeg4dec_push_input);
+  bclass->can_drop_frame =
+      GST_DEBUG_FUNCPTR (gst_ducati_mpeg4dec_can_drop_frame);
 }
 
 static void