author | David S. Miller <davem@davemloft.net> | |
Wed, 30 Jan 2013 03:58:04 +0000 (22:58 -0500) | ||
committer | David S. Miller <davem@davemloft.net> | |
Sun, 3 Feb 2013 03:58:25 +0000 (22:58 -0500) | ||
commit | 559bcac35facfed49ab4f408e162971612dcfdf3 | |
tree | a575a9c9014943a1cab0fc3dcb8a3d0f87202175 | tree | snapshot (tar.xz tar.gz zip) |
parent | 9165bf273e862c993f36aff0c149259faa72540d | commit | diff |
via-rhine: Fix bugs in NAPI support.
1) rhine_tx() should use dev_kfree_skb() not dev_kfree_skb_irq()
2) rhine_slow_event_task's NAPI triggering logic is racey, it
should just hit the interrupt mask register. This is the
same as commit 7dbb491878a2c51d372a8890fa45a8ff80358af1
("r8169: avoid NAPI scheduling delay.") made to fix the same
problem in the r8169 driver. From Francois Romieu.
Reported-by: Jamie Gloudon <jamie.gloudon@gmail.com>
Tested-by: Jamie Gloudon <jamie.gloudon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1) rhine_tx() should use dev_kfree_skb() not dev_kfree_skb_irq()
2) rhine_slow_event_task's NAPI triggering logic is racey, it
should just hit the interrupt mask register. This is the
same as commit 7dbb491878a2c51d372a8890fa45a8ff80358af1
("r8169: avoid NAPI scheduling delay.") made to fix the same
problem in the r8169 driver. From Francois Romieu.
Reported-by: Jamie Gloudon <jamie.gloudon@gmail.com>
Tested-by: Jamie Gloudon <jamie.gloudon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/via/via-rhine.c | diff | blob | history |