| author | Oleg Nesterov <oleg@redhat.com> | |
| Sun, 28 Oct 2012 15:55:36 +0000 (16:55 +0100) | ||
| committer | Oleg Nesterov <oleg@redhat.com> | |
| Sat, 3 Nov 2012 16:15:12 +0000 (17:15 +0100) | ||
| commit | 65b2c8f0e53347583168423de0f32227d8baf01b | |
| tree | 87b1e9fb5dcbc3e2a5a59192c27b959dc6cc0323 | tree | snapshot (tar.xz tar.gz zip) |
| parent | f57d56dd29003435d1bfc0e675896c368180f8ec | commit | diff |
uprobes/powerpc: Do not use arch_uprobe_*_step() helpers
No functional changes.
powerpc is the only user of arch_uprobe_enable/disable_step() helpers,
but they should die. They can not be used correctly, every arch needs
its own implementation (like x86 does). And they do not really help
even as initial-and-almost-working code, arch_uprobe_*_xol() hooks can
easily use user_enable/disable_single_step() directly.
Change arch_uprobe_*_step() to do nothing, and convert powerpc to use
ptrace helpers. This is equally wrong, powerpc needs the arch-specific
fixes.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
No functional changes.
powerpc is the only user of arch_uprobe_enable/disable_step() helpers,
but they should die. They can not be used correctly, every arch needs
its own implementation (like x86 does). And they do not really help
even as initial-and-almost-working code, arch_uprobe_*_xol() hooks can
easily use user_enable/disable_single_step() directly.
Change arch_uprobe_*_step() to do nothing, and convert powerpc to use
ptrace helpers. This is equally wrong, powerpc needs the arch-specific
fixes.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
| arch/powerpc/kernel/uprobes.c | diff | blob | history | |
| kernel/events/uprobes.c | diff | blob | history |