| author | Chris Bagwell <chris@cnpbagwell.com> | |
| Thu, 24 Jan 2013 03:37:34 +0000 (19:37 -0800) | ||
| committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | |
| Thu, 24 Jan 2013 03:38:52 +0000 (19:38 -0800) | ||
| commit | 9937c026820baabd1e908a9c1e6bdc846293000a | |
| tree | 461b2c70b16edf74c7d5444951133c534a007c93 | tree | snapshot (tar.xz tar.gz zip) |
| parent | b666263b71cb1f3b96fb79e69de7f119062b0da2 | commit | diff |
Input: wacom - fix wacom_set_report retry logic
Logic sets a value and then reads it back to make sure it worked
and retries write on failures. Since read and write share a buffer,
it needs to be set back up before writing though.
Issue is not seen a lot because 1) it doesn't need to retry for
a lot of tablets and 2) a lot of failures that need a retry are
from an -ETIMEDOUT and hopefully buffer is not touched in this case.
At least one user has shown logs with buffer being modified during
-ETIMEDOUT case with linux 3.7 kernel.
Signed-off-by: Chris Bagwell <chris@cnpbagwell.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Logic sets a value and then reads it back to make sure it worked
and retries write on failures. Since read and write share a buffer,
it needs to be set back up before writing though.
Issue is not seen a lot because 1) it doesn't need to retry for
a lot of tablets and 2) a lot of failures that need a retry are
from an -ETIMEDOUT and hopefully buffer is not touched in this case.
At least one user has shown logs with buffer being modified during
-ETIMEDOUT case with linux 3.7 kernel.
Signed-off-by: Chris Bagwell <chris@cnpbagwell.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
| drivers/input/tablet/wacom_sys.c | diff | blob | history |