summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: ddffeb8)
raw | patch | inline | side by side (parent: ddffeb8)
author | Florian Fainelli <florian@openwrt.org> | |
Mon, 10 Dec 2012 21:21:19 +0000 (22:21 +0100) | ||
committer | Ryan Mallon <rmallon@gmail.com> | |
Wed, 12 Dec 2012 00:22:56 +0000 (11:22 +1100) |
This patch changes the busy-waiting loop around in the decompressor
putc() function on the UART FIFO register. Without a proper wait, the
output of the decompressor was corrupted like this:
Uncompressing Linx. done, booting th enl
To highlight the issue more evidently, looping 100 times instead of 1000
makes the issue appear much faster. This patch takes the approach of
using an active while loop until the FIFO is empty (not FULL).
This issue happened to me on Sim.One running at 200Mhz.
Signed-off-by: Florian Fainelli <florian@openwrt.org>
Signed-off-by: Ryan Mallon <rmallon@gmail.com>
putc() function on the UART FIFO register. Without a proper wait, the
output of the decompressor was corrupted like this:
Uncompressing Linx. done, booting th enl
To highlight the issue more evidently, looping 100 times instead of 1000
makes the issue appear much faster. This patch takes the approach of
using an active while loop until the FIFO is empty (not FULL).
This issue happened to me on Sim.One running at 200Mhz.
Signed-off-by: Florian Fainelli <florian@openwrt.org>
Signed-off-by: Ryan Mallon <rmallon@gmail.com>
arch/arm/mach-ep93xx/include/mach/uncompress.h | patch | blob | history |
diff --git a/arch/arm/mach-ep93xx/include/mach/uncompress.h b/arch/arm/mach-ep93xx/include/mach/uncompress.h
index 16026c2b1c8c0f36843baf6378e0114a22b0fa03..d64274fc576058c466b8bb9dc30de9af0498334d 100644 (file)
static inline void putc(int c)
{
- int i;
-
- for (i = 0; i < 1000; i++) {
- /* Transmit fifo not full? */
- if (!(__raw_readb(PHYS_UART_FLAG) & UART_FLAG_TXFF))
- break;
- }
+ /* Transmit fifo not full? */
+ while (__raw_readb(PHYS_UART_FLAG) & UART_FLAG_TXFF)
+ ;
__raw_writeb(c, PHYS_UART_DATA);
}