]> Gitweb @ Texas Instruments - Open Source Git Repositories - git.TI.com/gitweb - android-sdk/kernel-video.git/commitdiff
OMAPDSS: OMAPLFB: skip init in case of invalid framebuffer
authorSergiy Kibrik <sergiy.kibrik@globallogic.com>
Fri, 5 Oct 2012 10:26:24 +0000 (13:26 +0300)
committerPraneeth Bajjuri <praneeth@ti.com>
Fri, 12 Jul 2013 22:45:11 +0000 (17:45 -0500)
Don't go on with omaplfb devinfo initialization if corresponding framebuffer
has not been properly allocated -- has invalid parameters of width/heigth.

This is going to be needed later, when there will be possibility of
multiple framebuffers and swapchains to co-exist.

Change-Id: I85d3554750305d645f78b4c5a076b901fef3d2b4
Signed-off-by: Sergiy Kibrik <sergiy.kibrik@globallogic.com>
drivers/video/omap2/omaplfb/omaplfb_displayclass.c

index b874233a8cce407ad67c46e0ef0afa3a9c736e8d..86bc726ae8e11b08b114c3c21dbf7d03797d32e6 100644 (file)
@@ -1430,6 +1430,16 @@ static OMAPLFB_ERROR OMAPLFBInitFBDev(OMAPLFB_DEVINFO *psDevInfo)
                goto ErrorModPut;
        }
 
+       /* skip framebuffer in case of zero width or height */
+       if (psDevInfo->psLINFBInfo->var.xres == 0 ||
+               psDevInfo->psLINFBInfo->var.yres == 0) {
+               printk(KERN_WARNING DRIVER_PREFIX
+               ": %s: Device %u: invalid framebuffer size\n",
+               __func__, uiFBDevID);
+               eError = OMAPLFB_ERROR_INVALID_PARAMS;
+               goto ErrorModPut;
+       }
+
 #if defined(CONFIG_DSSCOMP)
        if (psFBPlatConfig->tiler2d_buffers)
        {