]> Gitweb @ Texas Instruments - Open Source Git Repositories - git.TI.com/gitweb - android-sdk/kernel-video.git/commitdiff
OMAPDSS: DSSCOMP: do not unpin blocks when splitting/merging slots
authorSergiy Kibrik <sergiy.kibrik@globallogic.com>
Wed, 3 Apr 2013 20:14:01 +0000 (15:14 -0500)
committerPraneeth Bajjuri <praneeth@ti.com>
Fri, 12 Jul 2013 22:41:44 +0000 (17:41 -0500)
Calling tiler_unpin() happens to have occational side effects
like delays, which might cause FIFO underflows in DISPC.

Change-Id: I3c911bd6bd6fb62d4c7423ba6edae60fafab0fb3
Signed-off-by: Arthur Philpott <arthur.philpott@ti.com>
drivers/video/omap2/dsscomp/gralloc.c

index 0e6b646a8b28976418ac763aa5f577da30f7d8e1..f48fc8f80ab48ed4d5ebf4dc33218e76514e4c30 100755 (executable)
@@ -725,10 +725,8 @@ static struct tiler1d_slot *merge_slots(struct tiler1d_slot *slot)
         * might be overtaken before we claim it again.
         * Will be fixed later with tiler slot splitting API
        */
-       tiler_unpin(slot->block_handle);
        tiler_release(slot->block_handle);
 
-       tiler_unpin(slot2free->block_handle);
        tiler_release(slot2free->block_handle);
 
        slot->size = new_size >> PAGE_SHIFT;
@@ -756,7 +754,6 @@ static struct tiler1d_slot *split_slots(struct tiler1d_slot *slot)
         * might be overtaken before we claim it again.
         * Will be fixed later with tiler slot splitting API
        */
-       tiler_unpin(slot->block_handle);
        tiler_release(slot->block_handle);
        for (i = 0; i < MAX_NUM_TILER1D_SLOTS; i++)
                if (slots[i].id == -1)