author | Misael Lopez Cruz <misael.lopez@ti.com> | |
Thu, 3 Sep 2015 16:22:29 +0000 (11:22 -0500) | ||
committer | Misael Lopez Cruz <misael.lopez@ti.com> | |
Thu, 3 Sep 2015 17:28:06 +0000 (12:28 -0500) | ||
commit | c91254d782e3e9c74e4f6ad8b7b01006a1bc58fa | |
tree | 1f0465728ccf5b35be8a36086001a2485fc1c5e5 | tree | snapshot (tar.xz tar.gz zip) |
parent | b7badbfb841cf61b10d5ac0a9606ca4e5b1673fe | commit | diff |
audio: primary: Do not set explicit BT PCM thresholds
When the requested period_size and period_count are not
granted by ALSA (i.e. due to hardware rules/constraints),
the pcm_open() call automatically updates those parameters
to the refined values returned by the kernel.
tinyalsa can also update the start_threshold and stop_threshold
accordingly when they are not explicitly set. The thresholds
set by tinyalsa are correct, except for the stop_threshold
of input streams, which is set to 10x the buffer size.
This value is too large and could hide problems that would
otherwise manifest as overflows (ALSA xruns).
The AudioHAL could also do the params negotiation/update when
the kernel refines those params, but it adds unneeded
complexity that could be avoided by fixing the problem in
tinyalsa.
Change-Id: If690e8c05c2360bfc5eb983427a8adc4d060c645
Signed-off-by: Misael Lopez Cruz <misael.lopez@ti.com>
When the requested period_size and period_count are not
granted by ALSA (i.e. due to hardware rules/constraints),
the pcm_open() call automatically updates those parameters
to the refined values returned by the kernel.
tinyalsa can also update the start_threshold and stop_threshold
accordingly when they are not explicitly set. The thresholds
set by tinyalsa are correct, except for the stop_threshold
of input streams, which is set to 10x the buffer size.
This value is too large and could hide problems that would
otherwise manifest as overflows (ALSA xruns).
The AudioHAL could also do the params negotiation/update when
the kernel refines those params, but it adds unneeded
complexity that could be avoided by fixing the problem in
tinyalsa.
Change-Id: If690e8c05c2360bfc5eb983427a8adc4d060c645
Signed-off-by: Misael Lopez Cruz <misael.lopez@ti.com>
audio/primary/audio_hw.c | diff | blob | history |