| author | Jeff Layton <jlayton@redhat.com> | |
| Wed, 26 Nov 2008 19:32:33 +0000 (19:32 +0000) | ||
| committer | Steve French <sfrench@us.ibm.com> | |
| Wed, 26 Nov 2008 19:32:33 +0000 (19:32 +0000) | ||
| commit | a98ee8c1c707fe3210b00ef9f806ba8e2bf35504 | |
| tree | ed8557a1755d4e924643cbaf75bb04511f69b3a6 | tree | snapshot (tar.xz tar.gz zip) |
| parent | ed313489badef16d700f5a3be50e8fd8f8294bc8 | commit | diff |
[CIFS] fix regression in cifs_write_begin/cifs_write_end
The conversion to write_begin/write_end interfaces had a bug where we
were passing a bad parameter to cifs_readpage_worker. Rather than
passing the page offset of the start of the write, we needed to pass the
offset of the beginning of the page. This was reliably showing up as
data corruption in the fsx-linux test from LTP.
It also became evident that this code was occasionally doing unnecessary
read calls. Optimize those away by using the PG_checked flag to indicate
that the unwritten part of the page has been initialized.
CC: Nick Piggin <npiggin@suse.de>
Acked-by: Dave Kleikamp <shaggy@us.ibm.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
The conversion to write_begin/write_end interfaces had a bug where we
were passing a bad parameter to cifs_readpage_worker. Rather than
passing the page offset of the start of the write, we needed to pass the
offset of the beginning of the page. This was reliably showing up as
data corruption in the fsx-linux test from LTP.
It also became evident that this code was occasionally doing unnecessary
read calls. Optimize those away by using the PG_checked flag to indicate
that the unwritten part of the page has been initialized.
CC: Nick Piggin <npiggin@suse.de>
Acked-by: Dave Kleikamp <shaggy@us.ibm.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
| fs/cifs/file.c | diff | blob | history |