summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 11cd91d)
raw | patch | inline | side by side (parent: 11cd91d)
author | Christopher Ferris <cferris@google.com> | |
Thu, 9 May 2019 20:27:02 +0000 (13:27 -0700) | ||
committer | Christopher Ferris <cferris@google.com> | |
Thu, 9 May 2019 20:35:37 +0000 (13:35 -0700) |
Running any executable built with asan and libc_scudo results in crashes.
Bug: 131810078
Test: Built the media processes with the sanitizer enabled verifying
Test: that the libc_scudo.so shared library is not listed in the
Test: mediaextractor and the mediaswcodec binaries.
Test: Build the media processes without the sanitizer enabled verifying
Test: that the libc_scudo.so shared library is listed in the
Test: mediaextractor and the mediaswcodec binaries.
Change-Id: Ie55a0414088787ec11d85fffcb04592ed4f23c57
Bug: 131810078
Test: Built the media processes with the sanitizer enabled verifying
Test: that the libc_scudo.so shared library is not listed in the
Test: mediaextractor and the mediaswcodec binaries.
Test: Build the media processes without the sanitizer enabled verifying
Test: that the libc_scudo.so shared library is listed in the
Test: mediaextractor and the mediaswcodec binaries.
Change-Id: Ie55a0414088787ec11d85fffcb04592ed4f23c57
cc/sanitize.go | patch | blob | history |
diff --git a/cc/sanitize.go b/cc/sanitize.go
index 2d80c2213d2e0837cd81279c8753a2023cf7e21e..14c1418938051dcfa355fe0dd1b08c2d7d1841c8 100644 (file)
--- a/cc/sanitize.go
+++ b/cc/sanitize.go
if ctx.Device() {
if Bool(sanitize.Properties.Sanitize.Address) {
deps.StaticLibs = append(deps.StaticLibs, asanLibs...)
+ // Compiling asan and having libc_scudo in the same
+ // executable will cause the executable to crash.
+ // Remove libc_scudo since it is only used to override
+ // allocation functions which asan already overrides.
+ _, deps.SharedLibs = removeFromList("libc_scudo", deps.SharedLibs)
}
}