VTS: fix VtsHalKeymasterV3_0Target issue
authorIris Chang <iris.chang@mediatek.com>
Thu, 14 Sep 2017 07:23:18 +0000 (15:23 +0800)
committerIris Chang <iris.chang@mediatek.com>
Fri, 6 Oct 2017 00:45:42 +0000 (00:45 +0000)
commit54ca32a130a0450b444848046199d62876b55301
treed60ba6cdd1ecb099518c0fb4723bf9c3011cb90e
parent9960148420f352c1c0a8cd50e105dce6e6b09acf
VTS: fix VtsHalKeymasterV3_0Target issue

Failed cases:
AttestationTest.RsaAttestation
AttestationTest.EcAttestation

Analysis:
The verify_attestation_record() in Keymaster_hidl_hal_test.cpp calls
parse_attestation_record() to set the value of att_challenge. It fails
to compare att_challenge with challenge by memcmp.
Because setToExternal() method uses buffer pointer to local variable
(record), not use memcpy to copy into itself buffer in
parse_attestation_record(). When it leaves the parse_attestation_record(),
we will get the att_challenge which is null buffer to compare with challenge
incorrectly.

Fix: use memcpy to copy the buffer.

Bug: 65039571
Test: build passed. VtsHalKeymasterV3_0Target -> PASSED: 106, FAILED: 0.

Change-Id: I700a9242cc9a5f4cb196b62860823601e4088531
keymaster/3.0/vts/functional/attestation_record.cpp