]> Gitweb @ Texas Instruments - Open Source Git Repositories - git.TI.com/gitweb - android/platform-hardware-interfaces.git/commitdiff
audio: Add a missing break to EffectsFactory::getAllDescriptors
authorMikhail Naganov <mnaganov@google.com>
Wed, 10 Oct 2018 21:40:54 +0000 (14:40 -0700)
committerMikhail Naganov <mnaganov@google.com>
Thu, 11 Oct 2018 19:21:27 +0000 (12:21 -0700)
Would the legacy HAL return -ENOENT while retrieving an effect,
the enumeration has to be aborted, and the effects queried so far
need to be returned. A missing 'break' was causing returning
no effects at all.

Bug: 117567478
Test: make
Change-Id: I7cc05004f88b39272d06d2ed33a0693f8e1e3d04
Merged-In: I7cc05004f88b39272d06d2ed33a0693f8e1e3d04

audio/effect/all-versions/default/include/effect/all-versions/default/EffectsFactory.impl.h

index 1882a2c4905146ece973394070570942fa39a02e..b0351c968fb77631b1a9bf5838f645828e3e34a2 100644 (file)
@@ -101,6 +101,7 @@ restart:
                 case -ENOENT: {
                     // No more effects available.
                     result.resize(i);
+                    break;
                 }
                 default: {
                     result.resize(0);