summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 391eb58)
raw | patch | inline | side by side (parent: 391eb58)
author | Kevin Rocard <krocard@google.com> | |
Thu, 6 Sep 2018 17:28:51 +0000 (10:28 -0700) | ||
committer | Kevin Rocard <krocard@google.com> | |
Thu, 6 Sep 2018 18:22:23 +0000 (18:22 +0000) |
A test was not checking for the Result::isOk() resulting
in an assert being triggered in HIDL code if the HAL crashed.
Test: (sleep 0.3; adb shell pkill audio) &
adb shell /data/nativetest64/VtsHalAudioV4_0TargetTest/VtsHalAudioV4_0TargetTest
# Test finishes in failure but does not crash
Signed-off-by: Kevin Rocard <krocard@google.com>
Change-Id: I97a6213fe82a5e9a6eb333dc1dc2476102610b58
in an assert being triggered in HIDL code if the HAL crashed.
Test: (sleep 0.3; adb shell pkill audio) &
adb shell /data/nativetest64/VtsHalAudioV4_0TargetTest/VtsHalAudioV4_0TargetTest
# Test finishes in failure but does not crash
Signed-off-by: Kevin Rocard <krocard@google.com>
Change-Id: I97a6213fe82a5e9a6eb333dc1dc2476102610b58
audio/core/4.0/vts/functional/AudioPrimaryHidlHalTest.cpp | patch | blob | history |
diff --git a/audio/core/4.0/vts/functional/AudioPrimaryHidlHalTest.cpp b/audio/core/4.0/vts/functional/AudioPrimaryHidlHalTest.cpp
index 0f8996fc5d8a61421123fa53cb882e8ab69386bd..59ced271e0ab17caaf3e8bcb404e19659a1cd416 100644 (file)
"Make sure setBtHfpVolume is either not supported or "
"only succeed if volume is in [0,1]");
auto ret = device->setBtHfpVolume(0.0);
+ ASSERT_TRUE(ret.isOk());
if (ret == Result::NOT_SUPPORTED) {
doc::partialTest("setBtHfpVolume is not supported");
return;