Merge changes Ia3b96e83,I80d924cc into pie-vts-dev
* changes:
Add REQUEST_NOT_SUPPORTED for pin and pin2 Icc VTS
Add SIM_PUK2 for Icc VTS tests
* changes:
Add REQUEST_NOT_SUPPORTED for pin and pin2 Icc VTS
Add SIM_PUK2 for Icc VTS tests
Improve VTS GNSS 1.1 reliability.
Allow VTS test for low power mode to handle
certain vendor issues that supply one extra location
at the start of low power mode.
Allow more time for GNSS first fix, and warmup as
needed given limited VTS access to AGPS.
Bug: 110626730
Bug: 110987651
Test: (TODO) Passes on device.
Merged-In: Ieeefd7fcd45890b03dffbbee965e1d9b17805c4c
Change-Id: Ieeefd7fcd45890b03dffbbee965e1d9b17805c4c
(cherry picked from commit 5ea5dda2c33f9d2f1db77d6b4493f0eb356c2937)
Allow VTS test for low power mode to handle
certain vendor issues that supply one extra location
at the start of low power mode.
Allow more time for GNSS first fix, and warmup as
needed given limited VTS access to AGPS.
Bug: 110626730
Bug: 110987651
Test: (TODO) Passes on device.
Merged-In: Ieeefd7fcd45890b03dffbbee965e1d9b17805c4c
Change-Id: Ieeefd7fcd45890b03dffbbee965e1d9b17805c4c
(cherry picked from commit 5ea5dda2c33f9d2f1db77d6b4493f0eb356c2937)
Delete time/position in InjectDelete instead of Delete_all
- DELETE_ALL will delete XTRA.
Bug: 110626730
Test: run VTS test on device.
Merged-In: I4f01430f24f92238193d3de6b6fbb31e81e9f006
Change-Id: I4f01430f24f92238193d3de6b6fbb31e81e9f006
(cherry picked from commit 84cff99b2fcae8757704b0384552aebe290165ed)
- DELETE_ALL will delete XTRA.
Bug: 110626730
Test: run VTS test on device.
Merged-In: I4f01430f24f92238193d3de6b6fbb31e81e9f006
Change-Id: I4f01430f24f92238193d3de6b6fbb31e81e9f006
(cherry picked from commit 84cff99b2fcae8757704b0384552aebe290165ed)
Inject last location in InjectBestLocation VTS test
Bug: 110626730
Test: run VTS on device.
Merged-In: I6f57dd7f9164dacf011f25412e55fcd22821aca0
Change-Id: I6f57dd7f9164dacf011f25412e55fcd22821aca0
(cherry picked from commit bb372e5984a612cb6972e837662d64a90785fbd8)
Bug: 110626730
Test: run VTS on device.
Merged-In: I6f57dd7f9164dacf011f25412e55fcd22821aca0
Change-Id: I6f57dd7f9164dacf011f25412e55fcd22821aca0
(cherry picked from commit bb372e5984a612cb6972e837662d64a90785fbd8)
Merge "Tolerate 1 sv status in GNSS blacklist VTS test" into pie-vts-dev
Merge "VTS: Do not require XML for Audio effect V2" into pie-vts-dev
Merge "Camera: Don't hold 'mLock' when closing the camera session" into pie-vts-dev
Merge "Audio VTS was testing wrong uninitialized variable due to typo" into pie-vts-dev
Tolerate 1 sv status in GNSS blacklist VTS test
Bug: 110969497
Test: run VTS test on device.
Merged-In: I26345bb62513da8530cb48672e5f59a915817cb4
Change-Id: I26345bb62513da8530cb48672e5f59a915817cb4
(cherry picked from commit 91cc8f4832882e8fa9baa04d717184636a57314d)
Bug: 110969497
Test: run VTS test on device.
Merged-In: I26345bb62513da8530cb48672e5f59a915817cb4
Change-Id: I26345bb62513da8530cb48672e5f59a915817cb4
(cherry picked from commit 91cc8f4832882e8fa9baa04d717184636a57314d)
VTS: Do not require XML for Audio effect V2
In O, the Audio effect V2 HAL allows not to have an audio effect XML
configuration but to use a .conf format.
In P, before this patch, the Audio effect V2 HAL _requires_ to have an
audio effect XML configuration and forbids the use of a .conf format.
This is discouraged by Treble as it means that an unchanged HAL V2
implementation that was compatible with O VTS will not be with P VTS.
As a result, revert to the Oreo behavior for Audio Effect V2 VTS.
Note that the audio effect V4 VTS is not changed by this patch and
still requires an audio effect XML configuration.
Aka device _updating_ to P will not have to upgrade to XML but new
devices lunching on P are still required to have an audio effect
XML configuration.
This commit only changes VTS code.
Test: cd hardware/interfaces/audio/effect/
mmm 2.0/vts/functional 4.0/vts/functional && adb sync data
adb push *.0/xml/audio_effects_conf_V*.xsd /data/local/tmp/
adb shell
cd /data/nativetest64
OPS=--gtest_filter=CheckConfig.audioEffectsConfigurationValidation
VtsHalAudioEffectV2_0TargetTest/VtsHalAudioEffectV2_0TargetTest $OPS
VtsHalAudioEffectV4_0TargetTest/VtsHalAudioEffectV4_0TargetTest $OPS
rm /{odm,vendor,system}/etc/audio_effects.xml || true
VtsHalAudioEffectV2_0TargetTest/VtsHalAudioEffectV2_0TargetTest $OPS
! VtsHalAudioEffectV4_0TargetTest/VtsHalAudioEffectV4_0TargetTest $OPS
Bug: 111421676
Change-Id: Ifb15d65ae4aa65759c8ebaa91cbc8c02234030dc
Merged-In: Ifb15d65ae4aa65759c8ebaa91cbc8c02234030dc
Signed-off-by: Kevin Rocard <krocard@google.com>
(cherry picked from commit b41b575475f3c93fe30216b9cdb2db441b92854b)
In O, the Audio effect V2 HAL allows not to have an audio effect XML
configuration but to use a .conf format.
In P, before this patch, the Audio effect V2 HAL _requires_ to have an
audio effect XML configuration and forbids the use of a .conf format.
This is discouraged by Treble as it means that an unchanged HAL V2
implementation that was compatible with O VTS will not be with P VTS.
As a result, revert to the Oreo behavior for Audio Effect V2 VTS.
Note that the audio effect V4 VTS is not changed by this patch and
still requires an audio effect XML configuration.
Aka device _updating_ to P will not have to upgrade to XML but new
devices lunching on P are still required to have an audio effect
XML configuration.
This commit only changes VTS code.
Test: cd hardware/interfaces/audio/effect/
mmm 2.0/vts/functional 4.0/vts/functional && adb sync data
adb push *.0/xml/audio_effects_conf_V*.xsd /data/local/tmp/
adb shell
cd /data/nativetest64
OPS=--gtest_filter=CheckConfig.audioEffectsConfigurationValidation
VtsHalAudioEffectV2_0TargetTest/VtsHalAudioEffectV2_0TargetTest $OPS
VtsHalAudioEffectV4_0TargetTest/VtsHalAudioEffectV4_0TargetTest $OPS
rm /{odm,vendor,system}/etc/audio_effects.xml || true
VtsHalAudioEffectV2_0TargetTest/VtsHalAudioEffectV2_0TargetTest $OPS
! VtsHalAudioEffectV4_0TargetTest/VtsHalAudioEffectV4_0TargetTest $OPS
Bug: 111421676
Change-Id: Ifb15d65ae4aa65759c8ebaa91cbc8c02234030dc
Merged-In: Ifb15d65ae4aa65759c8ebaa91cbc8c02234030dc
Signed-off-by: Kevin Rocard <krocard@google.com>
(cherry picked from commit b41b575475f3c93fe30216b9cdb2db441b92854b)
Camera: Don't hold 'mLock' when closing the camera session
After flushing the camera requests don't try to close the
camera session while still holding 'mLock'. Different Hals
could still try and return additional results which then will
get blocked on 'mLock'. Closing the session could potentially
introduce a deadlock if the Hal implementation waits for any
of the result calls to return.
Bug: 111836165
Test: vts-tradefed run commandAndExit vts --skip-all-system-status-check
--skip-preconditions --module VtsHalCameraProviderV2_4Target -l INFO
Change-Id: I0f309f435cc76db3f9b6ba500da65a232b014717
Merged-In: I0f309f435cc76db3f9b6ba500da65a232b014717
(cherry picked from commit 8e920568371136b011c79e6c1d15bcb4c047d0a3)
After flushing the camera requests don't try to close the
camera session while still holding 'mLock'. Different Hals
could still try and return additional results which then will
get blocked on 'mLock'. Closing the session could potentially
introduce a deadlock if the Hal implementation waits for any
of the result calls to return.
Bug: 111836165
Test: vts-tradefed run commandAndExit vts --skip-all-system-status-check
--skip-preconditions --module VtsHalCameraProviderV2_4Target -l INFO
Change-Id: I0f309f435cc76db3f9b6ba500da65a232b014717
Merged-In: I0f309f435cc76db3f9b6ba500da65a232b014717
(cherry picked from commit 8e920568371136b011c79e6c1d15bcb4c047d0a3)
Audio VTS was testing wrong uninitialized variable due to typo
The test was testing a uninitialized variable instead of testing
the result of the tested method.
Bug: 110963314
Test: vts-tradefed run commandAndExit vts --module VtsHalAudioV2_0Target
Merged-In: I9a212eef690ae627fd7f7dbfaf4a0b4047c491b3
Change-Id: I9a212eef690ae627fd7f7dbfaf4a0b4047c491b3
Signed-off-by: Kevin Rocard <krocard@google.com>
(cherry picked from commit 72641e7ad014a011562c3fd16444b919d32aeb63)
The test was testing a uninitialized variable instead of testing
the result of the tested method.
Bug: 110963314
Test: vts-tradefed run commandAndExit vts --module VtsHalAudioV2_0Target
Merged-In: I9a212eef690ae627fd7f7dbfaf4a0b4047c491b3
Change-Id: I9a212eef690ae627fd7f7dbfaf4a0b4047c491b3
Signed-off-by: Kevin Rocard <krocard@google.com>
(cherry picked from commit 72641e7ad014a011562c3fd16444b919d32aeb63)
Add VTS test to verify scheduling capability
2018+ devices must support GNSS capability scheduling
Test results: go/vts-review-bucket/pi-dev/4267645
Bug: 109642198
Test: atest VtsHalGnssV1_0TargetTest
Merged-In: I7394674abca8f8c40ab30403be6b41bbbb279956
Change-Id: I7394674abca8f8c40ab30403be6b41bbbb279956
(cherry picked from commit e3ff41fc12fb7a80ee533e4459035ef4545c174d)
2018+ devices must support GNSS capability scheduling
Test results: go/vts-review-bucket/pi-dev/4267645
Bug: 109642198
Test: atest VtsHalGnssV1_0TargetTest
Merged-In: I7394674abca8f8c40ab30403be6b41bbbb279956
Change-Id: I7394674abca8f8c40ab30403be6b41bbbb279956
(cherry picked from commit e3ff41fc12fb7a80ee533e4459035ef4545c174d)
Add setIndicationFilter response notification in 1.2 VTS
Test: compile
Bug: 109822806
Merged-In: I95102a148a26cab80235cc68ad83143a9bb6eb39
Change-Id: I95102a148a26cab80235cc68ad83143a9bb6eb39
(cherry picked from commit 0ff41b94b30a0db0ce4a6a5b29600ced5853a762)
Test: compile
Bug: 109822806
Merged-In: I95102a148a26cab80235cc68ad83143a9bb6eb39
Change-Id: I95102a148a26cab80235cc68ad83143a9bb6eb39
(cherry picked from commit 0ff41b94b30a0db0ce4a6a5b29600ced5853a762)
Add REQUEST_NOT_SUPPORTED for pin and pin2 Icc VTS
Bug: 111222834
Test: sanity
Change-Id: Ia3b96e83d6173c2c80bdbf7763a876883b167af9
Merged-In: Ia3b96e83d6173c2c80bdbf7763a876883b167af9
(cherry picked from commit c0a06f34c88cf9dc017be6178113b35c3c7fc67e)
Bug: 111222834
Test: sanity
Change-Id: Ia3b96e83d6173c2c80bdbf7763a876883b167af9
Merged-In: Ia3b96e83d6173c2c80bdbf7763a876883b167af9
(cherry picked from commit c0a06f34c88cf9dc017be6178113b35c3c7fc67e)
Add SIM_PUK2 for Icc VTS tests
Add SIM_PUK2 for supplyIccPin2ForApp and changeIccPin2ForApp if sim
card is in the puk2 state.
Bug: 111211929
Test: sanity
Change-Id: I80d924cc4a61565887cbd2a65ee5927a42ad656e
Merged-In: I80d924cc4a61565887cbd2a65ee5927a42ad656e
(cherry picked from commit 4ed0a216adc3bc9460d11d302ba53db9707ded44)
Add SIM_PUK2 for supplyIccPin2ForApp and changeIccPin2ForApp if sim
card is in the puk2 state.
Bug: 111211929
Test: sanity
Change-Id: I80d924cc4a61565887cbd2a65ee5927a42ad656e
Merged-In: I80d924cc4a61565887cbd2a65ee5927a42ad656e
(cherry picked from commit 4ed0a216adc3bc9460d11d302ba53db9707ded44)
Add docs for setSignalStrengthReportingCriteria
Because setSignalStrengthReportingCriteria only
supports a single measurement quantity, provide
further clarification on the applicability of the
API and how it may be used in various situations.
Bug: 110121199
Test: compilation - docstring-only change
Merged-In: If4236070fbc03368e5a78b0cf502cdc4a529a6ed
Change-Id: If4236070fbc03368e5a78b0cf502cdc4a529a6ed
(cherry picked from commit 529d2fffa02451406f013b354fd7c07164f619b1)
Because setSignalStrengthReportingCriteria only
supports a single measurement quantity, provide
further clarification on the applicability of the
API and how it may be used in various situations.
Bug: 110121199
Test: compilation - docstring-only change
Merged-In: If4236070fbc03368e5a78b0cf502cdc4a529a6ed
Change-Id: If4236070fbc03368e5a78b0cf502cdc4a529a6ed
(cherry picked from commit 529d2fffa02451406f013b354fd7c07164f619b1)
Merge "Add back keymaster@4.0 hash." into pie-vts-dev
[automerger skipped] resolve merge conflicts of cd02298b46cfb17954555e0f1d324f63085aa204 to oreo-mr1-vts-dev
am: 79cea44239 -s ours
Change-Id: I17d4a58573074b7746a9d35be04414f9227ec47e
am: 79cea44239 -s ours
Change-Id: I17d4a58573074b7746a9d35be04414f9227ec47e
Effect VTS: Allow an effect proxy as pre/post processing
am: 0f0328fc4e
Change-Id: I570e2a73de01900cf39b5d08cfed370ee17a0e38
am: 0f0328fc4e
Change-Id: I570e2a73de01900cf39b5d08cfed370ee17a0e38
Add back keymaster@4.0 hash.
This was changed after this branch was released. The originally
released hash needs to be restored since that is what partners
are building with.
Bug: 112688384
Bug: 78104779
Test: m android.hardware.keymaster@4.0 (tests hashes)
Change-Id: I0f59a493d7f17a13402d992495d1a259f6257077
(cherry picked from commit ec720564dbdef01d14fcf46c46ea18294440358b)
This was changed after this branch was released. The originally
released hash needs to be restored since that is what partners
are building with.
Bug: 112688384
Bug: 78104779
Test: m android.hardware.keymaster@4.0 (tests hashes)
Change-Id: I0f59a493d7f17a13402d992495d1a259f6257077
(cherry picked from commit ec720564dbdef01d14fcf46c46ea18294440358b)
Merge "Fix base class of WifiHidlEnvironment_1_2" into pie-vts-dev
Merge "Fix IUsb version number in vts test" into pie-vts-dev
Patch for setSimCardPower_1_1
Do not expect its affect on cardStatus if it is not successfully returned.
Check the response error before updating sim card status.
Test: sanity
Bug: 111661946
Change-Id: I48551f5469289b9fcfc47dd9fd2e455779640329
Merged-In: I48551f5469289b9fcfc47dd9fd2e455779640329
(cherry picked from commit 7e787e192cd4700d8f4e7cc5f55501bc37590245)
Do not expect its affect on cardStatus if it is not successfully returned.
Check the response error before updating sim card status.
Test: sanity
Bug: 111661946
Change-Id: I48551f5469289b9fcfc47dd9fd2e455779640329
Merged-In: I48551f5469289b9fcfc47dd9fd2e455779640329
(cherry picked from commit 7e787e192cd4700d8f4e7cc5f55501bc37590245)
Merge "Fix setSimCardPower_1_1" into pie-vts-dev
Fix setSimCardPower_1_1
If the function isn't executed successfully, do not expect its effect
of cardStatus.
Bug: 111661946
Test: run vts
Change-Id: I952728311b595149b449280e73142f2f82af544d
Merged-In: I952728311b595149b449280e73142f2f82af544d
(cherry picked from commit 934243085ae70d7ce4ec7f6ee331099b4566b051)
(cherry picked from commit c02dd2562ff373c32740b1fda5947a5861d73990)
If the function isn't executed successfully, do not expect its effect
of cardStatus.
Bug: 111661946
Test: run vts
Change-Id: I952728311b595149b449280e73142f2f82af544d
Merged-In: I952728311b595149b449280e73142f2f82af544d
(cherry picked from commit 934243085ae70d7ce4ec7f6ee331099b4566b051)
(cherry picked from commit c02dd2562ff373c32740b1fda5947a5861d73990)
Merge "Fix ICameraDeviceCallback version in VTS test" into pie-vts-dev
Check INVALID_SIM_STATE for sim permanent lock status
PUK1 and PUK2 can get permanent blocked when it inputs wrong
passwords more than 10 times.
Bug: 111211929
Test: sanity
Change-Id: I736873b1b181b88f279df7dc1c09e18e0fc76af3
PUK1 and PUK2 can get permanent blocked when it inputs wrong
passwords more than 10 times.
Bug: 111211929
Test: sanity
Change-Id: I736873b1b181b88f279df7dc1c09e18e0fc76af3
resolve merge conflicts of 898d05a713a693670cd450ff3f50156fed2f4567 to pie-vts-dev
Test: I solemnly swear I tested this conflict resolution.
Bug: 72075328
Change-Id: I5d7c124bc3905f899e63f080ac94def4e06fe9c2
Merged-In: I8c993cd2fa95c961dc7f976b5bd85a2826b42889
Test: I solemnly swear I tested this conflict resolution.
Bug: 72075328
Change-Id: I5d7c124bc3905f899e63f080ac94def4e06fe9c2
Merged-In: I8c993cd2fa95c961dc7f976b5bd85a2826b42889
Fix base class of WifiHidlEnvironment_1_2
WifiHidlEnvironment_1_2 inherits WifiHidlEnvironment so that it stops
Wifi before every test.
Test: run vts -m VtsHalWifiV1_2Target
Bug: 112058501
Change-Id: I73c50351fa486f2ae7749e43a060ff05672c0f65
Merged-In: I73c50351fa486f2ae7749e43a060ff05672c0f65
(cherry picked from commit 4721523a96007b3b928ca847cfb3945e3e68c346)
WifiHidlEnvironment_1_2 inherits WifiHidlEnvironment so that it stops
Wifi before every test.
Test: run vts -m VtsHalWifiV1_2Target
Bug: 112058501
Change-Id: I73c50351fa486f2ae7749e43a060ff05672c0f65
Merged-In: I73c50351fa486f2ae7749e43a060ff05672c0f65
(cherry picked from commit 4721523a96007b3b928ca847cfb3945e3e68c346)
Fix ICameraDeviceCallback version in VTS test
Test: ./VtsHalCameraProviderV2_4TargetTest --gtest_filter=CameraHidlTest.constructDefaultRequestSettings
Bug: 111625570
Change-Id: I8ad02afb0e9c2131c240999c4a8c78a1f770e847
Merged-In: I8ad02afb0e9c2131c240999c4a8c78a1f770e847
(cherry picked from commit cccd5bf1dd32c49ac6e10d870829b1ae40d19580)
Test: ./VtsHalCameraProviderV2_4TargetTest --gtest_filter=CameraHidlTest.constructDefaultRequestSettings
Bug: 111625570
Change-Id: I8ad02afb0e9c2131c240999c4a8c78a1f770e847
Merged-In: I8ad02afb0e9c2131c240999c4a8c78a1f770e847
(cherry picked from commit cccd5bf1dd32c49ac6e10d870829b1ae40d19580)
Fix IUsb version number in vts test
Bug: 110913709
Test: vts-tradefed run vts -m VtsHalUsbV1_1Target
Change-Id: I9ae6add2fe8ff7138e07797c3a191b6dfe611948
Merged-In: I9ae6add2fe8ff7138e07797c3a191b6dfe611948
(cherry picked from commit b4193b855c745da6772607d32f5351300ac826e1)
Bug: 110913709
Test: vts-tradefed run vts -m VtsHalUsbV1_1Target
Change-Id: I9ae6add2fe8ff7138e07797c3a191b6dfe611948
Merged-In: I9ae6add2fe8ff7138e07797c3a191b6dfe611948
(cherry picked from commit b4193b855c745da6772607d32f5351300ac826e1)
Update power HAL to version 1.3.
Adds new EXPENSIVE_RENDERING power hint.
This adds a new library which does not affect any pre-existing
targets unless they create and add a new binary which uses this.
BUG: 110112323
Test: adb shell /data/nativetest/VtsHalPowerV1_3TargetTest/VtsHalPowerV1_3TargetTest
Change-Id: I5fb33abbbe4c4958882a106dfa400ad74013e40d
Adds new EXPENSIVE_RENDERING power hint.
This adds a new library which does not affect any pre-existing
targets unless they create and add a new binary which uses this.
BUG: 110112323
Test: adb shell /data/nativetest/VtsHalPowerV1_3TargetTest/VtsHalPowerV1_3TargetTest
Change-Id: I5fb33abbbe4c4958882a106dfa400ad74013e40d
resolve merge conflicts of b92f1d2e1be35b331b18589a8cde81d51ddd31d6 to oreo-mr1-vts-dev
am: c0243f2ff8
Change-Id: I25bf6387a074f630cc3e10c3b265d16390e39eca
am: c0243f2ff8
Change-Id: I25bf6387a074f630cc3e10c3b265d16390e39eca
[automerger skipped] Audio VTS: run tear-down hooks in LIFO instead of FIFO am: 01ead7c96b -s ours
am: 70d13c2ad3 -s ours
Change-Id: I1040539ea50b8c6c02daa1b032d9b5be01bd920e
am: 70d13c2ad3 -s ours
Change-Id: I1040539ea50b8c6c02daa1b032d9b5be01bd920e
Audio VTS: run tear-down hooks in LIFO instead of FIFO
am: cfab8dac2b
Change-Id: Ibd24dda91b5d334a62553dfe980d6559743688b8
am: cfab8dac2b
Change-Id: Ibd24dda91b5d334a62553dfe980d6559743688b8
[automerger skipped] Fix setBandMode. am: ab2b8bf919 -s ours
am: d1e489c94c -s ours
Change-Id: Ia6efc79ef18e4614f784a3a393ce19d33dd564f1
am: d1e489c94c -s ours
Change-Id: Ia6efc79ef18e4614f784a3a393ce19d33dd564f1
Call notify for voiceReg and dataReg VTS tests
Bug: 80554443
Test: vts
Merged-In: I19f7131f7b65323065f3c283a89668ff761815e3
Change-Id: I19f7131f7b65323065f3c283a89668ff761815e3
(cherry picked from commit 2bb626a2975ef3398adbcb12fe50804cf71efc39)
Bug: 80554443
Test: vts
Merged-In: I19f7131f7b65323065f3c283a89668ff761815e3
Change-Id: I19f7131f7b65323065f3c283a89668ff761815e3
(cherry picked from commit 2bb626a2975ef3398adbcb12fe50804cf71efc39)
Add REQUEST_NOT_SUPPORTED for changeIccPinForApp and changeIccPin2ForApp
Bug: 110037298
Test: run vts -m VtsHalRadioV1_0Target
Merged-In: Iaba800814c5a6950d086a2f105714d01fdaa14a4
Change-Id: Iaba800814c5a6950d086a2f105714d01fdaa14a4
(cherry picked from commit 7470cbd04dbb90ec4a6481d08db54c6a8c5f2efd)
Bug: 110037298
Test: run vts -m VtsHalRadioV1_0Target
Merged-In: Iaba800814c5a6950d086a2f105714d01fdaa14a4
Change-Id: Iaba800814c5a6950d086a2f105714d01fdaa14a4
(cherry picked from commit 7470cbd04dbb90ec4a6481d08db54c6a8c5f2efd)
Fix free() in keymaster VTS
The buffer is allocated by OPENSSL_malloc() in X509_NAME_oneline(name, nullptr, 0).
Should be reclaimed by OPENSSL_free() instead of free().
The patch is provided by vink.shen@mediatek.corp-partner.google.com
Bug: 109708231
Test: build pass
Merged-In: I66a864e3e28905eebac2e7d3a4517d4d5aaa39df
Change-Id: I66a864e3e28905eebac2e7d3a4517d4d5aaa39df
(cherry picked from commit 79db3ec849c5f1142a0802dccfff6cbef564ff76)
The buffer is allocated by OPENSSL_malloc() in X509_NAME_oneline(name, nullptr, 0).
Should be reclaimed by OPENSSL_free() instead of free().
The patch is provided by vink.shen@mediatek.corp-partner.google.com
Bug: 109708231
Test: build pass
Merged-In: I66a864e3e28905eebac2e7d3a4517d4d5aaa39df
Change-Id: I66a864e3e28905eebac2e7d3a4517d4d5aaa39df
(cherry picked from commit 79db3ec849c5f1142a0802dccfff6cbef564ff76)
Respect limited requirements for Strongbox KM implementations
With this patch the KM VTS test apply the restricted requirements on
supported key sizes, EC curves, and Digests to Strongbox keymaster
implementations.
Also amend tests to use Update().
Test: Yes it is
Bug: 74519020
Merged-In: Ibec9c3398671f81dbc0ecf78e554726276160579
Change-Id: Ibec9c3398671f81dbc0ecf78e554726276160579
(cherry picked from commit 3a7e2cade3305d59f861c21206b5862de9d05d5c)
With this patch the KM VTS test apply the restricted requirements on
supported key sizes, EC curves, and Digests to Strongbox keymaster
implementations.
Also amend tests to use Update().
Test: Yes it is
Bug: 74519020
Merged-In: Ibec9c3398671f81dbc0ecf78e554726276160579
Change-Id: Ibec9c3398671f81dbc0ecf78e554726276160579
(cherry picked from commit 3a7e2cade3305d59f861c21206b5862de9d05d5c)
resolve merge conflicts of cd02298b46cfb17954555e0f1d324f63085aa204 to oreo-mr1-vts-dev
Bug: None
Test: none
Change-Id: I1d705ee440f49b1d7713b9225cbfb1815b79d5a0
Bug: None
Test: none
Change-Id: I1d705ee440f49b1d7713b9225cbfb1815b79d5a0
Camera: add proper HwLevel check
Bug: 112011195
Merged-In: Ib0b98f32c401566323eee546ee23c7873c00aef0
Change-Id: If27bb5b12cfd2ffd8abf3079302d5967e37bf241
Bug: 112011195
Merged-In: Ib0b98f32c401566323eee546ee23c7873c00aef0
Change-Id: If27bb5b12cfd2ffd8abf3079302d5967e37bf241
Effect VTS: Allow an effect proxy as pre/post processing
Effect proxy were previously mistakenly forbidden as post
or pre processing effects.
An effect being a proxy or not should not affect where
it can be use in the effect framework.
Bug: 111421676
Test: xmllint --noout --schema hardware/interfaces/audio/effect/2.0/xml/audio_effects_conf_V2_0.xsd $(find -name audio_effects.xml)
Change-Id: Iad1c1467226b86a2935a36dd90cf2e32f7f753b0
Signed-off-by: Kevin Rocard <krocard@google.com>
Effect proxy were previously mistakenly forbidden as post
or pre processing effects.
An effect being a proxy or not should not affect where
it can be use in the effect framework.
Bug: 111421676
Test: xmllint --noout --schema hardware/interfaces/audio/effect/2.0/xml/audio_effects_conf_V2_0.xsd $(find -name audio_effects.xml)
Change-Id: Iad1c1467226b86a2935a36dd90cf2e32f7f753b0
Signed-off-by: Kevin Rocard <krocard@google.com>
resolve merge conflicts of dfa79a6292a42dd8609053febd8df7d5e7d48fbf to oreo-mr1-vts-dev
Test: I solemnly swear I tested this conflict resolution.
Bug: None
Change-Id: I10919718b841fdb33ab0e873d1b4bbd787fafcd2
Test: I solemnly swear I tested this conflict resolution.
Bug: None
Change-Id: I10919718b841fdb33ab0e873d1b4bbd787fafcd2
Merge "Add NONE for LceService" into oreo-vts-dev
Add NONE for LceService
"Allow startLceService to succeed even in the
SIM_ABSENT case. The original RIL documentation
states that SUCCESS is valid for all LCE
operations, and there is no logical reason why
one of these operations must fail in a no-SIM
case (though a vendor may choose not to support
that configuration). Thus, a call to
startLceService should permit NONE when requested
in the no-SIM case for 1.0 VTS.
In addition, a successful call to startLceService
should also permit a successful call to
pullLceData, so also allow RadioError::NONE for
the pull operation. Ideally the tests would only
allow NONE for pull if startLceService also
returns NONE, but that's out of scope for now."
Bug: 110181475
Bug: 72075328
Test: confirmed in the discussion; compilation
"Allow startLceService to succeed even in the
SIM_ABSENT case. The original RIL documentation
states that SUCCESS is valid for all LCE
operations, and there is no logical reason why
one of these operations must fail in a no-SIM
case (though a vendor may choose not to support
that configuration). Thus, a call to
startLceService should permit NONE when requested
in the no-SIM case for 1.0 VTS.
In addition, a successful call to startLceService
should also permit a successful call to
pullLceData, so also allow RadioError::NONE for
the pull operation. Ideally the tests would only
allow NONE for pull if startLceService also
returns NONE, but that's out of scope for now."
Bug: 110181475
Bug: 72075328
Test: confirmed in the discussion; compilation
resolve merge conflicts of b92f1d2e1be35b331b18589a8cde81d51ddd31d6 to oreo-mr1-vts-dev
Test: make vts -j123 && vts-tradefed run commandAndExit vts \
--skip-all-system-status-check \
--skip-preconditions -m VtsHalMediaOmxV1_0Host \
-l INFO
Bug: 70933963
Change-Id: I38f6309b638e604403dba15fa1fe1022b298c5b2
Test: make vts -j123 && vts-tradefed run commandAndExit vts \
--skip-all-system-status-check \
--skip-preconditions -m VtsHalMediaOmxV1_0Host \
-l INFO
Bug: 70933963
Change-Id: I38f6309b638e604403dba15fa1fe1022b298c5b2
Disable tests for secure audio decoders
Test: make vts -j123 && vts-tradefed run commandAndExit vts \
--skip-all-system-status-check \
--skip-preconditions -m VtsHalMediaOmxV1_0Host \
-l INFO
Bug: 70933963
Change-Id: Iaaf3b7d382e7df4374dd7e03e5cc7b2ae6861fad
Test: make vts -j123 && vts-tradefed run commandAndExit vts \
--skip-all-system-status-check \
--skip-preconditions -m VtsHalMediaOmxV1_0Host \
-l INFO
Bug: 70933963
Change-Id: Iaaf3b7d382e7df4374dd7e03e5cc7b2ae6861fad
[automerger skipped] Audio VTS: run tear-down hooks in LIFO instead of FIFO
am: 01ead7c96b -s ours
Change-Id: I827c0bd5011129a704d35cdcd2df9f9bbe7eadfe
am: 01ead7c96b -s ours
Change-Id: I827c0bd5011129a704d35cdcd2df9f9bbe7eadfe
Audio VTS: run tear-down hooks in LIFO instead of FIFO
The audio tests use a static cache of some HAL objects for
performance reasons (speed up by 10x on Pixel).
Those object are destroy during the test environment tear-down.
This tear-down was destroying the objects in a FIFO instead of LIFO
order. Thus the DeficesFactory was destroyed before the Device it
created.
Bug: 79889318
Test: vts-tradefed run commandAndExit vts --module VtsHalAudioV2_0Target
check that the device destructor is called before the
devicesFactory one.
Change-Id: I1b4345158139ba14a8779a9508f7ebdc41129d1d
Merged-In: I1b4345158139ba14a8779a9508f7ebdc41129d1d
Signed-off-by: Kevin Rocard <krocard@google.com>
The audio tests use a static cache of some HAL objects for
performance reasons (speed up by 10x on Pixel).
Those object are destroy during the test environment tear-down.
This tear-down was destroying the objects in a FIFO instead of LIFO
order. Thus the DeficesFactory was destroyed before the Device it
created.
Bug: 79889318
Test: vts-tradefed run commandAndExit vts --module VtsHalAudioV2_0Target
check that the device destructor is called before the
devicesFactory one.
Change-Id: I1b4345158139ba14a8779a9508f7ebdc41129d1d
Merged-In: I1b4345158139ba14a8779a9508f7ebdc41129d1d
Signed-off-by: Kevin Rocard <krocard@google.com>
Audio VTS: run tear-down hooks in LIFO instead of FIFO
The audio tests use a static cache of some HAL objects for
performance reasons (speed up by 10x on Pixel).
Those object are destroy during the test environment tear-down.
This tear-down was destroying the objects in a FIFO instead of LIFO
order. Thus the DeficesFactory was destroyed before the Device it
created.
Bug: 79889318
Test: vts-tradefed run commandAndExit vts --module VtsHalAudioV2_0Target
check that the device destructor is called before the
devicesFactory one.
Change-Id: I1b4345158139ba14a8779a9508f7ebdc41129d1d
Signed-off-by: Kevin Rocard <krocard@google.com>
The audio tests use a static cache of some HAL objects for
performance reasons (speed up by 10x on Pixel).
Those object are destroy during the test environment tear-down.
This tear-down was destroying the objects in a FIFO instead of LIFO
order. Thus the DeficesFactory was destroyed before the Device it
created.
Bug: 79889318
Test: vts-tradefed run commandAndExit vts --module VtsHalAudioV2_0Target
check that the device destructor is called before the
devicesFactory one.
Change-Id: I1b4345158139ba14a8779a9508f7ebdc41129d1d
Signed-off-by: Kevin Rocard <krocard@google.com>
[automerger skipped] Fix setBandMode.
am: ab2b8bf919 -s ours
Change-Id: Ibbdfad48f943c35419a91ccf8b3d4651bfab88f1
am: ab2b8bf919 -s ours
Change-Id: Ibbdfad48f943c35419a91ccf8b3d4651bfab88f1
Merge "Fix comments and internal names about SEEK operation." into pi-dev
Fix comments and internal names about SEEK operation.
Legacy radio HAL named it SCAN and the name slipped through HAL 1.x
into HAL 2.0. I finally noticed it after HAL 2.0 was locked down.
Bug: 109740376
Test: build ow
Change-Id: I5ca4147227a7dd0c32248a279f03fb632d97258e
Legacy radio HAL named it SCAN and the name slipped through HAL 1.x
into HAL 2.0. I finally noticed it after HAL 2.0 was locked down.
Bug: 109740376
Test: build ow
Change-Id: I5ca4147227a7dd0c32248a279f03fb632d97258e
Merge "secure_element: vts: Fix openBasicChannel and transmit test case" into pi-dev
Camera: Add only physical ids during multi-camera configuration
Per API specification "physicalCameraId" must not
contain any logical camera ids. The test case
should only use the physical ids it receives from the
camera static metadata.
Bug:109874630
Test:run vts --skip-all-system-status-check --skip-preconditions
--primary-abi-only --module VtsHalCameraProviderV2_4Target -l INFO
Change-Id: I82c5bf44f4572b3a6abdbb3101a11140907b1c9e
Per API specification "physicalCameraId" must not
contain any logical camera ids. The test case
should only use the physical ids it receives from the
camera static metadata.
Bug:109874630
Test:run vts --skip-all-system-status-check --skip-preconditions
--primary-abi-only --module VtsHalCameraProviderV2_4Target -l INFO
Change-Id: I82c5bf44f4572b3a6abdbb3101a11140907b1c9e
secure_element: vts: Fix openBasicChannel and transmit test case
Status Response for basic channel can be only 2 bytes as well.
Update the test to test for 2 or more bytes.
Basic Channel if opened successfully should be closed.
Transmit test case should specify the channel number in the command.
Test: atest VtsHalSecureElementV1_0TargetTest
Bug: 109833790
Change-Id: I91c943b4297067f6ae6872efb038f1295f92f5c8
(cherry picked from commit d7700d216f0d854405bb9d99972c79f1af5b1b68)
Status Response for basic channel can be only 2 bytes as well.
Update the test to test for 2 or more bytes.
Basic Channel if opened successfully should be closed.
Transmit test case should specify the channel number in the command.
Test: atest VtsHalSecureElementV1_0TargetTest
Bug: 109833790
Change-Id: I91c943b4297067f6ae6872efb038f1295f92f5c8
(cherry picked from commit d7700d216f0d854405bb9d99972c79f1af5b1b68)
Merge "Document unspecified dimensions." into pi-dev
Merge "Camera: Avoid Metadata re-allocation during shrinkCaptureResult" into pi-dev
Camera: Avoid Metadata re-allocation during shrinkCaptureResult
If capture result metadata is to be shrinked, reserve enough space so
that CameraMetadata isn't re-allocated when std::vector expands.
If vector expansion happens, CameraMetadata is re-allocated, causing
camera_metadata_t being re-allocated as well.
Test: Camera CTS
Bug: 109672123
Change-Id: Idaf5bf409bdbbccf617614edc96c0478260b4c30
If capture result metadata is to be shrinked, reserve enough space so
that CameraMetadata isn't re-allocated when std::vector expands.
If vector expansion happens, CameraMetadata is re-allocated, causing
camera_metadata_t being re-allocated as well.
Test: Camera CTS
Bug: 109672123
Change-Id: Idaf5bf409bdbbccf617614edc96c0478260b4c30
Merge "SetColorMode is not available for vendor hwc less than 1.4" into pi-dev
Merge "Add initial values for properties" into pi-dev
Document unspecified dimensions.
Test: mm
Bug: 77234888
Bug: 109687058
Change-Id: Ia8928e494d8c712bc9cfb592d67476fde9753f45
Test: mm
Bug: 77234888
Bug: 109687058
Change-Id: Ia8928e494d8c712bc9cfb592d67476fde9753f45
Explicitly unfreeze the Automotive HALs
Per discussion with Treble team, keeping HALs unfrozen is suitable for
platforms whos functionality is evolving and which do not require hard
gaurantees of cross version vendor/system interoperability.
Test: build owl
Bug: 109674659
Change-Id: Idc2a391b4bd7c2edbf9cdd7fc099b9d4a6fcf95a
Per discussion with Treble team, keeping HALs unfrozen is suitable for
platforms whos functionality is evolving and which do not require hard
gaurantees of cross version vendor/system interoperability.
Test: build owl
Bug: 109674659
Change-Id: Idc2a391b4bd7c2edbf9cdd7fc099b9d4a6fcf95a
Add initial values for properties
Cleanup defaultconfig.h to have proper initial values so that all
properties may be tested with EmbeddedKitchenSink.
Bug: 109674339
Test: Embedded Kitchen Sink
Change-Id: I3007c645b90b0e6805b8d1011c3a8d659eb13d2b
Cleanup defaultconfig.h to have proper initial values so that all
properties may be tested with EmbeddedKitchenSink.
Bug: 109674339
Test: Embedded Kitchen Sink
Change-Id: I3007c645b90b0e6805b8d1011c3a8d659eb13d2b
Merge "VtsHalMediaOmx should test functionality only" into pi-dev
VtsHalMediaOmx should test functionality only
The tests insisted on presence of codecs as well as functionality, but
the list it reads is a superset of what may be on the device. Modified so
that if a codec is not present, we ignore it rather than failing the test.
The Vts tests that check OMX Store are being augmented to ensure any
advertised codecs are indeed present.
Bug: 80029024
Bug: 80530946
Test: vts run VtsHalMediaOmxV1_0Host
Change-Id: Icd6d049c5c0d31f47ef3dbda52d6927e38bd894d
The tests insisted on presence of codecs as well as functionality, but
the list it reads is a superset of what may be on the device. Modified so
that if a codec is not present, we ignore it rather than failing the test.
The Vts tests that check OMX Store are being augmented to ensure any
advertised codecs are indeed present.
Bug: 80029024
Bug: 80530946
Test: vts run VtsHalMediaOmxV1_0Host
Change-Id: Icd6d049c5c0d31f47ef3dbda52d6927e38bd894d
SetColorMode is not available for vendor hwc less than 1.4
Bug: 90510785
Test: VTS VtsHalGraphicsComposerV2_1Target SetColorMode(default) pass
Change-Id: Ia295b3ef2f0f433a7e1b5179eb230b8f7c649400
Bug: 90510785
Test: VTS VtsHalGraphicsComposerV2_1Target SetColorMode(default) pass
Change-Id: Ia295b3ef2f0f433a7e1b5179eb230b8f7c649400
Merge "Set lowPowerMode as false in StartAndGetLocations" into pi-dev
Set lowPowerMode as false in StartAndGetLocations
Bug: 80544245
Change-Id: Icf85e9b8ed433dbdb759b54c4ba7b5e7a21b7a26
Fixes: 80544245
Test: VtsHalGnssV1_1TargetTest --gtest_filter=*Blacklist*
Bug: 80544245
Change-Id: Icf85e9b8ed433dbdb759b54c4ba7b5e7a21b7a26
Fixes: 80544245
Test: VtsHalGnssV1_1TargetTest --gtest_filter=*Blacklist*
Merge "Modified tests to account for different directories being used based on different first API levels" into pi-dev
Merge "Minor corrections to the Keymaster4 documentation." into pi-dev
Merge "graphics: COLORIMETRIC is optional for HDR modes" into pi-dev
Minor corrections to the Keymaster4 documentation.
Gramatical and punctuation corrections; addition of missing
userSecureId to AuthorizationList schema and removal of extraneous
rollbackResistant from same; correction of OS_PATCHLEVEL source
property; and addition of missing TAG_UNLOCKED_DEVICE_REQUIRED
documentation.
Bug: 69550260
Test: N/A
Change-Id: I04092b7df3af69201ba1467cddc09f6f44e861a8
Gramatical and punctuation corrections; addition of missing
userSecureId to AuthorizationList schema and removal of extraneous
rollbackResistant from same; correction of OS_PATCHLEVEL source
property; and addition of missing TAG_UNLOCKED_DEVICE_REQUIRED
documentation.
Bug: 69550260
Test: N/A
Change-Id: I04092b7df3af69201ba1467cddc09f6f44e861a8
graphics: COLORIMETRIC is optional for HDR modes
Bug: 80030364
Test: VTS
Change-Id: I2180f18e8742850f728491887475f16b1cad4791
Merged-In: I2180f18e8742850f728491887475f16b1cad4791
Bug: 80030364
Test: VTS
Change-Id: I2180f18e8742850f728491887475f16b1cad4791
Merged-In: I2180f18e8742850f728491887475f16b1cad4791
Merge "Update VTS test to blacklist only non-GPS satellites" into pi-dev
Modified tests to account for different directories being used based on
different first API levels
Fixes: 80028983
Test: Ran tests on P17 and P18
Change-Id: I2752c5b8e15dc5e3ee386b0079a75b482a21543f
different first API levels
Fixes: 80028983
Test: Ran tests on P17 and P18
Change-Id: I2752c5b8e15dc5e3ee386b0079a75b482a21543f
Merge "audio hal: Add 'interface' declarations for IDeviceFactory into .rc" into pi-dev
Merge "confirmationui: explicitly declare only one thread." into pi-dev
Merge "Fix tire pressure sensor property" into pi-dev
audio hal: Add 'interface' declarations for IDeviceFactory into .rc
Declaring the interfaces allows HIDL hwservicemanager to start
the HAL service in case it has crashed before audioserver
has called 'getService'.
Bug: 80227481
Test: use the repro case from the bug
Change-Id: Ibb46beb714b3985ab373d56d92da1105cfda28c6
Declaring the interfaces allows HIDL hwservicemanager to start
the HAL service in case it has crashed before audioserver
has called 'getService'.
Bug: 80227481
Test: use the repro case from the bug
Change-Id: Ibb46beb714b3985ab373d56d92da1105cfda28c6
Merge "Camera: add FMQ size override logic" into pi-dev
confirmationui: explicitly declare only one thread.
Due to an unclear API, wireless_charger accidentally started
two threads.
Bug: 80102279
Test: use lshal to verify that the service only has one thread
Change-Id: Ic6bdb6ef0025173f4388f0550e00a6b4fc2e21df
Due to an unclear API, wireless_charger accidentally started
two threads.
Bug: 80102279
Test: use lshal to verify that the service only has one thread
Change-Id: Ic6bdb6ef0025173f4388f0550e00a6b4fc2e21df
Merge "Fix default keymaster so it doesn't start an extra thread." into pi-dev
Add multichannel support am: c678d51bdc am: 5de1ae23f9 am: e0c3d0c3fd
am: 006436f92f
Change-Id: I6aeba2a72185c08a15dc96468bfe6c4c45410d52
am: 006436f92f
Change-Id: I6aeba2a72185c08a15dc96468bfe6c4c45410d52
Add multichannel support am: c678d51bdc am: 5de1ae23f9
am: e0c3d0c3fd
Change-Id: Ieca398bea38f13621185a192d09733243febe131
am: e0c3d0c3fd
Change-Id: Ieca398bea38f13621185a192d09733243febe131
Fix default keymaster so it doesn't start an extra thread.
Bug: 80102279
Bug: 80251973
Test: N/A; this keymaster exists only for policy compliance. It's never used.
Change-Id: I45f0eefd9abdd02f6774aa52f238040510c5d62c
Bug: 80102279
Bug: 80251973
Test: N/A; this keymaster exists only for policy compliance. It's never used.
Change-Id: I45f0eefd9abdd02f6774aa52f238040510c5d62c
Camera: add FMQ size override logic
Test: modify FMQ size in device.mk
Bug: 80242493
Change-Id: Ie1fb12118ad53c5bbe0cf264bffaafcd3728f8db
Test: modify FMQ size in device.mk
Bug: 80242493
Change-Id: Ie1fb12118ad53c5bbe0cf264bffaafcd3728f8db
Add multichannel support am: c678d51bdc
am: 5de1ae23f9
Change-Id: Ica809012e43a3142b3d7c6098eb6c7a107da0dbf
am: 5de1ae23f9
Change-Id: Ica809012e43a3142b3d7c6098eb6c7a107da0dbf
Add multichannel support am: c678d51bdc am: 9886d749d4
am: b0da0bce66
Change-Id: I2b701daf2c12a7b0454c46d48910671f10ccb2b6
am: b0da0bce66
Change-Id: I2b701daf2c12a7b0454c46d48910671f10ccb2b6
Add multichannel support am: c678d51bdc
am: 9886d749d4
Change-Id: I00e53d56e7e98e54efa2e8f4bdc6928d125d0609
am: 9886d749d4
Change-Id: I00e53d56e7e98e54efa2e8f4bdc6928d125d0609
Merge "Move Keymaster docs into HAL" into pi-dev
Merge "Activate HMAC sharing check." into pi-dev
Fix tire pressure sensor property
Update comment to remove reference to unused min/max values
Bug: 80102628
Test: comments updated
Change-Id: I9555ac2e6c274b52e01ce9555e8403b2b94a5036
Update comment to remove reference to unused min/max values
Bug: 80102628
Test: comments updated
Change-Id: I9555ac2e6c274b52e01ce9555e8403b2b94a5036
Merge "configstore: configstore HAL uprev'ed to 1.1" into pi-dev
Move Keymaster docs into HAL
Bug: 69550260
Test: N/A
Change-Id: Ib135e4e4060f3a89480f6784b30e9008126b3b76
Bug: 69550260
Test: N/A
Change-Id: Ib135e4e4060f3a89480f6784b30e9008126b3b76