android/platform-hardware-interfaces.git
2 years agoMerge "Audio: Do not sanitize android.hardware.audio@2.0-service" android-o-mr1-iot-release-smart-display-r3
Treehugger Robot [Fri, 12 Oct 2018 00:56:46 +0000 (00:56 +0000)]
Merge "Audio: Do not sanitize android.hardware.audio@2.0-service"

2 years agoMerge "audio: Add a missing break to EffectsFactory::getAllDescriptors"
Treehugger Robot [Thu, 11 Oct 2018 22:18:22 +0000 (22:18 +0000)]
Merge "audio: Add a missing break to EffectsFactory::getAllDescriptors"

2 years agoMerge "Add monostate to optional safe unions."
Steven Moreland [Thu, 11 Oct 2018 21:23:27 +0000 (21:23 +0000)]
Merge "Add monostate to optional safe unions."

2 years agoaudio: Add a missing break to EffectsFactory::getAllDescriptors
Mikhail Naganov [Wed, 10 Oct 2018 21:40:54 +0000 (14:40 -0700)]
audio: Add a missing break to EffectsFactory::getAllDescriptors

Would the legacy HAL return -ENOENT while retrieving an effect,
the enumeration has to be aborted, and the effects queried so far
need to be returned. A missing 'break' was causing returning
no effects at all.

Bug: 117567478
Test: make
Change-Id: I7cc05004f88b39272d06d2ed33a0693f8e1e3d04
Merged-In: I7cc05004f88b39272d06d2ed33a0693f8e1e3d04

2 years agoAdd monostate to optional safe unions.
Steven Moreland [Wed, 10 Oct 2018 20:59:36 +0000 (13:59 -0700)]
Add monostate to optional safe unions.

Bug: 116156870
Test: hidl_test, hidl_test_java
Change-Id: Ie17a80dee982775e267a39086016071ac2361fb5

2 years agoMerge "Divide BBOX_TRANSFORM into 2 ops."
Przemyslaw Szczepaniak [Thu, 11 Oct 2018 16:17:46 +0000 (16:17 +0000)]
Merge "Divide BBOX_TRANSFORM into 2 ops."

2 years agoAudio: Do not sanitize android.hardware.audio@2.0-service
Andreas Gampe [Thu, 11 Oct 2018 03:26:39 +0000 (20:26 -0700)]
Audio: Do not sanitize android.hardware.audio@2.0-service

Until the underlying bug is fixed, do not produce a sanitized
binary.

Bug: 117506164
Bug: 117580200
Test: m && SANITIZE_TARGET=address m
Change-Id: I4e6d1206512513c687f7ae065d2974c55c617b61

2 years agoMerge "tests IFoo: WithFmq is more complicated."
Steven Moreland [Wed, 10 Oct 2018 19:03:51 +0000 (19:03 +0000)]
Merge "tests IFoo: WithFmq is more complicated."

2 years agoDivide BBOX_TRANSFORM into 2 ops.
Xusong Wang [Thu, 4 Oct 2018 22:03:13 +0000 (15:03 -0700)]
Divide BBOX_TRANSFORM into 2 ops.

Divide BBOX_TRANSFORM op into 2 ops
- AXIS_ALIGNED_BBOX_TRANSFORM
- ROTATED_BBOX_TRANSFORM

Rotated bounding boxes use different tensor format than axis-aligned
bounding boxes, and it would be less confusing if they were represented
by a separate operator code.

Bug: 113562630

Test: NeuralNetworksTest_static
Test: VtsHalNeuralnetworksV1_xTargetTest with sample driver
Change-Id: Ie08f2e0d0da77f6750766a394969653478d054d5
Merged-In: Ie08f2e0d0da77f6750766a394969653478d054d5
(cherry picked from commit d2bae1c268f8ef8e313441450e226d68ab515d9a)

2 years agoMerge changes from topic "nnapi-cherrypick-from-master-and-pi-dev-to-aosp"
Przemyslaw Szczepaniak [Wed, 10 Oct 2018 13:27:42 +0000 (13:27 +0000)]
Merge changes from topic "nnapi-cherrypick-from-master-and-pi-dev-to-aosp"

* changes:
  Update OWNERS
  Fix indexing bug in NNAPI
  Attach a bug to syncing docs
  Reserve enums for new NNAPI ops.
  Add new op PAD_V2
  Add new ops ARGMAX and ARGMIN

2 years agoMerge "Clarifying GnssMeasurement and Clock commments"
Treehugger Robot [Wed, 10 Oct 2018 05:13:22 +0000 (05:13 +0000)]
Merge "Clarifying GnssMeasurement and Clock commments"

2 years agotests IFoo: WithFmq is more complicated.
Steven Moreland [Tue, 9 Oct 2018 22:10:48 +0000 (15:10 -0700)]
tests IFoo: WithFmq is more complicated.

When an interface is in the struct, scatter gather isn't used.

Bug: 117239572
Test: hidl_test
Change-Id: I749dd7cce85d220c1908ad583b1744c799a105cc

2 years agoMerge "tests: IBaz, nasty nesting struct"
Treehugger Robot [Tue, 9 Oct 2018 20:36:36 +0000 (20:36 +0000)]
Merge "tests: IBaz, nasty nesting struct"

2 years agoMerge "IFoo: send struct with fmq."
Steven Moreland [Tue, 9 Oct 2018 19:51:30 +0000 (19:51 +0000)]
Merge "IFoo: send struct with fmq."

2 years agotests: IBaz, nasty nesting struct
Steven Moreland [Tue, 9 Oct 2018 17:05:47 +0000 (10:05 -0700)]
tests: IBaz, nasty nesting struct

toString is broken in some cases because of recursive definitions. This
exercises that case.

Bug: 117342189
Test: hidl_test
Test: m android.hardware.tests.baz@1.0 android.hardware.tests.baz-V1.0-java
    (this runs hidl-gen on this for both Java and C++ output)
Test: manually inspected output

Change-Id: Ic09ac133345f2d83d6f83d3d0af1f63e7e3250ee

2 years agoMerge "VTS: Check return status of initialize and close"
Treehugger Robot [Tue, 9 Oct 2018 13:29:02 +0000 (13:29 +0000)]
Merge "VTS: Check return status of initialize and close"

2 years agoUpdate OWNERS
Miao Wang [Fri, 5 Oct 2018 00:16:43 +0000 (17:16 -0700)]
Update OWNERS

Test: none
Change-Id: I96db4de3f34837c9f3174fd01e7d06d3355617f3
Merged-In: I96db4de3f34837c9f3174fd01e7d06d3355617f3
(cherry picked from commit 6653e69dc6385805909df504a93776aae6a6f639)

2 years agoFix indexing bug in NNAPI
Slava Shklyaev [Thu, 27 Sep 2018 15:18:54 +0000 (16:18 +0100)]
Fix indexing bug in NNAPI

Bug: 114365802
Test: n/a
Change-Id: I87173528b58f66175c99e7c7e2e66daa307b04da
Merged-In: I87173528b58f66175c99e7c7e2e66daa307b04da
(cherry picked from commit 4a211d836457e22788010ddd58c8c2f6dd3cfbe7)

2 years agoAttach a bug to syncing docs
Slava Shklyaev [Tue, 25 Sep 2018 15:10:38 +0000 (16:10 +0100)]
Attach a bug to syncing docs

Bug: 116445845
Test: none
Change-Id: I841b1dc503d70efddb8175b75d9d3efe8078eeb1
Merged-In: I841b1dc503d70efddb8175b75d9d3efe8078eeb1
(cherry picked from commit 7f9f46159183b02d53ca8d6bbe728e5610c2ea5a)

2 years agoReserve enums for new NNAPI ops.
Przemyslaw Szczepaniak [Mon, 24 Sep 2018 13:12:28 +0000 (14:12 +0100)]
Reserve enums for new NNAPI ops.

Test: NeuralNetworksTest_static
Bug: 114365802

Change-Id: I3b379fe3f0336b92ef602bbb12a4bd4a150c573c
Merged-In: I3b379fe3f0336b92ef602bbb12a4bd4a150c573c
(cherry picked from commit 5a9362eb2d1378636fd8bf604f6536eb2a268d2c)

2 years agoAdd new op PAD_V2
Slava Shklyaev [Thu, 20 Sep 2018 12:43:37 +0000 (13:43 +0100)]
Add new op PAD_V2

Bug: 113561890
Test: NeuralNetworksTest_static
Change-Id: I34351d6ff5fae0a13e3e883ca42210c534418ff3
Merged-In: I34351d6ff5fae0a13e3e883ca42210c534418ff3
(cherry picked from commit ffe467e6d863b2b555171df7b2f46676ad46200e)

2 years agoAdd new ops ARGMAX and ARGMIN
Slava Shklyaev [Wed, 19 Sep 2018 15:55:31 +0000 (16:55 +0100)]
Add new ops ARGMAX and ARGMIN

Bug: 113558658
Test: NeuralNetworksTest_static
Change-Id: I8862d4062181689ce69ab65aa07c1b6af07ba567
Merged-In: I8862d4062181689ce69ab65aa07c1b6af07ba567
(cherry picked from commit cc31bd6622f5e01ab640916fbb26433dd4ff9db2)

2 years agoVTS: Check return status of initialize and close
Jack He [Fri, 5 Oct 2018 01:42:37 +0000 (18:42 -0700)]
VTS: Check return status of initialize and close

Test: atest VtsHalBluetoothV1_0TargetTest
Change-Id: I579c4d5f4c6e24b358c67c3dc8a8a8ceb1f936e2

2 years agoIFoo: send struct with fmq.
Steven Moreland [Fri, 5 Oct 2018 16:42:21 +0000 (09:42 -0700)]
IFoo: send struct with fmq.

Bug: 117239572
Test: hidl_test
Change-Id: I968916a9d62e1c8f7a237bd24e6b4267dd013366

2 years agoMerge "IFoo: remove pointer from u."
Steven Moreland [Mon, 8 Oct 2018 15:54:11 +0000 (15:54 +0000)]
Merge "IFoo: remove pointer from u."

2 years agoMerge "Add a command to get the minimum battery voltage required for flashing"
Treehugger Robot [Sun, 7 Oct 2018 17:53:45 +0000 (17:53 +0000)]
Merge "Add a command to get the minimum battery voltage required for flashing"

2 years agoAdd a command to get the minimum battery voltage required for flashing
Hridya Valsaraju [Mon, 1 Oct 2018 22:47:24 +0000 (15:47 -0700)]
Add a command to get the minimum battery voltage required for flashing

Bug: 79480454
Test: fastboot getvar battery-soc-ok

Change-Id: I6141993972a3084fe3620d81f707999e1264b997
Merged-In: I6141993972a3084fe3620d81f707999e1264b997
(cherry picked from commit 83f5631deb5169d7b6f897679956bc11d13e6e0b)

2 years agoAdded 1.3 DataProfileInfo
Jack Yu [Sat, 15 Sep 2018 00:27:27 +0000 (17:27 -0700)]
Added 1.3 DataProfileInfo

1. Deprecated the fields 'mvnoType', 'mvnoMatchData', 'maxConnsTime',
   and 'maxConns'.
2. Added a new flag 'preferred' indicating if this data profile
   is preferred for default data connection setup.
3. Move modemCognative flag from setupDataCall and setInitialAttachApn
   into the struct DataProfileInfo and rename it to 'persistent'.
4. Removed isRoaming flag in setupDataCall, setInitialAttachApn, and
   setDataProfile.

Test: Telephony sanity tests
Bug: 73659459
Change-Id: Ia28715e85755b47a1ee870b5c90e5505a7fd8c4a

2 years agoIFoo: remove pointer from u.
Steven Moreland [Fri, 5 Oct 2018 18:16:20 +0000 (11:16 -0700)]
IFoo: remove pointer from u.

pointer needs a fixup (to abort) since they can't be used in remote
transactions, so removing it from the union here.

Bug: 117322722
Test: hidl_test
Change-Id: Ie582f6b79a8176ca1585bf4b1f43ae9d5d97fa92

2 years agoClarifying GnssMeasurement and Clock commments
WyattRiley [Wed, 15 Aug 2018 01:19:30 +0000 (18:19 -0700)]
Clarifying GnssMeasurement and Clock commments

Change-Id: Ia51b16a2904ab43f67464fc91321fad99a2bb614
Fixes: 77812939
Test: Comments only, verified builds

2 years agoAudio VTS: Do not constrain implementation frameCount
Kevin Rocard [Wed, 3 Oct 2018 23:15:32 +0000 (16:15 -0700)]
Audio VTS: Do not constrain implementation frameCount
am: 069bc45044

Change-Id: I3ec1df7f581e5b11e0d394139c1421109c16fc19

2 years agoMerge "Reland "Set vendor: true for boot control HAL""
Treehugger Robot [Wed, 3 Oct 2018 21:47:14 +0000 (21:47 +0000)]
Merge "Reland "Set vendor: true for boot control HAL""

2 years agoReland "Set vendor: true for boot control HAL"
Hridya Valsaraju [Wed, 3 Oct 2018 17:51:58 +0000 (17:51 +0000)]
Reland "Set vendor: true for boot control HAL"

This reverts commit f8169cc2bc23db9be612da42d241267cdccbed40.

Bug: 117072247
Change-Id: Ib80966e31ed92d316217844d0399e6f6ba5fdd2c

2 years agoMerge "Emergency Function HAL (continued)" android-o-mr1-iot-release-1.0.5
Shuo Qian [Wed, 3 Oct 2018 01:36:17 +0000 (01:36 +0000)]
Merge "Emergency Function HAL (continued)"

2 years agoMerge "health VTS: split Properties test"
Yifan Hong [Tue, 2 Oct 2018 23:37:43 +0000 (23:37 +0000)]
Merge "health VTS: split Properties test"

2 years agoAudio VTS: Do not constrain implementation frameCount
Kevin Rocard [Thu, 20 Sep 2018 21:28:46 +0000 (14:28 -0700)]
Audio VTS: Do not constrain implementation frameCount

The test was assuming Stream::getFrameCount() would return the
AudioConfig::frameCount used to create the stream, similarly
to the sampleRate or the channelMask.

Nevertheless this is not the case as the AudioConfig::frameCount
field is not to used by Stream::openOutputStream (nor Input) as
the buffer size is chosen by the HAL, not the framework.

Thus the test can not assume the frameCount chosen by the HAL and
must not test for a particular value.

Test: atest VtsHalAudioV4_0TargetTest
Bug: 116169974
Change-Id: Ibbf0825f540957e01e7c512d851cb9628991f4c4
Signed-off-by: Kevin Rocard <krocard@google.com>
2 years agohealth VTS: split Properties test
Yifan Hong [Tue, 2 Oct 2018 21:52:02 +0000 (14:52 -0700)]
health VTS: split Properties test

... into multiple test cases.
Test: run test

Change-Id: I2a03a7ab01d2918b746e06f55c2ee6d733ab4021

2 years agohealth: registerCallback() and getHealthInfo() does not notify all callbacks
Yifan Hong [Tue, 2 Oct 2018 21:11:35 +0000 (14:11 -0700)]
health: registerCallback() and getHealthInfo() does not notify all callbacks

registerCallback() and getHealthInfo() unintentionally broadcast
health info to all callbacks, which has a performance impact.

* registerCallback() still invokes the new callback immediately
* getHealthInfo() does not call any callbacks at all.

Test: VTS test call getHealthInfo does not invoke update()
Bug: 117167903
Change-Id: Ida99fdd73831e747fbf2d65089c7c0e7661fe7c4

2 years agohealth: use recursive_mutex.
Yifan Hong [Tue, 2 Oct 2018 21:06:51 +0000 (14:06 -0700)]
health: use recursive_mutex.

Need to use an reentrant lock.

Bug: 117167903
Test: vts
Change-Id: I25a366e06ed9d983823f7276668b7f45ddcf1c2b

2 years agoSkip hal v1 check after p on low ram devices
Ng Zhi An [Tue, 2 Oct 2018 21:02:09 +0000 (14:02 -0700)]
Skip hal v1 check after p on low ram devices
am: a0eb7e415c

Change-Id: I7e60e9faf24be23bf08ef65c5f0c074d4e7da2a4

2 years agoMerge "Revert "Set vendor: true for boot control HAL""
Hridya Valsaraju [Tue, 2 Oct 2018 20:43:12 +0000 (20:43 +0000)]
Merge "Revert "Set vendor: true for boot control HAL""

2 years agoRevert "Set vendor: true for boot control HAL"
Hridya Valsaraju [Tue, 2 Oct 2018 20:09:17 +0000 (20:09 +0000)]
Revert "Set vendor: true for boot control HAL"

This reverts commit f009da1bf51087cc33ae81101e3bf50df7683ecd.

Reason for revert: Breaking presubmit boot test on walleye

Change-Id: Ibeebb94b22cf81087b2ee60407a33e9d7e8a4d18

2 years agoSkip hal v1 check after p on low ram devices
Ng Zhi An [Thu, 27 Sep 2018 23:55:47 +0000 (16:55 -0700)]
Skip hal v1 check after p on low ram devices

Bug: 116546417
Test: vts-tradefed run commandAndExit vts
-m VtsHalCameraProviderV2_4Target
-t VtsHalCameraProviderV2_4Target#CameraHidlTest.noHal1AfterP

Change-Id: I28782b560975b49e20d6b42d599d689f819a9383

2 years agoEmergency Function HAL (continued)
sqian [Wed, 19 Sep 2018 21:10:42 +0000 (14:10 -0700)]
Emergency Function HAL (continued)

- Add Emergency Number source for Emergency number, which is critical for
management and display priority.
- Remove solicited request for getting emergency number list.
- Rephrasing the documentations.

Test: Treehugger (will add VTS later)
Bug: 112657134
Change-Id: Idbfebf8d246de06fd91e8de89088f5cc2c70227b

2 years agoMerge "Initialize healthd_mode_ops in recovery default Health HAL impl."
Treehugger Robot [Tue, 2 Oct 2018 05:21:45 +0000 (05:21 +0000)]
Merge "Initialize healthd_mode_ops in recovery default Health HAL impl."

2 years agoMerge "Set vendor: true for boot control HAL"
Treehugger Robot [Tue, 2 Oct 2018 00:20:16 +0000 (00:20 +0000)]
Merge "Set vendor: true for boot control HAL"

2 years agoSet vendor: true for boot control HAL
Hridya Valsaraju [Mon, 1 Oct 2018 22:50:50 +0000 (15:50 -0700)]
Set vendor: true for boot control HAL

Test: make boot image and check if boot contol HAL implementation
is present in vendor and recovery.
Bug: 117072247

Change-Id: Id05563fc3b4bdf135bf7e1ae75d23f34a98845ab

2 years agoAdd noexcept to move constructors and assignment operators.
Chih-Hung Hsieh [Tue, 25 Sep 2018 19:01:51 +0000 (12:01 -0700)]
Add noexcept to move constructors and assignment operators.

Bug: 116614593
Test: build with WITH_TIDY=1
Change-Id: Ib50ced82d650737cf99a9757133119945a3409f3

2 years agoMerge "Allow more time to un-blacklist strongest satelite" into pie-vts-dev
WyattRiley [Mon, 1 Oct 2018 15:45:04 +0000 (08:45 -0700)]
Merge "Allow more time to un-blacklist strongest satelite" into pie-vts-dev
am: 23874c7ae9

Change-Id: I957af82082f7e3dbff01159740455c71b5aaddcb

2 years agoMerge "Allow more time to un-blacklist strongest satelite" into pie-vts-dev
Treehugger Robot [Mon, 1 Oct 2018 15:38:05 +0000 (15:38 +0000)]
Merge "Allow more time to un-blacklist strongest satelite" into pie-vts-dev

2 years agoInitialize healthd_mode_ops in recovery default Health HAL impl.
Hridya Valsaraju [Fri, 28 Sep 2018 17:44:02 +0000 (10:44 -0700)]
Initialize healthd_mode_ops in recovery default Health HAL impl.

This is required for correct functioning of getHealthInfo() API
in recovery since BatteryMonitor requires healthd_mode_ops to be
initialized to update battery properties.

Bug: 78793464
Test: fastboot getvar battery-voltage
Change-Id: I9ff77664cada22e4aa3668bfb7d28d5f1d45590b

2 years agoAdd command to check whether off-mode-charging is enabled.
Hridya Valsaraju [Thu, 27 Sep 2018 17:21:07 +0000 (10:21 -0700)]
Add command to check whether off-mode-charging is enabled.

Bug: 78793464
Bug: 79480454
Test: fastboot getvar off-mode-charge
Change-Id: I1bd4148ff3476acf110e4aa95a40084300608875
Merged-In: I1bd4148ff3476acf110e4aa95a40084300608875
(cherry picked from commit 3d76cf0d8e6abe52e459bb7bc741e58b34b9790d)

2 years agoAdd command to read fastboot variable 'variant'
Hridya Valsaraju [Wed, 26 Sep 2018 20:06:21 +0000 (13:06 -0700)]
Add command to read fastboot variable 'variant'

Bug: 79480454
Test: fastboot getvar variant
Change-Id: I04f588f09d03e121c066449b0a7223f51d2e59af
Merged-In: I04f588f09d03e121c066449b0a7223f51d2e59af
(cherry picked from commit 3f27a7b373305f98117607f159eeb3c4e1fe4f6f)

2 years agoAllow more time to un-blacklist strongest satelite
WyattRiley [Fri, 21 Sep 2018 21:33:31 +0000 (14:33 -0700)]
Allow more time to un-blacklist strongest satelite

Also fixes a few intermediate values and confusing
logging discovered during weak GPS signal testing.

Change-Id: I2d3c5113956132ef4b60e28653aacf89f1159d83
Fixes: 116170859
Test: Deep indoor fail and windowledge pass of VTS on
test phone, and logcat values check.

2 years agoAdd atrace HAL 1.0
Wei Wang [Fri, 21 Sep 2018 22:44:31 +0000 (15:44 -0700)]
Add atrace HAL 1.0

Bug: 111098596
Test: vts, atrace and systrace

(cherry picked from commit db895ad8da1008082521146eac3647907a56a2b1)

Change-Id: Iea4ee4bff7509031a6daaf7c9570d0583a59affa

2 years agoTest getActiveMicrophones API when mic is found on the device.
jiabin [Thu, 27 Sep 2018 18:39:22 +0000 (11:39 -0700)]
Test getActiveMicrophones API when mic is found on the device.
am: 497edcc026

Change-Id: I55a1ab98ef141b9834ec22491b31e09f581fca1a

2 years agoTest getActiveMicrophones API when mic is found on the device.
jiabin [Wed, 15 Aug 2018 23:57:54 +0000 (16:57 -0700)]
Test getActiveMicrophones API when mic is found on the device.

Before this patch the default microphone was required to have characteristics
although it is not always an attached device, thus its characteristics can not
be known by the HAL. Additionally, the HAL might not know the active
microphone info of a input stream if it has not been started yet.

This patch only tests microphones which characteristics are reported by the HAL
and start the input stream before requesting active microphones.

Bug: 109787938
Test: vts-tradefed run vts --module VtsHalAudioV4_0Target
Change-Id: If55bfc8210d4f9443d34951f717c6772b46dde04
Merged-In: If55bfc8210d4f9443d34951f717c6772b46dde04

2 years agoFixed minor comment typos in IKeymasterDevice.hal
Rob Barnes [Mon, 24 Sep 2018 16:35:29 +0000 (10:35 -0600)]
Fixed minor comment typos in IKeymasterDevice.hal

Test: 'make checkbuild' finished successfully.
Change-Id: I4ceb39475fff176bfcd57e10335aa1af64849739

2 years agoReland "Add command to pass oem commands to HAL"
Hridya Valsaraju [Fri, 21 Sep 2018 23:06:30 +0000 (16:06 -0700)]
Reland "Add command to pass oem commands to HAL"

Test: make

This reverts commit 2e880493d6a227b050dabc6caa294eea408338ca.
Change-Id: I7cdfa6a01b5d776659dd4e7595915574b341cd9c
Merged-In: I7cdfa6a01b5d776659dd4e7595915574b341cd9c
(cherry picked from commit 3c2443ec29984c7c003e8b21a26fc25ad519475d)

2 years agoMerge changes from topic "current-on-aosp"
Steven Moreland [Tue, 25 Sep 2018 17:49:56 +0000 (17:49 +0000)]
Merge changes from topic "current-on-aosp"

* changes:
  Add health filesystem HAL to compatibility matrix
  Update power hidl to version 1.3 in compatibility_matrix.current.xml.
  Add configstore@1.1 to current matrix.
  Add compatibility_matrix.current.xml for Android Q.

2 years agoRemove NNAPI 1.2 HAL hash
Miao Wang [Tue, 25 Sep 2018 01:01:44 +0000 (18:01 -0700)]
Remove NNAPI 1.2 HAL hash

The interface is not finalized yet, and so it isn't frozen.

Test: mm
Change-Id: Ib4925afe2c3230c8727b3122ab21780b2f22489c

2 years agoAdd health filesystem HAL to compatibility matrix
Yifan Hong [Thu, 9 Aug 2018 20:32:04 +0000 (13:32 -0700)]
Add health filesystem HAL to compatibility matrix

Test: no build errors
Bug: 111655771
Change-Id: I4cc6308f969840996560ac65143744d37cbf0b14
(cherry picked from commit 62ca53926e2af578fcca3ce649d621aec39971ec)
Merged-In: I4cc6308f969840996560ac65143744d37cbf0b14

2 years agoUpdate power hidl to version 1.3 in compatibility_matrix.current.xml.
Peiyong Lin [Thu, 21 Jun 2018 21:02:13 +0000 (14:02 -0700)]
Update power hidl to version 1.3 in compatibility_matrix.current.xml.

BUG: 110112323
Test: adb shell /data/nativetest/VtsHalPowerV1_3TargetTest/VtsHalPowerV1_3TargetTest
Change-Id: I397a30044850ffa8d078dce7ef201073ae65c940
(cherry picked from commit 9475cc240b11a120a7d0762aa63df362e0bcbf0d)
Merged-In: I397a30044850ffa8d078dce7ef201073ae65c940

2 years agoAdd configstore@1.1 to current matrix.
Steven Moreland [Wed, 23 May 2018 20:35:08 +0000 (13:35 -0700)]
Add configstore@1.1 to current matrix.

This was added late in P. Go ahead and require
configstore@1.1 since it is built from a universal source
for all devices as well.

Bug: 69691076
Test: N/A
Change-Id: I0203ecc2e70127c11f596896f71c869d12cd3973
(cherry picked from commit 74274cfbc61dc396c5588adf52ac557086a2134f)
Merged-In: I0203ecc2e70127c11f596896f71c869d12cd3973

2 years agoAdd compatibility_matrix.current.xml for Android Q.
Steven Moreland [Mon, 30 Apr 2018 20:02:02 +0000 (13:02 -0700)]
Add compatibility_matrix.current.xml for Android Q.

HAL development is starting for Andorid Q, so we need this.

Test: m compatibility_matrix.current.xml
Test: assemble_vintf (but b/78895849)
Test: boot a Pixel device after setting its target-level to 4
    and verify that the compatibility check passes, and the
    file is in the correct location (system/etc/vintf) and that
    the dependencies are setup properly.
Change-Id: I42426d0145a97c719092306abc4f7ce8fa2b51bd
(cherry picked from commit 2d2e2d5c05cd53572805a4cd1a1d6af893d05b5a)
Merged-In: I42426d0145a97c719092306abc4f7ce8fa2b51bd

2 years agoMerge "Don't use initializer_list as return type"
Treehugger Robot [Mon, 24 Sep 2018 21:24:33 +0000 (21:24 +0000)]
Merge "Don't use initializer_list as return type"

2 years agoSync docs with NeuralNetworks.h
Slava Shklyaev [Mon, 17 Sep 2018 11:03:42 +0000 (12:03 +0100)]
Sync docs with NeuralNetworks.h

Bug: 115855152
Test: none
Change-Id: I15b5207f3ffbea57a4c8313ce744a22ce72b402e

2 years agoMerge changes from topic "nnapisync_1.2"
Przemyslaw Szczepaniak [Mon, 24 Sep 2018 12:25:55 +0000 (12:25 +0000)]
Merge changes from topic "nnapisync_1.2"

* changes:
  Add VTS tests for NeuralNetworks v1.2
  Create NeuralNetworks HAL v1.2 for new OperationTypes

2 years agoMerge "Revert "Add command to pass oem commands to HAL""
Treehugger Robot [Sat, 22 Sep 2018 00:05:37 +0000 (00:05 +0000)]
Merge "Revert "Add command to pass oem commands to HAL""

2 years agoRevert "Add command to pass oem commands to HAL"
Hridya Valsaraju [Fri, 21 Sep 2018 22:38:57 +0000 (22:38 +0000)]
Revert "Add command to pass oem commands to HAL"

This reverts commit ddaa8ecb379479a3450c954161df33fda1348685.

Reason for revert: This needs to go to master first to prevent build breaks.

Change-Id: I6418f1ba5dab492dc11b8c24e5d83ea7257d9699

2 years agoDon't use initializer_list as return type
Yi Kong [Fri, 21 Sep 2018 22:30:45 +0000 (15:30 -0700)]
Don't use initializer_list as return type

The underlying array may be cleaned up once its lifetime has ended,
the initializer_list would become ill-formed. Return as std::vector
instead.

This fixes "-Wreturn-stack-address" (clang) / "-Winit-list-lifetime"
(gcc) warning.

Test: mma
Bug: 111998531
Change-Id: Ie5bb6bc3d0d7689744fd573c5683b22e6fb6b178

2 years agoMerge "health.storage: Add VTS test."
Yifan Hong [Fri, 21 Sep 2018 22:20:24 +0000 (22:20 +0000)]
Merge "health.storage: Add VTS test."

2 years agohealth.storage: Add VTS test.
Yifan Hong [Thu, 9 Aug 2018 00:51:10 +0000 (17:51 -0700)]
health.storage: Add VTS test.

Test: run test
Bug: 111655771
Change-Id: I353026bcf882fcdafa9986e4f60d5853abac7e54

2 years agoAdd VTS tests for NeuralNetworks v1.2
Slava Shklyaev [Wed, 12 Sep 2018 13:52:02 +0000 (14:52 +0100)]
Add VTS tests for NeuralNetworks v1.2

This is a copy the v1.1 tests since we don't have any new ops
implemented in v1.2 yet.

Bug: 114365802
Test: mm
Test: NNAPI VTS
Change-Id: Ida7525fcd3ae0fd6f88ff9591e06aba922bdae64
Merged-In: Ida7525fcd3ae0fd6f88ff9591e06aba922bdae64
(cherry-picked from 871be9477032e595f685e02f256b2909ea524fc0)

2 years agoCreate NeuralNetworks HAL v1.2 for new OperationTypes
Slava Shklyaev [Fri, 7 Sep 2018 14:27:24 +0000 (15:27 +0100)]
Create NeuralNetworks HAL v1.2 for new OperationTypes

Bug: 114365802
Test: mm
Change-Id: I86b9261729a64d02ed30dc822a0226de11473ac8
Merged-In: I86b9261729a64d02ed30dc822a0226de11473ac8
(cherry-picked from 060a9acb3b982a51b4ae79f9456b3589229ba805)

2 years agohealth.storage: Add default implementation.
Yifan Hong [Thu, 9 Aug 2018 00:50:48 +0000 (17:50 -0700)]
health.storage: Add default implementation.

Test: lshal show default implementation when installed
Test: `lshal debug` (read and write successfully)
Test: `adb shell sm idle-maint run`
Bug: 111655771
Change-Id: Ibb09836b99310b6bc21e87be9c0177175efa29df

2 years agoMerge "Radio HAL: Add VoPS network support"
Amruth Ramachandran [Thu, 20 Sep 2018 18:11:22 +0000 (18:11 +0000)]
Merge "Radio HAL: Add VoPS network support"

2 years agoAudio VTS: Workaround async HIDL destructor by sleeping
Kevin Rocard [Thu, 20 Sep 2018 17:48:42 +0000 (10:48 -0700)]
Audio VTS: Workaround async HIDL destructor by sleeping
am: d87a288e82

Change-Id: I6af4b725b9917d99c450287ba4bfce864371a104

2 years agoMerge "health.filesystem::IFileSystem -> health.storage::IStorage"
Yifan Hong [Thu, 20 Sep 2018 17:26:53 +0000 (17:26 +0000)]
Merge "health.filesystem::IFileSystem -> health.storage::IStorage"

2 years agoRadio HAL: Add VoPS network support
Amruth Ramachandran [Tue, 11 Sep 2018 03:48:49 +0000 (20:48 -0700)]
Radio HAL: Add VoPS network support

 Update 1.3 HAL:
 - Added DataRegStateResult
 - Added LteVopsInfo
 - Added getDataRegistrationStateResponse_1_3

Bug:112194535
Test: Compiled. VTS tests to be added in separate gerrit

Change-Id: I1996bb0dbfb1c585668b097c206296d5d8e3c8d0

2 years agoMerge "Add command to pass oem commands to HAL"
Treehugger Robot [Thu, 20 Sep 2018 04:19:12 +0000 (04:19 +0000)]
Merge "Add command to pass oem commands to HAL"

2 years agohealth.filesystem::IFileSystem -> health.storage::IStorage
Yifan Hong [Wed, 19 Sep 2018 17:17:40 +0000 (10:17 -0700)]
health.filesystem::IFileSystem -> health.storage::IStorage

Rename the HAL because it is regarding 'storage health',
not 'filesystem health'.

Bug: 111655771
Test: compiles
Change-Id: I07072c876fb07c88be8bd74cf6b84aec6020a697
Merged-In: I07072c876fb07c88be8bd74cf6b84aec6020a697

2 years agoAudio VTS: Workaround async HIDL destructor by sleeping
Kevin Rocard [Wed, 29 Aug 2018 23:22:52 +0000 (16:22 -0700)]
Audio VTS: Workaround async HIDL destructor by sleeping

The test creates an instance of the Audio HAL then destroys it and create it again.
The test assumed that the destruction was synchronous when in fact it is async with
no way of knowing when the object has been destroyed.

As a result, until a better solution is found, sleep for 100ms to hopefully let enouth
time for the HAL destructor to return.

Bug: 112566489
Test: adb shell /data/nativetest64/VtsHalAudioV4_0TargetTest/VtsHalAudioV4_0TargetTest --gtest_filter=*OpenPrimaryDeviceUsingGetDevice
      atest VtsHalAudioV4_0TargetTest
Change-Id: I0ec75c12007d39060232632708722df5bf0f99d7
Signed-off-by: Kevin Rocard <krocard@google.com>
2 years agoMerge "Audio VTS: Always check for Result::isOk()" into pie-vts-dev
Kevin Rocard [Tue, 18 Sep 2018 17:57:50 +0000 (10:57 -0700)]
Merge "Audio VTS: Always check for Result::isOk()" into pie-vts-dev
am: 2070f8b0b8

Change-Id: Icf4a294d1fef7626b8248500dffc6bcd0189571e

2 years agoMerge "Audio VTS: Always check for Result::isOk()" into pie-vts-dev
Treehugger Robot [Tue, 18 Sep 2018 17:49:08 +0000 (17:49 +0000)]
Merge "Audio VTS: Always check for Result::isOk()" into pie-vts-dev

2 years agoAdd command to pass oem commands to HAL
Hridya Valsaraju [Fri, 14 Sep 2018 22:37:40 +0000 (15:37 -0700)]
Add command to pass oem commands to HAL

Bug: 79480454
Bug: 78793464
Test: fastboot oem command

Change-Id: Ifa20badace91550812742702f3b16f5abe56be72

2 years agoMerge "ISafeUnion: add case w/ enum"
Treehugger Robot [Fri, 14 Sep 2018 02:50:22 +0000 (02:50 +0000)]
Merge "ISafeUnion: add case w/ enum"

2 years agoISafeUnion: add case w/ enum
Steven Moreland [Thu, 13 Sep 2018 23:05:44 +0000 (16:05 -0700)]
ISafeUnion: add case w/ enum

Bug: 115638948
Test: hidl_test
Test: hidl_test_java
Change-Id: I26b5cc25bd29c420160686b5572a005a7629784c

2 years agoMerge "Fix failing drm 1.0 vts tests"
Treehugger Robot [Thu, 13 Sep 2018 18:58:19 +0000 (18:58 +0000)]
Merge "Fix failing drm 1.0 vts tests"

2 years agoMerge "health filesystem: update garbageCollect() function."
Yifan Hong [Thu, 13 Sep 2018 16:22:25 +0000 (16:22 +0000)]
Merge "health filesystem: update garbageCollect() function."

2 years agoFix failing drm 1.0 vts tests
Jeff Tinker [Thu, 19 Jul 2018 23:31:56 +0000 (16:31 -0700)]
Fix failing drm 1.0 vts tests

The shared library path was incorrectly set based on
the drm.64bit.enabled flag. It should be set based
on whether the drm service is running as 32-bit or
64-bit.

Test: vts-tradefed run commandAndExit vts -m VtsHalDrmV1_0Target

bug:111289939
Change-Id: I388dc87bd4566211dc2901feccf1e6e1c90bfe67
Merged-In: I388dc87bd4566211dc2901feccf1e6e1c90bfe67

2 years agohealth filesystem: update garbageCollect() function.
Yifan Hong [Wed, 15 Aug 2018 21:41:01 +0000 (14:41 -0700)]
health filesystem: update garbageCollect() function.

Bug: 111655771
Test: run dev gc on vold

Change-Id: I2cef404f9e2720c1be7822895187a590837763c8

2 years agoFix logics for floating-point comparision in VTS test.
Xusong Wang [Wed, 12 Sep 2018 00:03:51 +0000 (17:03 -0700)]
Fix logics for floating-point comparision in VTS test.
am: 39c865b3aa

Change-Id: Iccb497fc3aa87e05a361427e350a3f51dd6f273c

2 years agokeymaster 3.0: make service use nobody as user and remove system group
Roberto Pereira [Mon, 10 Sep 2018 19:44:42 +0000 (12:44 -0700)]
keymaster 3.0: make service use nobody as user and remove system group

Only the drmrpc group is necessary

Test: VtsHalKeymasterV3_0TargetTest
Change-Id: I2be255215df827c9f17ecaffcb9d0ba402dd3405

2 years agoMerge "Note confusion-causing breaks in HIDL convention."
Treehugger Robot [Mon, 10 Sep 2018 14:00:13 +0000 (14:00 +0000)]
Merge "Note confusion-causing breaks in HIDL convention."

2 years agoNote confusion-causing breaks in HIDL convention.
Steven Moreland [Fri, 7 Sep 2018 00:58:16 +0000 (17:58 -0700)]
Note confusion-causing breaks in HIDL convention.

These were either made at a time when the convention was not fully
formed or missed during review.

It is somewhat misleading since method overloading isn't supported
and method names need this kind of prefix, but nothing else does.

The reason for this is that everything is namespaced, but methods are
all in the same namespace. The reason method overloading is not supported
in HIDL is because the HIDL types may map to types that collide in the
target languages, and this would cause any sort of overloading rules
to require complicated machinery.

Bug: N/A
Test: hidl-gen -Lcheck android.hardware.usb@1.1 android.hardware.vibrator@1.1 && echo ":)"
:)

Change-Id: Iac23c9311925ed140ff1e15d1366829b078c8866

2 years agoMerge "Get partition file system type from Fastboot HAL"
Treehugger Robot [Sat, 8 Sep 2018 02:47:41 +0000 (02:47 +0000)]
Merge "Get partition file system type from Fastboot HAL"

2 years agoMerge "[Graphics] Only validate display in PresentOrValidateDisplay."
Treehugger Robot [Fri, 7 Sep 2018 06:28:37 +0000 (06:28 +0000)]
Merge "[Graphics] Only validate display in PresentOrValidateDisplay."

2 years agoSkip NoUserConfirmation VTS test for Strongbox
Baranidharan Muthukumaran [Fri, 24 Aug 2018 20:41:49 +0000 (13:41 -0700)]
Skip NoUserConfirmation VTS test for Strongbox

Since Confirmation UI is optional for Strongbox
implementation, skipping the test.

Bug: 112189538
Test: This is an update to the vts test
Change-Id: Ie3485a1de92444b0c49670b198de30ea25e0673e
Signed-off-by: Max Bires <jbires@google.com>
2 years agoGet partition file system type from Fastboot HAL
Hridya Valsaraju [Tue, 8 May 2018 22:38:00 +0000 (15:38 -0700)]
Get partition file system type from Fastboot HAL

Partition type is required for fastbootd to
format partitions.

Test: make
Bug: 79480454
Change-Id: I49f21fe6f1626cf3da566b33cc84131b3e3c85ff