6 years agoRemove dependencies on libhwbinder. master android-o-mr1-iot-preview-7 android-o-mr1-iot-preview-8 android-p-preview-1 android-wear-8.0.0_r1
Remove dependencies on libhwbinder.
Bug: 34388964
Test: wifi works
Change-Id: I001e2da21d173fada2ad7f78c76e89227cbe37cc
Bug: 34388964
Test: wifi works
Change-Id: I001e2da21d173fada2ad7f78c76e89227cbe37cc
DO NOT MERGE: Merge Oreo MR1 into master
Exempt-From-Owner-Approval: Changes already landed internally
Change-Id: I015a74d0bd64844bbecdd7849d168a69da3eacb2
Exempt-From-Owner-Approval: Changes already landed internally
Change-Id: I015a74d0bd64844bbecdd7849d168a69da3eacb2
Merge "Use AP bssid for GetPacketCounters()" into oc-mr1-dev
am: 573422c56e
Change-Id: I0b1ece7e5dfc51c7c0c5c911011b1dfabc9d5d29
am: 573422c56e
Change-Id: I0b1ece7e5dfc51c7c0c5c911011b1dfabc9d5d29
Merge "Use AP bssid for GetPacketCounters()" into oc-mr1-dev
Use AP bssid for GetPacketCounters()
we should use AP bssid instead of local interface mac address
for NL80211_CMD_GET_STATION. Local interface mac address only
works for some devices.
Bug: 66218880
Test: compile, unit tests
Test: run the following CTS test:
cts-tradefed run cts -m CtsNetTestCases -t
android.net.wifi.cts.WifiManagerTest#testWifiWatchdog
Change-Id: I8852ab5085d186ee3f1e5b81abbf4c1d2500b9fa
we should use AP bssid instead of local interface mac address
for NL80211_CMD_GET_STATION. Local interface mac address only
works for some devices.
Bug: 66218880
Test: compile, unit tests
Test: run the following CTS test:
cts-tradefed run cts -m CtsNetTestCases -t
android.net.wifi.cts.WifiManagerTest#testWifiWatchdog
Change-Id: I8852ab5085d186ee3f1e5b81abbf4c1d2500b9fa
Cherry-pick: Fail RSSI polling if wifi is not associated
am: b3fb231cee
Change-Id: I14372022b36b3abd9cb8d1310c888aae763343d3
am: b3fb231cee
Change-Id: I14372022b36b3abd9cb8d1310c888aae763343d3
Cherry-pick: Fail RSSI polling if wifi is not associated
Bug: 65025500
Test: compile, unit tests
Merged-In: Id4fe741d4a66329302cea0961d1bc17a35aa9382
Change-Id: Id4fe741d4a66329302cea0961d1bc17a35aa9382
Bug: 65025500
Test: compile, unit tests
Merged-In: Id4fe741d4a66329302cea0961d1bc17a35aa9382
Change-Id: Id4fe741d4a66329302cea0961d1bc17a35aa9382
Merge "Wificond: Remove mannual memory management in OffloadScanManager" into oc-mr1-dev
am: de45b50b17
Change-Id: Iaf059d37c1657f5ecc73d21f1b871082316ec72a
am: de45b50b17
Change-Id: Iaf059d37c1657f5ecc73d21f1b871082316ec72a
Merge "Wificond: Remove mannual memory management in OffloadScanManager" into oc-mr1-dev
Count failures on fallback to netlink for pno metrics
am: c9cee96d62
Change-Id: I7fd6ac6c46236cae80e6b80bae96c1997aed95b2
am: c9cee96d62
Change-Id: I7fd6ac6c46236cae80e6b80bae96c1997aed95b2
Count failures on fallback to netlink for pno metrics
Call OnPnoScanFailed callback if failed to fallback to netlink pno
Bug: 32842314
Test: runtests.sh
Change-Id: I6aab3c7d95ee0cfd7adc4f5519fcd80caab60759
Call OnPnoScanFailed callback if failed to fallback to netlink pno
Bug: 32842314
Test: runtests.sh
Change-Id: I6aab3c7d95ee0cfd7adc4f5519fcd80caab60759
Wificond: Provide a way to enable Offload scans
am: 94abf86afd
Change-Id: Ie2abd3bd49dc46b30a84f0080b24c13896dac892
am: 94abf86afd
Change-Id: Ie2abd3bd49dc46b30a84f0080b24c13896dac892
Wificond: Remove mannual memory management in OffloadScanManager
Bug: 64853991
Test: Unit tests and on-device testing for finding APs in Offloaded PNO
scans
Change-Id: I88fcbaed00627a7d282b6214f93419a761764da6
Bug: 64853991
Test: Unit tests and on-device testing for finding APs in Offloaded PNO
scans
Change-Id: I88fcbaed00627a7d282b6214f93419a761764da6
Wificond: Provide a way to enable Offload scans
Enable use of adb shell setprop <property_string> <value> command
to enable using offload HAL for disconnected mode PNO scans.
Bug: 64944391
Test: Unit test and on device to test to ensure the command works
Change-Id: I911a15177f98be6040d161093bf4c97089973b9c
Enable use of adb shell setprop <property_string> <value> command
to enable using offload HAL for disconnected mode PNO scans.
Bug: 64944391
Test: Unit test and on device to test to ensure the command works
Change-Id: I911a15177f98be6040d161093bf4c97089973b9c
Merge "wificond.rc: Set CAP_NET_RAW and CAP_NET_ADMIN explicitly rather then implictly via group" am: 7a83a7b6ae am: ba2aef39e1
am: a7380222e1
Change-Id: I0950d7fbb7c616cbe12cc72cf3f1210f050dbc35
am: a7380222e1
Change-Id: I0950d7fbb7c616cbe12cc72cf3f1210f050dbc35
Merge "wificond.rc: Set CAP_NET_RAW and CAP_NET_ADMIN explicitly rather then implictly via group" am: 7a83a7b6ae
am: ba2aef39e1
Change-Id: If1cae3b2dfcbe3363df918152ef88fb87fabd4c9
am: ba2aef39e1
Change-Id: If1cae3b2dfcbe3363df918152ef88fb87fabd4c9
6 years agoMerge "wificond.rc: Set CAP_NET_RAW and CAP_NET_ADMIN explicitly rather then implictl... android-o-mr1-iot-preview-6
Merge "wificond.rc: Set CAP_NET_RAW and CAP_NET_ADMIN explicitly rather then implictly via group"
am: 7a83a7b6ae
Change-Id: Ief0640e87120c4aa3c7e5b1874f307a1baf43ef4
am: 7a83a7b6ae
Change-Id: Ief0640e87120c4aa3c7e5b1874f307a1baf43ef4
6 years agoMerge "wificond.rc: Set CAP_NET_RAW and CAP_NET_ADMIN explicitly rather then implictl... android-o-mr1-preview-1 android-o-mr1-preview-2
Merge "wificond.rc: Set CAP_NET_RAW and CAP_NET_ADMIN explicitly rather then implictly via group"
wificond.rc: Set CAP_NET_RAW and CAP_NET_ADMIN explicitly rather then implictly via group
Rather then depending on the ANDROID_PARANOID_NETWORKING hack,
which allows processes in group net_raw and net_admin to implicitly be
granted CAP_NET_RAW and CAP_NET_ADMIN, set the capabilities explictly.
This allows wificond to function on mainline based kernels that do
not enable ANDROID_PARANOID_NETWORKING.
Bug: 65022091
Change-Id: Ia44bf3192ab48944e7d423635a06650214d22b27
Signed-off-by: John Stultz <john.stultz@linaro.org>
Rather then depending on the ANDROID_PARANOID_NETWORKING hack,
which allows processes in group net_raw and net_admin to implicitly be
granted CAP_NET_RAW and CAP_NET_ADMIN, set the capabilities explictly.
This allows wificond to function on mainline based kernels that do
not enable ANDROID_PARANOID_NETWORKING.
Bug: 65022091
Change-Id: Ia44bf3192ab48944e7d423635a06650214d22b27
Signed-off-by: John Stultz <john.stultz@linaro.org>
Merge "Fix static analyzer warnings." am: 95bc0ff0d7 am: 8367747ea5 am: 7f1ec84fd1
am: 22ab38933b
Change-Id: I8c517249241b7f8035ec47e80a5244006b6e5ad3
am: 22ab38933b
Change-Id: I8c517249241b7f8035ec47e80a5244006b6e5ad3
Merge "Fix static analyzer warnings." am: 95bc0ff0d7 am: 8367747ea5
am: 7f1ec84fd1
Change-Id: I882a57c1a861ab5c6d911bd043630a0ba3bf932a
am: 7f1ec84fd1
Change-Id: I882a57c1a861ab5c6d911bd043630a0ba3bf932a
Merge "Fix static analyzer warnings." am: 95bc0ff0d7
am: 8367747ea5
Change-Id: Idc08e94f9a60f09e3f2ae2efb53bea7f3590f78e
am: 8367747ea5
Change-Id: Idc08e94f9a60f09e3f2ae2efb53bea7f3590f78e
Merge "Fix static analyzer warnings."
am: 95bc0ff0d7
Change-Id: I1a6a9e858ded5f1c6c7c41453b768a0b234b012e
am: 95bc0ff0d7
Change-Id: I1a6a9e858ded5f1c6c7c41453b768a0b234b012e
Merge "Fix static analyzer warnings."
Merge "Remove RTT related code from wificond" into oc-mr1-dev
am: 7018247f52
Change-Id: I66a110dbfdc0dcd8241d6d53d30dec7ee5b2dab0
am: 7018247f52
Change-Id: I66a110dbfdc0dcd8241d6d53d30dec7ee5b2dab0
Merge "Remove RTT related code from wificond" into oc-mr1-dev
Conditional compile flags not allowed in BoardConfig
am: 5002120904
Change-Id: If00bbc99c8dce35e1cb6e3d85a009d4ca90a1568
am: 5002120904
Change-Id: If00bbc99c8dce35e1cb6e3d85a009d4ca90a1568
Wificond ScannerImpl Unit testing Offload HAL
am: 8f574ac480
Change-Id: I6167b0f9d03b366caca1058bfcfaa91e38a0dc90
am: 8f574ac480
Change-Id: I6167b0f9d03b366caca1058bfcfaa91e38a0dc90
Wificond: Address bugs in handling Offload scans
am: 8043a56883
Change-Id: I6133dd6be7cdb1cdac3f2e94bf643e315445c604
am: 8043a56883
Change-Id: I6133dd6be7cdb1cdac3f2e94bf643e315445c604
Wificond: Create mocks of Offload Scan objects
am: 69f61f7fd1
Change-Id: Ic94f0f3ed105351efbe89f647fc18b6e21f3946a
am: 69f61f7fd1
Change-Id: Ic94f0f3ed105351efbe89f647fc18b6e21f3946a
Remove RTT related code from wificond
Bug: 64809697
Test: compile, unit tests
Change-Id: I4457dee48b7af6e4d2d709b636e4ddecbd8d68cd
Bug: 64809697
Test: compile, unit tests
Change-Id: I4457dee48b7af6e4d2d709b636e4ddecbd8d68cd
Wifficond: Implement API to get PNO scan results
am: 64187ec9e8
Change-Id: I667c9f0ac0b0c5d9b99735890d7f79cabce30cc5
am: 64187ec9e8
Change-Id: I667c9f0ac0b0c5d9b99735890d7f79cabce30cc5
Wificond: Make Offload HAL service nonblocking
am: 7439bcacc8
Change-Id: I2524ab40b19d0e7d8d02725c1933f0bfce6083d4
am: 7439bcacc8
Change-Id: I2524ab40b19d0e7d8d02725c1933f0bfce6083d4
Wificond: Async Errors from Offload HAL service
am: e15c0edc98
Change-Id: I3e35f8f110a4f0a7853a86e81fb89c7d42d9cc90
am: e15c0edc98
Change-Id: I3e35f8f110a4f0a7853a86e81fb89c7d42d9cc90
Wificond: AIDL APIs for Offload HAL API metrics
am: dbc54f3c73
Change-Id: I02b443b91977237cdada6d8e39561dab3a0ba013
am: dbc54f3c73
Change-Id: I02b443b91977237cdada6d8e39561dab3a0ba013
Wificond: Converting Offload scan results update
am: 8a89f6126f
Change-Id: Ibf86652bab751bc6a3f11976cb6143a2e6785d59
am: 8a89f6126f
Change-Id: Ibf86652bab751bc6a3f11976cb6143a2e6785d59
Conditional compile flags not allowed in BoardConfig
The assumption that the Boardconfig.mk will export a flag that will
determine support for a feature is incorrect. Remove using of this
assumed flag from wificond.
Bug: 32842314
Test: Unit tests, On device test
Change-Id: I3aa33318a5e220a30f9950a7bb9488058f1421b9
The assumption that the Boardconfig.mk will export a flag that will
determine support for a feature is incorrect. Remove using of this
assumed flag from wificond.
Bug: 32842314
Test: Unit tests, On device test
Change-Id: I3aa33318a5e220a30f9950a7bb9488058f1421b9
Wificond ScannerImpl Unit testing Offload HAL
Wificond ScannerImpl interfaces with Offload HAL to invoke APIs to
perform disconnected mode PNO scans. This CL tests behavior of
ScannerImpl.
Bug: 32842314
Test: Unit test and VTS
Change-Id: I070d17c98ce90a9aeded80eac7135d02e36f0231
Wificond ScannerImpl interfaces with Offload HAL to invoke APIs to
perform disconnected mode PNO scans. This CL tests behavior of
ScannerImpl.
Bug: 32842314
Test: Unit test and VTS
Change-Id: I070d17c98ce90a9aeded80eac7135d02e36f0231
Wificond: Address bugs in handling Offload scans
This CL addresses the following issues in handling of Offload HAL scan
results from the Offload HAL service
- Make cached scan results member variable a pointer so that the memory
for the vector can be allocated on the heap
- When an Async Error occurs in the Offload HAL service, switch to
performing PNO scans over netlink instead of letting it decide again.
- OffloadScanUtils convertToNativeScanResults() now needs to take in a
pointer to the vector that will store the scan results for retrieval.
- Populate tsf field fo the scanResult so that it doesn't get filtered
out by the framework
- Add logging to scan stats
Bug: 63148974
Test: Unit tests, on-device testing for ensuring we connect to an
available access point from screen off disconnected mode.
Change-Id: Ida507d857faa8ea6dbee362cf0116f8ca858963f
This CL addresses the following issues in handling of Offload HAL scan
results from the Offload HAL service
- Make cached scan results member variable a pointer so that the memory
for the vector can be allocated on the heap
- When an Async Error occurs in the Offload HAL service, switch to
performing PNO scans over netlink instead of letting it decide again.
- OffloadScanUtils convertToNativeScanResults() now needs to take in a
pointer to the vector that will store the scan results for retrieval.
- Populate tsf field fo the scanResult so that it doesn't get filtered
out by the framework
- Add logging to scan stats
Bug: 63148974
Test: Unit tests, on-device testing for ensuring we connect to an
available access point from screen off disconnected mode.
Change-Id: Ida507d857faa8ea6dbee362cf0116f8ca858963f
Wificond: Create mocks of Offload Scan objects
Create objects for Offload HAL to enable testing of Scanner Impl
Test: Unit tests
Bug: 32842314
Change-Id: Iea881dbbef0f6dc53b87f8ea24acd3c3e347f902
Create objects for Offload HAL to enable testing of Scanner Impl
Test: Unit tests
Bug: 32842314
Change-Id: Iea881dbbef0f6dc53b87f8ea24acd3c3e347f902
Wifficond: Implement API to get PNO scan results
Implement getPnoScanResults() API to return scan results from the
interface that completed the scheduled PNO scans in disconnected mode
most recently.
Bug: 63148974
Test: Unit tests, sanity test and on-device tests
Change-Id: Ife9f890faa7cdbc34da83708f59eae7398e76109
Implement getPnoScanResults() API to return scan results from the
interface that completed the scheduled PNO scans in disconnected mode
most recently.
Bug: 63148974
Test: Unit tests, sanity test and on-device tests
Change-Id: Ife9f890faa7cdbc34da83708f59eae7398e76109
Wificond: Make Offload HAL service nonblocking
Offload HAL getService() is a blocking call which can cause a deadlock.
Replace it with non blocking call tryGetService() which returns null if
the service is not running instead of waiting on the service to start.
This implies that the client needs to be able to get a reference to the
service at a later time. The design choice is to use tryGetService() API
to get the handle when a disconnected mode PNO scan is requested if this
was not available before.
Bug: 62807929
Test: Unit test, sanity test
Change-Id: I344fd93c4afe2381c356e626e83311af49a5ad49
Offload HAL getService() is a blocking call which can cause a deadlock.
Replace it with non blocking call tryGetService() which returns null if
the service is not running instead of waiting on the service to start.
This implies that the client needs to be able to get a reference to the
service at a later time. The design choice is to use tryGetService() API
to get the handle when a disconnected mode PNO scan is requested if this
was not available before.
Bug: 62807929
Test: Unit test, sanity test
Change-Id: I344fd93c4afe2381c356e626e83311af49a5ad49
Wificond: Async Errors from Offload HAL service
Asynchronous errors from the Offload HAL service must be forwarded to
Wificond scanner implementation which can then switch over to the other
interfaces for completing disconnected PNO scans. This requires
specification of an interface from Offload HAL client to Wificond's
scanner implementation. Unit tetsts are updated accordingly.
Bug: 32842314
Test: Unit test and VTS
Change-Id: Ie56a52caf161c851d1945584a2bf93734008598a
Asynchronous errors from the Offload HAL service must be forwarded to
Wificond scanner implementation which can then switch over to the other
interfaces for completing disconnected PNO scans. This requires
specification of an interface from Offload HAL client to Wificond's
scanner implementation. Unit tetsts are updated accordingly.
Bug: 32842314
Test: Unit test and VTS
Change-Id: Ie56a52caf161c851d1945584a2bf93734008598a
Wificond: AIDL APIs for Offload HAL API metrics
Add new APIs to IPnoScanEvent AIDL itnerface that can be used to report
Offload HAL events for purposes of Offload HAL scan metric collection
by framework
Bug: 32842314
Test: Unit tests, on-device test for connecting to a network found by
Offload HAL during PNO scans
Change-Id: Iae97389a35a728e3c0fc67f4f2c9937a8fa4acee
Add new APIs to IPnoScanEvent AIDL itnerface that can be used to report
Offload HAL events for purposes of Offload HAL scan metric collection
by framework
Bug: 32842314
Test: Unit tests, on-device test for connecting to a network found by
Offload HAL during PNO scans
Change-Id: Iae97389a35a728e3c0fc67f4f2c9937a8fa4acee
Wificond: Converting Offload scan results update
When converting scan results from Offload HAL to NativeScanResult
format, fix updating the BSSID field.
Bug: 63148974
Test: Unit test, sanity test - bring up the phone and connect with
access points, test disconnected mode PNO scans with Offload HAL as the
interface of choice
Change-Id: I60ae8b4e6422727c2cab2d2fca4c5a0730558035
When converting scan results from Offload HAL to NativeScanResult
format, fix updating the BSSID field.
Bug: 63148974
Test: Unit test, sanity test - bring up the phone and connect with
access points, test disconnected mode PNO scans with Offload HAL as the
interface of choice
Change-Id: I60ae8b4e6422727c2cab2d2fca4c5a0730558035
Merge changes from topic 'am-cfc716cb4535420ebfeeeb4fd0d179e3' into oc-mr1-dev-plus-aosp
* changes:
Support scan plan attribute for scheduled scan am: dfbe7e4e12 am: 42a0681f17
Retrieve scan plan capabilities from kernel am: 514a184b8e am: 2047993daf
* changes:
Support scan plan attribute for scheduled scan am: dfbe7e4e12 am: 42a0681f17
Retrieve scan plan capabilities from kernel am: 514a184b8e am: 2047993daf
Support scan plan attribute for scheduled scan am: dfbe7e4e12
am: 3579413d25
Change-Id: I758554f8377c09ce897900fd9cdbe6bb32b86c8b
am: 3579413d25
Change-Id: I758554f8377c09ce897900fd9cdbe6bb32b86c8b
Support scan plan attribute for scheduled scan am: dfbe7e4e12
am: 42a0681f17
Change-Id: I934bfe02ae968870083e9c7e72988c2d4147f7ae
am: 42a0681f17
Change-Id: I934bfe02ae968870083e9c7e72988c2d4147f7ae
Retrieve scan plan capabilities from kernel am: 514a184b8e
am: dd4c84a8d7
Change-Id: I5820d82e47a3e8b5132d767bf2cc928444a92e84
am: dd4c84a8d7
Change-Id: I5820d82e47a3e8b5132d767bf2cc928444a92e84
Retrieve scan plan capabilities from kernel am: 514a184b8e
am: 2047993daf
Change-Id: I005e6956e54bd1619384b577b50ac0ee98f2a25f
am: 2047993daf
Change-Id: I005e6956e54bd1619384b577b50ac0ee98f2a25f
Support scan plan attribute for scheduled scan
am: dfbe7e4e12
Change-Id: I9f02cb749ee81c0083157d002d72cda25782cde8
am: dfbe7e4e12
Change-Id: I9f02cb749ee81c0083157d002d72cda25782cde8
Support scan plan attribute for scheduled scan
am: dfbe7e4e12
Change-Id: Ie95cfb7746db96a64dab898a55edccabb34d75cc
am: dfbe7e4e12
Change-Id: Ie95cfb7746db96a64dab898a55edccabb34d75cc
Retrieve scan plan capabilities from kernel
am: 514a184b8e
Change-Id: I542e1a15d38bbb34449d7d5c98b75fb04580ddee
am: 514a184b8e
Change-Id: I542e1a15d38bbb34449d7d5c98b75fb04580ddee
Retrieve scan plan capabilities from kernel
am: 514a184b8e
Change-Id: I7cf1787d37476fde9340dd3eaad221fbde0286d0
am: 514a184b8e
Change-Id: I7cf1787d37476fde9340dd3eaad221fbde0286d0
Support scan plan attribute for scheduled scan
This adds the support of the scan plan attribute.
With kernel updates, driver can no longer diffrentiate interval
attribute from single scan plan attribute, so driver's pno scan
back off logic cannot be triggered in that case.
To solve the PNO back-off problem, this CL allows wificond to explicitly
specify scan plans (if the driver supports it). With explicit scan
plans, the driver will have the information it needs to back-off PNO
scans.
Bug: 63837760
Test: compile, unit tests
Test: Manually test that pno scan works on multiple devices
Test: Integration sanity test
Change-Id: Ic7e38caa482a2d72f45bf3c8177fa656e534db08
This adds the support of the scan plan attribute.
With kernel updates, driver can no longer diffrentiate interval
attribute from single scan plan attribute, so driver's pno scan
back off logic cannot be triggered in that case.
To solve the PNO back-off problem, this CL allows wificond to explicitly
specify scan plans (if the driver supports it). With explicit scan
plans, the driver will have the information it needs to back-off PNO
scans.
Bug: 63837760
Test: compile, unit tests
Test: Manually test that pno scan works on multiple devices
Test: Integration sanity test
Change-Id: Ic7e38caa482a2d72f45bf3c8177fa656e534db08
Retrieve scan plan capabilities from kernel
Bug: 63837760
Test: compile, unit test
Test: manually inserting logs to test it retrieves the correct
values.
Change-Id: I750bd287b4f1cb8df44b8d1367c69f7963a3d8dc
Bug: 63837760
Test: compile, unit test
Test: manually inserting logs to test it retrieves the correct
values.
Change-Id: I750bd287b4f1cb8df44b8d1367c69f7963a3d8dc
Fix static analyzer warnings.
Fix the following warnings:
system/connectivity/wificond/net/netlink_manager.cpp:189:54: warning:
Assigned value is garbage or undefined
[clang-analyzer-core.uninitialized.Assign]
system/connectivity/wificond/tests/nl80211_attribute_unittest.cpp:280:22:
warning: The left operand of '==' is a garbage value
[clang-analyzer-core.UndefinedBinaryOperatorResult]
system/connectivity/wificond/tests/nl80211_attribute_unittest.cpp:281:22:
warning: The left operand of '==' is a garbage value
[clang-analyzer-core.UndefinedBinaryOperatorResult]
system/connectivity/wificond/tests/nl80211_attribute_unittest.cpp:282:22:
warning: The left operand of '==' is a garbage value
[clang-analyzer-core.UndefinedBinaryOperatorResult]
Bug: b/27101951
Test:Warnings are gone.
Change-Id: Ice4e7cd9954953affbd2e34d5c85b3e96a2756a1
Fix the following warnings:
system/connectivity/wificond/net/netlink_manager.cpp:189:54: warning:
Assigned value is garbage or undefined
[clang-analyzer-core.uninitialized.Assign]
system/connectivity/wificond/tests/nl80211_attribute_unittest.cpp:280:22:
warning: The left operand of '==' is a garbage value
[clang-analyzer-core.UndefinedBinaryOperatorResult]
system/connectivity/wificond/tests/nl80211_attribute_unittest.cpp:281:22:
warning: The left operand of '==' is a garbage value
[clang-analyzer-core.UndefinedBinaryOperatorResult]
system/connectivity/wificond/tests/nl80211_attribute_unittest.cpp:282:22:
warning: The left operand of '==' is a garbage value
[clang-analyzer-core.UndefinedBinaryOperatorResult]
Bug: b/27101951
Test:Warnings are gone.
Change-Id: Ice4e7cd9954953affbd2e34d5c85b3e96a2756a1
Do not crash on netlink manager start error
For some device(emulator) kernel netlink interface is not configured.
NetlinkManager.Start() will fail and crash wificond.
Wificond is included in base.mk so it is not feasible to remove
it from emulator image.
This patch changes the error level from FATAL to ERROR to avoid
crashing.
Bug: 63837784
Test: compile, manual test wificond works
Change-Id: I0cf3f6a1ea73e455f8362870e4c96c76b59dd41c
For some device(emulator) kernel netlink interface is not configured.
NetlinkManager.Start() will fail and crash wificond.
Wificond is included in base.mk so it is not feasible to remove
it from emulator image.
This patch changes the error level from FATAL to ERROR to avoid
crashing.
Bug: 63837784
Test: compile, manual test wificond works
Change-Id: I0cf3f6a1ea73e455f8362870e4c96c76b59dd41c
Merge "Use new netlink attribute for scan result timestamp" into oc-dr1-dev am: 30f40a8855
am: ce5cdd8492
Change-Id: Ifdea96308eed891801a42d6c282c7ac40e04aa61
am: ce5cdd8492
Change-Id: Ifdea96308eed891801a42d6c282c7ac40e04aa61
Merge "Use new netlink attribute for scan result timestamp" into oc-dr1-dev
am: 30f40a8855
Change-Id: I595fa798b0602ed7365476d358dcfdfdff0d4993
am: 30f40a8855
Change-Id: I595fa798b0602ed7365476d358dcfdfdff0d4993
Merge "Use new netlink attribute for scan result timestamp" into oc-dr1-dev
ScannerImpl: Add unit tests for scheduled scans am: 7a3d8ddff0
am: 62d5572e2f
Change-Id: I5e0710f98bce725c3101d763478893f94a902246
am: 62d5572e2f
Change-Id: I5e0710f98bce725c3101d763478893f94a902246
More unit tests for ScannerImpl am: c658fa0ae1
am: c13c2e23c9
Change-Id: I7754fa9a5030894355ded96e1c8fc14306e759c2
am: c13c2e23c9
Change-Id: I7754fa9a5030894355ded96e1c8fc14306e759c2
ScannerImpl: Add unit tests for scheduled scans
am: 7a3d8ddff0
Change-Id: I05a37a1fe3b942f9a70c4d95354a7ee10a3e5fb9
am: 7a3d8ddff0
Change-Id: I05a37a1fe3b942f9a70c4d95354a7ee10a3e5fb9
Use new netlink attribute for scan result timestamp
Bug: 37758502
Test: compile, manual test
Test: integration test
Test: manually test that on new and old devices, there should
be only a small portion of scan results filtered out.
Change-Id: I2cbcb6f4c5b58b6a56a746de97afe491a9e338ac
Bug: 37758502
Test: compile, manual test
Test: integration test
Test: manually test that on new and old devices, there should
be only a small portion of scan results filtered out.
Change-Id: I2cbcb6f4c5b58b6a56a746de97afe491a9e338ac
ScannerImpl: Add unit tests for scheduled scans
This patch adds unit tests for scheduled scans.
In order to do that, this also moves the isOffloadScanSupprted()
out of OffloadScanManager to OffloadServiceUtils. By injecting
MockOffloadServiceUtils to ScannerImpl, we can test either offload
supported or not supported cases.
Bug: 33452931
Test: compile, unit tests
Test: manual test that offload scan is not enabled by mistake.
This is done by checking manually inserted logs.
Change-Id: I6c78df78605321013676e5f4578026f21d953e3b
This patch adds unit tests for scheduled scans.
In order to do that, this also moves the isOffloadScanSupprted()
out of OffloadScanManager to OffloadServiceUtils. By injecting
MockOffloadServiceUtils to ScannerImpl, we can test either offload
supported or not supported cases.
Bug: 33452931
Test: compile, unit tests
Test: manual test that offload scan is not enabled by mistake.
This is done by checking manually inserted logs.
Change-Id: I6c78df78605321013676e5f4578026f21d953e3b
More unit tests for ScannerImpl
This adds unit tests for abortScan() and getScanResults().
Bug: 33452931
Test: compile, unit tests
Change-Id: I9920022c02ac18bdd0b1cd045682c63763361065
This adds unit tests for abortScan() and getScanResults().
Bug: 33452931
Test: compile, unit tests
Change-Id: I9920022c02ac18bdd0b1cd045682c63763361065
Merge "WifiCond: Setup polling on HW binder FD" into oc-dr1-dev am: b7a65e9a63
am: 8151c5232c
Change-Id: I5797739fb6c0f0b3b01b1592e1fc5a9a5ad4d062
am: 8151c5232c
Change-Id: I5797739fb6c0f0b3b01b1592e1fc5a9a5ad4d062
Merge "WifiCond: Setup polling on HW binder FD" into oc-dr1-dev
am: b7a65e9a63
Change-Id: Idb9e7c9308b262c0ffccd56aef6baa3e4a87799a
am: b7a65e9a63
Change-Id: Idb9e7c9308b262c0ffccd56aef6baa3e4a87799a
Merge "WifiCond: Setup polling on HW binder FD" into oc-dr1-dev
Create unittest for ScannerImpl am: 3c023a0e38
am: 7f5e3669fe
Change-Id: I22496dbb846798b2a8a7690bd421c144d387af8d
am: 7f5e3669fe
Change-Id: I22496dbb846798b2a8a7690bd421c144d387af8d
WifiCond: Setup polling on HW binder FD
To keep wificond running in single threaded mode, set it up to poll on
file descriptor of HW Binder that will receive Offload HAL callback
events
Bug: 62807929
Test: Unit tests, sanity tests, ensure Wificond has only one thread
Change-Id: Id1e977d1a62fecd9b9432d7726aee2cb5f168574
To keep wificond running in single threaded mode, set it up to poll on
file descriptor of HW Binder that will receive Offload HAL callback
events
Bug: 62807929
Test: Unit tests, sanity tests, ensure Wificond has only one thread
Change-Id: Id1e977d1a62fecd9b9432d7726aee2cb5f168574
Restart wificond on ENODEV scan failure am: 793978cb7f
am: 3715880b1d
Change-Id: I3168afd2d930f52cd603a46a199a327bbda958e9
am: 3715880b1d
Change-Id: I3168afd2d930f52cd603a46a199a327bbda958e9
Create unittest for ScannerImpl
This creates the unit test suite for class ScannerImpl and
add a few test cases for single scan.
Bug: 33452931
Test: compile, unit tests
Change-Id: Ib0584068aa886769b50860309224e670f3415fc8
This creates the unit test suite for class ScannerImpl and
add a few test cases for single scan.
Bug: 33452931
Test: compile, unit tests
Change-Id: Ib0584068aa886769b50860309224e670f3415fc8
Restart wificond on ENODEV scan failure
am: 793978cb7f
Change-Id: Iec003a60e0c3abf0ad3fd7909a1cc74d14555cec
am: 793978cb7f
Change-Id: Iec003a60e0c3abf0ad3fd7909a1cc74d14555cec
Restart wificond on ENODEV scan failure
ENODEV scan failure implies that driver entered a bad state.
In order to recover wificond, we should treat it as an fatal
error. The crashing of wificond will trigger the restarting
of framework, bringing everything back to work.
Bug: 36894921
Test: compile, unit tests
Test: manual test:
Use "iw wlan0 del" to remove kernel interface.
Observe that wificond restarts and wifi continues to work.
Change-Id: I89f4403bcb570d7f413fa4cc9ca50378de428d3d
ENODEV scan failure implies that driver entered a bad state.
In order to recover wificond, we should treat it as an fatal
error. The crashing of wificond will trigger the restarting
of framework, bringing everything back to work.
Bug: 36894921
Test: compile, unit tests
Test: manual test:
Use "iw wlan0 del" to remove kernel interface.
Observe that wificond restarts and wifi continues to work.
Change-Id: I89f4403bcb570d7f413fa4cc9ca50378de428d3d
Merge changes from topic '7_CLS_topic' into oc-dr1-dev am: b8ad0fd508
am: cabe9d5cc5
Change-Id: I9424612fea0526024e0a8a28812cc66cc334a421
am: cabe9d5cc5
Change-Id: I9424612fea0526024e0a8a28812cc66cc334a421
Wificond: Offload HAL APIs return status am: e10ec9e1f1
am: 04559d12e9
Change-Id: I966018daa0bc6803dc63c6e7ee746921931c4c77
am: 04559d12e9
Change-Id: I966018daa0bc6803dc63c6e7ee746921931c4c77
Merge changes from topic '7_CLS_topic' into oc-dr1-dev
am: b8ad0fd508
Change-Id: I861f95ceea5affe5d55bfe0b28fcfc349155b37d
am: b8ad0fd508
Change-Id: I861f95ceea5affe5d55bfe0b28fcfc349155b37d
Wificond: Offload HAL APIs return status
am: e10ec9e1f1
Change-Id: I7221e41b93d2ad1e1521d868694474e4b5fe70b7
am: e10ec9e1f1
Change-Id: I7221e41b93d2ad1e1521d868694474e4b5fe70b7
Merge changes from topic '7_CLS_topic' into oc-dr1-dev
* changes:
Offload HAL Wificond Client: Handle binder death
Wificond: Offload HAL APIs return status
* changes:
Offload HAL Wificond Client: Handle binder death
Wificond: Offload HAL APIs return status
Merge "Revert "Use new netlink attribute for scan result timestamp" am: ecb6bb205f am: f4a2b51c0e" into oc-dr1-dev-plus-aosp
am: 0636688388
Change-Id: I769405ce2cfb8b35c5b049dac92e054a4b6bb453
am: 0636688388
Change-Id: I769405ce2cfb8b35c5b049dac92e054a4b6bb453
Revert "Use new netlink attribute for scan result timestamp" am: ecb6bb205f am: 5bb4bd8518
am: 16c35d2940
Change-Id: I131885d262e52e0e75b60652d7601cbc2e881147
am: 16c35d2940
Change-Id: I131885d262e52e0e75b60652d7601cbc2e881147
Merge "Revert "Use new netlink attribute for scan result timestamp" am: ecb6bb205f am: f4a2b51c0e" into oc-dr1-dev-plus-aosp
Revert "Use new netlink attribute for scan result timestamp" am: ecb6bb205f
am: f4a2b51c0e
Change-Id: Iec20d99a06c30ff0d5660c110114de2b1171b403
am: f4a2b51c0e
Change-Id: Iec20d99a06c30ff0d5660c110114de2b1171b403
Revert "Use new netlink attribute for scan result timestamp" am: ecb6bb205f
am: 5bb4bd8518
Change-Id: Ib6762dacd462964516b648a191360a7e81ddcd86
am: 5bb4bd8518
Change-Id: Ib6762dacd462964516b648a191360a7e81ddcd86
Revert "Use new netlink attribute for scan result timestamp"
am: ecb6bb205f
Change-Id: I1915833acd8ed41b2f21e43a954338b593f5da02
am: ecb6bb205f
Change-Id: I1915833acd8ed41b2f21e43a954338b593f5da02
Revert "Use new netlink attribute for scan result timestamp"
am: ecb6bb205f
Change-Id: Id0ad9f2c0c2ab434e921893b8d2b383b389170eb
am: ecb6bb205f
Change-Id: Id0ad9f2c0c2ab434e921893b8d2b383b389170eb
6 years agoRevert "Use new netlink attribute for scan result timestamp" android-vts-8.0_r1 android-vts-8.0_r2
Revert "Use new netlink attribute for scan result timestamp"
This reverts commit 74db77ecd5314fa28ac2b78ccc3ca18788eeef60.
Bug: 62818212
Bug: 37758502
Change-Id: Icd93d4caffab92a5bf79c8d6aa8fe4dceca3ec06
This reverts commit 74db77ecd5314fa28ac2b78ccc3ca18788eeef60.
Bug: 62818212
Bug: 37758502
Change-Id: Icd93d4caffab92a5bf79c8d6aa8fe4dceca3ec06
Use new netlink attribute for scan result timestamp am: 74db77ecd5 am: 11b94d5983
am: dd3262305c
Change-Id: I91848562b85ac3e6fc571df5485fde64480c1b41
am: dd3262305c
Change-Id: I91848562b85ac3e6fc571df5485fde64480c1b41
Use new netlink attribute for scan result timestamp am: 74db77ecd5 am: de349be439
am: 8d40c19351
Change-Id: I311cb94740ed4b295333d95eb6a6a065b15dbdc7
am: 8d40c19351
Change-Id: I311cb94740ed4b295333d95eb6a6a065b15dbdc7
Use new netlink attribute for scan result timestamp am: 74db77ecd5
am: 11b94d5983
Change-Id: I126fe893ff999fb5acfd3c4ca8be86e2ce57ffc8
am: 11b94d5983
Change-Id: I126fe893ff999fb5acfd3c4ca8be86e2ce57ffc8
Use new netlink attribute for scan result timestamp am: 74db77ecd5
am: de349be439
Change-Id: I04a2307e43c75ffa66797c19da3b60dd79e4c66a
am: de349be439
Change-Id: I04a2307e43c75ffa66797c19da3b60dd79e4c66a
Use new netlink attribute for scan result timestamp
am: 74db77ecd5
Change-Id: Ie2264901d0389448f891152d7044c041ab5b4b93
am: 74db77ecd5
Change-Id: Ie2264901d0389448f891152d7044c041ab5b4b93
Use new netlink attribute for scan result timestamp
am: 74db77ecd5
Change-Id: Ifb6ae8a81c40b940194f7608a2edb67de42a61da
am: 74db77ecd5
Change-Id: Ifb6ae8a81c40b940194f7608a2edb67de42a61da
Use new netlink attribute for scan result timestamp
This CL prioritize the new netlink attribute
NL80211_BSS_LAST_SEEN_BOOTTIME to the old NL80211_BSS_TSF
because if driver supports the new attribute, the new
attribute will carry more accurate data. If not, we still
can fall back to NL80211_BSS_TSF.
Bug: 37758502
Test: compile, unit tests, integration test
Test: manual tests:
1. Test devices which have new kernel/driver supporting this attribute.
Test that most APs still consistantly show up in scan result.
1. Test devices which don't support this attribute. Insert logs to test
that wificond can fall back to the old attributes.
Change-Id: I14226b77e8bf50f4e035679fff3313affb800e86
This CL prioritize the new netlink attribute
NL80211_BSS_LAST_SEEN_BOOTTIME to the old NL80211_BSS_TSF
because if driver supports the new attribute, the new
attribute will carry more accurate data. If not, we still
can fall back to NL80211_BSS_TSF.
Bug: 37758502
Test: compile, unit tests, integration test
Test: manual tests:
1. Test devices which have new kernel/driver supporting this attribute.
Test that most APs still consistantly show up in scan result.
1. Test devices which don't support this attribute. Insert logs to test
that wificond can fall back to the old attributes.
Change-Id: I14226b77e8bf50f4e035679fff3313affb800e86
Offload HAL Wificond Client: Handle binder death
Binder death handling for Offload HAL and corresponding unit tests
Bug: 32842314
Test: Unit tests
Change-Id: I7eb52689070046ae8d2db15fd2dda80d3d398022
Binder death handling for Offload HAL and corresponding unit tests
Bug: 32842314
Test: Unit tests
Change-Id: I7eb52689070046ae8d2db15fd2dda80d3d398022
Wificond: Offload HAL APIs return status
Handle changes to the Offload HAL HIDL interface where the APIs now
return status of synchronous operations.
Bug: 32842314
Test: Unit Tests
Change-Id: If5cde06c3ad398774f33430ededda8f541540a31
Handle changes to the Offload HAL HIDL interface where the APIs now
return status of synchronous operations.
Bug: 32842314
Test: Unit Tests
Change-Id: If5cde06c3ad398774f33430ededda8f541540a31