| author | Mike Frysinger <vapier@gentoo.org> | |
| Sat, 10 Nov 2012 19:47:46 +0000 (19:47 +0000) | ||
| committer | Tom Rini <trini@ti.com> | |
| Wed, 19 Dec 2012 22:51:57 +0000 (15:51 -0700) | ||
| commit | 7a546db2ffc6a713fb8009d8246c29da5420f6a7 | |
| tree | 47935bb66275194884d3db755a50b3f8f7666f54 | tree | snapshot (tar.xz tar.gz zip) |
| parent | 3779c8e319bd5e3fb32c3036cc0d3a658f920fa3 | commit | diff |
fw_env: fix incorrect usage of open(O_CREAT)
When using open(), the O_CREAT flag must be given a mode, otherwise it
uses random garbage from the stack. Also, it can fail to build:
In file included from /usr/include/fcntl.h:290:0,
from fw_env_main.c:42:
In function 'open',
inlined from 'main' at fw_env_main.c:97:9:
/usr/include/bits/fcntl2.h:50:24: error: call to '__open_missing_mode' declared
with attribute error: open with O_CREAT in second argument needs 3 arguments
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
When using open(), the O_CREAT flag must be given a mode, otherwise it
uses random garbage from the stack. Also, it can fail to build:
In file included from /usr/include/fcntl.h:290:0,
from fw_env_main.c:42:
In function 'open',
inlined from 'main' at fw_env_main.c:97:9:
/usr/include/bits/fcntl2.h:50:24: error: call to '__open_missing_mode' declared
with attribute error: open with O_CREAT in second argument needs 3 arguments
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
| tools/env/fw_env_main.c | diff | blob | history |