summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: be7c27a)
raw | patch | inline | side by side (parent: be7c27a)
author | Rob Clark <rob@ti.com> | |
Wed, 26 Jan 2011 16:40:08 +0000 (10:40 -0600) | ||
committer | Rob Clark <rob@ti.com> | |
Wed, 26 Jan 2011 17:41:01 +0000 (11:41 -0600) |
diff --git a/configure.ac b/configure.ac
index c70edfe03283ec541659dea5d2d208f41dc769c2..04a9452ad20d22577246cde5ef85d8001be83ef9 100644 (file)
--- a/configure.ac
+++ b/configure.ac
dnl initialize GStreamer macros
AG_GST_INIT
dnl define an ERROR_CFLAGS Makefile variable
-AG_GST_SET_ERROR_CFLAGS($GST_CVS)
+AG_GST_SET_ERROR_CFLAGS($GST_GIT, [
+ -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls
+ -Wwrite-strings -Wformat-nonliteral -Wformat-security -Wold-style-definition
+ -Winit-self -Wmissing-include-dirs -Waddress
+ -Waggregate-return -Wno-multichar])
+
+dnl define correct level for debugging messages
+AG_GST_SET_LEVEL_DEFAULT($GST_GIT)
dnl set up gettext
dnl the version check needs to stay here because autopoint greps for it
AC_SUBST(DEPRECATED_CFLAGS)
dnl every flag in GST_OPTION_CFLAGS can be overridden at make time
-GST_OPTION_CFLAGS="\$(ERROR_CFLAGS) \$(DEBUG_CFLAGS) \$(PROFILE_CFLAGS) \$(GCOV_CFLAGS) \$(OPT_CFLAGS) \$(DEPRECATED_CFLAGS)"
+GST_OPTION_CFLAGS="\$(WARNING_CFLAGS) \$(ERROR_CFLAGS) \$(DEBUG_CFLAGS) \$(PROFILE_CFLAGS) \$(GCOV_CFLAGS) \$(OPT_CFLAGS) \$(DEPRECATED_CFLAGS)"
AC_SUBST(GST_OPTION_CFLAGS)
dnl our libraries need to be versioned correctly
dnl prefer internal headers to already installed ones
dnl also add builddir include for enumtypes and marshal
dnl add GST_OPTION_CFLAGS, but overridable
-GST_CFLAGS="-I\$(top_srcdir)/gst-libs -I\$(top_builddir)/gst-libs $GST_CFLAGS \$(GST_OPTION_CFLAGS)"
+GST_CFLAGS="$GST_CFLAGS \$(GST_OPTION_CFLAGS)"
AC_SUBST(GST_CFLAGS)
AC_SUBST(GST_LIBS)
index 6be37278a76ce2b6e8f76a34ef59298f86a7ee0c..4d9ea272ef31f9139acf974e9ff6c52ac00b979a 100644 (file)
{
GstDucatiBuffer *buf = NULL;
- g_return_if_fail (self);
+ g_return_val_if_fail (self, NULL);
GST_DUCATI_BUFFERPOOL_LOCK (self);
if (self->running) {
index eada5f4d614a43f1155a713c28fa7645ea2963a6..33d47c9c47b7482a96415749955d29411fe43d56 100644 (file)
--- a/src/gstducatimpeg2dec.c
+++ b/src/gstducatimpeg2dec.c
sizeof (IMPEG2VDEC_OutArgs));
if (ret) {
- IMPEG2VDEC_Params *params = (IMPEG2VDEC_Params *) self->params;
+// IMPEG2VDEC_Params *params = (IMPEG2VDEC_Params *) self->params;
self->params->displayDelay = IVIDDEC3_DISPLAY_DELAY_AUTO;
}
diff --git a/src/gstducatirvdec.c b/src/gstducatirvdec.c
index bd1eab38ce17f237d9dfaa43c476dc570b9bf159..f1b650e19691bf2ba01d4a5f9d9d42a55f60e254 100644 (file)
--- a/src/gstducatirvdec.c
+++ b/src/gstducatirvdec.c
gst_ducati_rvdec_allocate_params (GstDucatiVidDec * vdec, gint params_sz,
gint dynparams_sz, gint status_sz, gint inargs_sz, gint outargs_sz)
{
- GstDucatiRVDec *self = GST_DUCATIRVDEC (vdec);
gboolean ret = parent_class->allocate_params (vdec,
sizeof (IrealVDEC_Params), sizeof (IrealVDEC_DynamicParams),
sizeof (IrealVDEC_Status), sizeof (IrealVDEC_InArgs),
diff --git a/src/gstducatividdec.c b/src/gstducatividdec.c
index 3696b2f0a3d3637e96588a869f677fd52212d5d9..a21a85a44edccbb43318ca26f09405d75a3b6be5 100644 (file)
--- a/src/gstducatividdec.c
+++ b/src/gstducatividdec.c
GST_DEBUG_OBJECT (self, "opening engine");
- self->engine = Engine_open ("ivahd_vidsvr", NULL, NULL);
+ self->engine = Engine_open ((String)"ivahd_vidsvr", NULL, NULL);
if (G_UNLIKELY (!self->engine)) {
GST_ERROR_OBJECT (self, "could not create engine");
return FALSE;
/* create codec: */
GST_DEBUG_OBJECT (self, "creating codec: %s", codec_name);
- self->codec = VIDDEC3_create (self->engine, (char *)codec_name, self->params);
+ self->codec = VIDDEC3_create (self->engine, (String)codec_name, self->params);
if (!self->codec) {
return FALSE;
self->width = w;
self->height = h;
- const GValue *codec_data = gst_structure_get_value (s, "codec_data");
+ codec_data = gst_structure_get_value (s, "codec_data");
if (codec_data) {
GstBuffer *buffer = gst_value_get_buffer (codec_data);
}
self->inArgs->size = inargs_sz;
self->outArgs->size = outargs_sz;
+
+ return TRUE;
}
static GstBuffer *
{
GstDucatiVidDec *self = GST_DUCATIVIDDEC (GST_OBJECT_PARENT (pad));
+ GST_DEBUG_OBJECT (self, "query: %"GST_PTR_FORMAT, query);
+
switch (GST_QUERY_TYPE (query)) {
case GST_QUERY_BUFFERS:
GST_DEBUG_OBJECT (self, "min buffers: %d", self->min_buffers);
diff --git a/src/gstducatividdec.h b/src/gstducatividdec.h
index 2c25338fbe7c3e294f543d1d07bfd1528fccd157..190b953395964e5cb405e905f834fee11e58fe7f 100644 (file)
--- a/src/gstducatividdec.h
+++ b/src/gstducatividdec.h
G_BEGIN_DECLS
-// XXX move these
-GST_DEBUG_CATEGORY_EXTERN (gst_ducati_debug);
-
#define GST_TYPE_DUCATIVIDDEC (gst_ducati_viddec_get_type())
#define GST_DUCATIVIDDEC(obj) (G_TYPE_CHECK_INSTANCE_CAST((obj), GST_TYPE_DUCATIVIDDEC, GstDucatiVidDec))