summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 14983d1)
raw | patch | inline | side by side (parent: 14983d1)
author | Michael Smith <msmith@xiph.org> | |
Tue, 22 Jul 2008 18:12:54 +0000 (18:12 +0000) | ||
committer | Michael Smith <msmith@xiph.org> | |
Tue, 22 Jul 2008 18:12:54 +0000 (18:12 +0000) |
Original commit message from CVS:
* configure.ac:
Remove AC_ISC_POSIX macro; it's broken on some platforms and not needed.
Add check (taken from -base) for winsock, adds WIN32_LIBS
* gst/Makefile.am:
Add WIN32_LIBS to LIBADD for libgstreamer. Needed now that gstpoll uses
winsock.
Define GST_EXPORTS when building libgstreamer (only used on win32)
* gst/gst_private.h:
* gst/gstinfo.h:
Use GST_EXPORT instead of locally-defined (and incorrect IMPORT_SYMBOL)
for symbols that we need to export in both these files.
* gst/gstpoll.c:
Include gst_private.h higher up to avoid some compile problems on win32.
* configure.ac:
Remove AC_ISC_POSIX macro; it's broken on some platforms and not needed.
Add check (taken from -base) for winsock, adds WIN32_LIBS
* gst/Makefile.am:
Add WIN32_LIBS to LIBADD for libgstreamer. Needed now that gstpoll uses
winsock.
Define GST_EXPORTS when building libgstreamer (only used on win32)
* gst/gst_private.h:
* gst/gstinfo.h:
Use GST_EXPORT instead of locally-defined (and incorrect IMPORT_SYMBOL)
for symbols that we need to export in both these files.
* gst/gstpoll.c:
Include gst_private.h higher up to avoid some compile problems on win32.
ChangeLog | patch | blob | history | |
configure.ac | patch | blob | history | |
gst/Makefile.am | patch | blob | history | |
gst/gst_private.h | patch | blob | history | |
gst/gstinfo.h | patch | blob | history | |
gst/gstpoll.c | patch | blob | history |
diff --git a/ChangeLog b/ChangeLog
index 0a051f0a5b56fbf1777652a099753298de0c5931..4839fdeda349c61b8c2e623ce00aae147b939dbd 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
+2008-07-22 Michael Smith <msmith@songbirdnest.com>
+
+ * configure.ac:
+ Remove AC_ISC_POSIX macro; it's broken on some platforms and not needed.
+ Add check (taken from -base) for winsock, adds WIN32_LIBS
+ * gst/Makefile.am:
+ Add WIN32_LIBS to LIBADD for libgstreamer. Needed now that gstpoll uses
+ winsock.
+ Define GST_EXPORTS when building libgstreamer (only used on win32)
+ * gst/gst_private.h:
+ * gst/gstinfo.h:
+ Use GST_EXPORT instead of locally-defined (and incorrect IMPORT_SYMBOL)
+ for symbols that we need to export in both these files.
+ * gst/gstpoll.c:
+ Include gst_private.h higher up to avoid some compile problems on win32.
+
2008-07-22 Sebastian Dröge <sebastian.droege@collabora.co.uk>
* gst/gstvalue.c:
diff --git a/configure.ac b/configure.ac
index 3e421f542ca5e7a34374920c93308008f9efef27..338446474c956e21398be0b3a5943b73cfb4d38d 100644 (file)
--- a/configure.ac
+++ b/configure.ac
dnl *** checks for libraries ***
-dnl For interactive UNIX (a Sun thing)
-dnl FIXME: this adds -lcposix to LIBS, but I doubt we use LIBS
-AC_ISC_POSIX
-
dnl check for libm, for sin()
AC_CHECK_LIBM
AC_SUBST(LIBM)
dnl the dev package
AC_CHECK_HEADERS([valgrind/valgrind.h], HAVE_VALGRIND_H=yes)
+dnl used in gst/gstpoll.c
+AC_CHECK_HEADERS([winsock2.h], HAVE_WINSOCK2_H=yes)
+if test "x$HAVE_WINSOCK2_H" = "xyes"; then
+ WIN32_LIBS="-lws2_32"
+ AC_SUBST(WIN32_LIBS)
+fi
+
dnl *** checks for types/defines ***
dnl *** checks for structures ***
diff --git a/gst/Makefile.am b/gst/Makefile.am
index 7852de4da3fac72f4c1c50dd6efcf14cfdb84736..7bc271cc0358c739037ec13776a420e5966e13c3 100644 (file)
--- a/gst/Makefile.am
+++ b/gst/Makefile.am
libgstreamer_@GST_MAJORMINOR@_la_CFLAGS = \
-D_GNU_SOURCE \
+ -DGST_EXPORTS \
-DG_LOG_DOMAIN=g_log_domain_gstreamer \
-DGST_MAJORMINOR=\""$(GST_MAJORMINOR)"\" \
-DGST_DISABLE_DEPRECATED \
libgstreamer_@GST_MAJORMINOR@_la_LIBADD = \
$(GST_PARSE_LA) \
$(GST_ALL_LIBS) \
+ $(WIN32_LIBS) \
$(XML_LIBS)
libgstreamer_@GST_MAJORMINOR@_la_LDFLAGS = \
diff --git a/gst/gst_private.h b/gst/gst_private.h
index ba1060cd121a4865cb376ea67ccf9a211bcf1b74..790f4e285f6aa88732f1d03c548d48c41129908d 100644 (file)
--- a/gst/gst_private.h
+++ b/gst/gst_private.h
#ifndef GST_DISABLE_GST_DEBUG
-#ifndef _MSC_VER
-#define IMPORT_SYMBOL
-#else /* _MSC_VER */
-#ifndef LIBGSTREAMER_EXPORTS
-#define IMPORT_SYMBOL __declspec(dllimport)
-#else
-#define IMPORT_SYMBOL
-#endif
-#endif
-
#include <gst/gstinfo.h>
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_GST_INIT;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_AUTOPLUG;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_AUTOPLUG_ATTEMPT;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_PARENTAGE;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_STATES;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_SCHEDULING;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_BUFFER;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_BUS;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_CAPS;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_CLOCK;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_ELEMENT_PADS;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_PADS;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_PIPELINE;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_PLUGIN_LOADING;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_PLUGIN_INFO;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_PROPERTIES;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_XML;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_NEGOTIATION;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_REFCOUNTING;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_ERROR_SYSTEM;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_EVENT;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_MESSAGE;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_PARAMS;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_CALL_TRACE;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_SIGNAL;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_PROBE;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_REGISTRY;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_QOS;
-extern IMPORT_SYMBOL GstDebugCategory *GST_CAT_TYPES; /* FIXME 0.11: remove? */
+GST_EXPORT GstDebugCategory *GST_CAT_GST_INIT;
+GST_EXPORT GstDebugCategory *GST_CAT_AUTOPLUG;
+GST_EXPORT GstDebugCategory *GST_CAT_AUTOPLUG_ATTEMPT;
+GST_EXPORT GstDebugCategory *GST_CAT_PARENTAGE;
+GST_EXPORT GstDebugCategory *GST_CAT_STATES;
+GST_EXPORT GstDebugCategory *GST_CAT_SCHEDULING;
+GST_EXPORT GstDebugCategory *GST_CAT_BUFFER;
+GST_EXPORT GstDebugCategory *GST_CAT_BUS;
+GST_EXPORT GstDebugCategory *GST_CAT_CAPS;
+GST_EXPORT GstDebugCategory *GST_CAT_CLOCK;
+GST_EXPORT GstDebugCategory *GST_CAT_ELEMENT_PADS;
+GST_EXPORT GstDebugCategory *GST_CAT_PADS;
+GST_EXPORT GstDebugCategory *GST_CAT_PIPELINE;
+GST_EXPORT GstDebugCategory *GST_CAT_PLUGIN_LOADING;
+GST_EXPORT GstDebugCategory *GST_CAT_PLUGIN_INFO;
+GST_EXPORT GstDebugCategory *GST_CAT_PROPERTIES;
+GST_EXPORT GstDebugCategory *GST_CAT_XML;
+GST_EXPORT GstDebugCategory *GST_CAT_NEGOTIATION;
+GST_EXPORT GstDebugCategory *GST_CAT_REFCOUNTING;
+GST_EXPORT GstDebugCategory *GST_CAT_ERROR_SYSTEM;
+GST_EXPORT GstDebugCategory *GST_CAT_EVENT;
+GST_EXPORT GstDebugCategory *GST_CAT_MESSAGE;
+GST_EXPORT GstDebugCategory *GST_CAT_PARAMS;
+GST_EXPORT GstDebugCategory *GST_CAT_CALL_TRACE;
+GST_EXPORT GstDebugCategory *GST_CAT_SIGNAL;
+GST_EXPORT GstDebugCategory *GST_CAT_PROBE;
+GST_EXPORT GstDebugCategory *GST_CAT_REGISTRY;
+GST_EXPORT GstDebugCategory *GST_CAT_QOS;
+GST_EXPORT GstDebugCategory *GST_CAT_TYPES; /* FIXME 0.11: remove? */
#else
diff --git a/gst/gstinfo.h b/gst/gstinfo.h
index 1c3c42282a817f63b87bd0116a54a3202abaa5c7..801bf98401675b9755074ceb61cdee552ebd7d23 100644 (file)
--- a/gst/gstinfo.h
+++ b/gst/gstinfo.h
#include <glib-object.h>
#include <gst/gstconfig.h>
-
-#ifndef _MSC_VER
-#define IMPORT_SYMBOL
-#else /* _MSC_VER */
-#ifndef LIBGSTREAMER_EXPORTS
-#define IMPORT_SYMBOL __declspec(dllimport)
-#else
-#define IMPORT_SYMBOL
-#endif
-#endif
-
#ifndef M_PI
#define M_PI 3.14159265358979323846
#endif
/* since 0.10.7, the min debug level, used for quickly discarding debug
* messages that fall under the threshold. */
-extern IMPORT_SYMBOL GstDebugLevel __gst_debug_min;
+GST_EXPORT GstDebugLevel __gst_debug_min;
/**
* GST_CAT_LEVEL_LOG:
diff --git a/gst/gstpoll.c b/gst/gstpoll.c
index 4a05042a5f7613fd39df66a01c515e31c17394c1..1c771b7253ddc3078b3a18cce719937a983324cf 100644 (file)
--- a/gst/gstpoll.c
+++ b/gst/gstpoll.c
#include "config.h"
#endif
+#include "gst_private.h"
+
#include <sys/types.h>
#ifdef HAVE_UNISTD_H
/* OS/X needs this because of bad headers */
#include <string.h>
-#include "gst_private.h"
-
#include "gstpoll.h"
#ifndef G_OS_WIN32