collectpads2: avoid hanging in case of sparse newsegment events

... in the extent that a non-waiting pad (so indicated by newsegment)
turns out to provide the best buffer, which is then forced to waiting
for book-keeping purposes, but that should only be temporary.

See bug #415754.

diff --git a/libs/gst/base/gstcollectpads2.c b/libs/gst/base/gstcollectpads2.c
index 18f6791bba49af5d315efcecbd73c60fe9f1bb3d..60e4663a6d6c7f8ebc4466aaa95189d1bffe0df1 100644 (file)
--- a/libs/gst/base/gstcollectpads2.c
+++ b/libs/gst/base/gstcollectpads2.c
@@ -1544,6 +1544,11 @@ gst_collect_pads2_default_collected (GstCollectPads2 * pads, gpointer user_data)
   buffer = gst_collect_pads2_pop (pads, best);
   ret = func (pads, best, buffer, buffer_user_data);
 
+  /* maybe non-waiting was forced to waiting above due to
+   * newsegment events coming too sparsely,
+   * so re-check to restore state to avoid hanging/waiting */
+  gst_collect_pads2_recalculate_full (pads);
+
 done:
   return ret;
 }