summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 726210f)
raw | patch | inline | side by side (parent: 726210f)
author | Chris Wilson <chris@chris-wilson.co.uk> | |
Tue, 29 Jun 2010 19:12:44 +0000 (20:12 +0100) | ||
committer | Chris Wilson <chris@chris-wilson.co.uk> | |
Tue, 29 Jun 2010 19:16:56 +0000 (20:16 +0100) |
If the mapping succeeds we have a valid pointer. If setting the domain
failures we may incur cache corruption. However the usual failure mode
is because of a hung GPU, in which case it is preferable to ignore the
minor error from setting the domain and continue on oblivious. If
these errors persist, we should rate limit the warning [or even just
remove it].
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
failures we may incur cache corruption. However the usual failure mode
is because of a hung GPU, in which case it is preferable to ignore the
minor error from setting the domain and continue on oblivious. If
these errors persist, we should rate limit the warning [or even just
remove it].
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
intel/intel_bufmgr_gem.c | patch | blob | history |
index 26dc3348c1e81ef7894d922331611f7347f58f7f..3446390cd29f7e5dd31db3ad7f121ea197a3b210 100644 (file)
--- a/intel/intel_bufmgr_gem.c
+++ b/intel/intel_bufmgr_gem.c
&set_domain);
} while (ret == -1 && errno == EINTR);
if (ret != 0) {
- ret = -errno;
fprintf(stderr, "%s:%d: Error setting to CPU domain %d: %s\n",
__FILE__, __LINE__, bo_gem->gem_handle,
strerror(errno));
- pthread_mutex_unlock(&bufmgr_gem->lock);
- return ret;
}
pthread_mutex_unlock(&bufmgr_gem->lock);
DRM_IOCTL_I915_GEM_SET_DOMAIN,
&set_domain);
} while (ret == -1 && errno == EINTR);
-
if (ret != 0) {
- ret = -errno;
fprintf(stderr, "%s:%d: Error setting domain %d: %s\n",
__FILE__, __LINE__, bo_gem->gem_handle,
strerror(errno));
pthread_mutex_unlock(&bufmgr_gem->lock);
- return ret;
+ return 0;
}
int drm_intel_gem_bo_unmap_gtt(drm_intel_bo *bo)