summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (from parent 1: acb582b)
raw | patch | inline | side by side (from parent 1: acb582b)
author | Sam Nelson <sam.nelson@ti.com> | |
Sat, 28 Jul 2018 04:13:13 +0000 (00:13 -0400) | ||
committer | Sam Nelson <sam.nelson@ti.com> | |
Thu, 9 Aug 2018 20:01:32 +0000 (16:01 -0400) |
Added error check of return values from read and write functions.
This also clears compiler warnings
Signed-off-by: Sam Nelson <sam.nelson@ti.com>
This also clears compiler warnings
Signed-off-by: Sam Nelson <sam.nelson@ti.com>
linux/src/daemon/NameServer_daemon.c | patch | blob | history |
index caf549c104b37090adfa57e2ec89cfe8774e4af6..882905caa7db9fc7bda32b8350a604038d20e8a1 100644 (file)
/*
- * Copyright (c) 2012-2016 Texas Instruments Incorporated - http://www.ti.com
+ * Copyright (c) 2012-2018 Texas Instruments Incorporated - http://www.ti.com
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
memcpy(&NameServer_module->nsMsg, msg, sizeof(NameServerRemote_Msg));
/* Post the eventfd upon which NameServer_get() is waiting */
- write(NameServer_module->waitFd, &buf, sizeof(uint64_t));
+ err = write(NameServer_module->waitFd, &buf, sizeof(uint64_t));
+ if (err < 0) {
+ LOG2("NameServer: event write failed: %d, %s\n", errno, strerror(errno))
+ }
}
}
Bool run = TRUE;
Bool reconnect = FALSE;
(Void)arg;
+ int err;
LOG0("listener_cb: Entered Listener thread.\n")
/* check for events */
if (FD_ISSET(NameServer_module->unblockFd, &rfds)) {
- read(NameServer_module->unblockFd, &event, sizeof(event));
-
+ err = read(NameServer_module->unblockFd, &event, sizeof(event));
+ if (err < 0) {
+ LOG2("listener_cb: event read failed: %d (%s)\n",
+ errno, strerror(errno));
+ }
if (event & NameServer_Event_SHUTDOWN) {
LOG0("NameServer: listener thread, event: SHUTDOWN\n")
event &= ~NameServer_Event_SHUTDOWN;
LOG0("NameServer: listener thread, event: REFRESH\n")
/* send ACK event */
event = NameServer_Event_ACK;
- write(NameServer_module->waitFd, &event, sizeof(event));
+ err = write(NameServer_module->waitFd, &event, sizeof(event));
+ if (err < 0) {
+ LOG2("listener_cb: event read failed: %d (%s)\n",
+ errno, strerror(errno));
+ }
}
}
{
Int status = NameServer_S_SUCCESS;
uint64_t event;
+ int err;
pthread_mutex_lock(&NameServer_module->modGate);
/* shutdown the NameServer listener thread */
LOG0("NameServer_destroy: shutdown listener...\n")
event = NameServer_Event_SHUTDOWN;
- write(NameServer_module->unblockFd, &event, sizeof(event));
+ err = write(NameServer_module->unblockFd, &event, sizeof(event));
+ if (err < 0) {
+ LOG2("NameServer_destroy: event write failed: %d (%s)\n",
+ errno, strerror(errno));
+ }
/* Join: */
LOG0("NameServer_destroy: joining listener thread...\n")
if (FD_ISSET(waitFd, &rfds)) {
/* Read, just to balance the write: */
- read(waitFd, &buf, sizeof(uint64_t));
+ err = read(waitFd, &buf, sizeof(uint64_t));
+ if (err < 0) {
+ LOG2("NameServer_getRemote: event read failed: %d (%s)\n",
+ errno, strerror(errno));
+ }
/* Process response: */
replyMsg = &NameServer_module->nsMsg;
/* tell the listener thread to add new receive sockets */
event = NameServer_Event_REFRESH;
- write(NameServer_module->unblockFd, &event, sizeof(event));
-
+ err = write(NameServer_module->unblockFd, &event, sizeof(event));
+ if (err < 0) {
+ LOG2("NameServer_attach: event write failed: %d (%s)\n",
+ errno, strerror(errno));
+ }
/* wait for ACK event */
- read(NameServer_module->waitFd, &event, sizeof(event));
+ err = read(NameServer_module->waitFd, &event, sizeof(event));
+ if (err < 0) {
+ LOG2("NameServer_attach: event write failed: %d (%s)\n",
+ errno, strerror(errno));
+ }
pthread_mutex_lock(&NameServer_module->attachGate);
int sendSock;
int recvSock;
uint64_t event;
+ int err;
/* procId already validated in API layer */
clId = procId - MultiProc_getBaseIdOfCluster();
/* tell the listener thread to remove old sockets */
event = NameServer_Event_REFRESH;
- write(NameServer_module->unblockFd, &event, sizeof(event));
+ err = write(NameServer_module->unblockFd, &event, sizeof(event));
+ if (err < 0) {
+ LOG2("NameServer_detach: event write failed: %d (%s)\n",
+ errno, strerror(errno));
+ }
/* wait for ACK event */
- read(NameServer_module->waitFd, &event, sizeof(event));
+ err = read(NameServer_module->waitFd, &event, sizeof(event));
+ if (err < 0) {
+ LOG2("NameServer_detach: ack read failed: %d (%s)\n",
+ errno, strerror(errno));
+ }
/* close the sending socket */
LOG1("NameServer_detach: closing socket: %d\n", sendSock)