BIOS: NameServerRemote must copy names with 1 char less than max

The strncpy length must be max number of characters - 1 bytes. The last
character will be the null termination thus shouldn't be copied. This
fix addresses a Coverity buffer overrun error.

diff --git a/packages/ti/ipc/namesrv/NameServerRemoteRpmsg.c b/packages/ti/ipc/namesrv/NameServerRemoteRpmsg.c
index 9ec68390b491912cd5d558e80974526a4677fe6d..f412927997c9756497a294290c43ac73ccf33e14 100644 (file)
--- a/packages/ti/ipc/namesrv/NameServerRemoteRpmsg.c
+++ b/packages/ti/ipc/namesrv/NameServerRemoteRpmsg.c
@@ -184,12 +184,12 @@ Int NameServerRemoteRpmsg_get(NameServerRemoteRpmsg_Object *obj,
 
     len = strlen(instanceName);
     Assert_isTrue(len < MAXNAMEINCHAR, NameServerRemoteRpmsg_A_nameIsTooLong);
-    strncpy((Char *)msg.instanceName, instanceName, MAXNAMEINCHAR);
+    strncpy((Char *)msg.instanceName, instanceName, MAXNAMEINCHAR - 1);
     ((Char *)msg.instanceName)[MAXNAMEINCHAR - 1] = '\0';
 
     len = strlen(name);
     Assert_isTrue(len < MAXNAMEINCHAR, NameServerRemoteRpmsg_A_nameIsTooLong);
-    strncpy((Char *)msg.name, name, MAXNAMEINCHAR);
+    strncpy((Char *)msg.name, name, MAXNAMEINCHAR - 1);
     ((Char *)msg.name)[MAXNAMEINCHAR - 1] = '\0';
 
     Log_print3(Diags_INFO, FXNN": Requesting from procId %d, %s:%s...\n",