author | Florian Westphal <fw@strlen.de> | |
Thu, 23 Oct 2014 08:36:06 +0000 (10:36 +0200) | ||
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
Fri, 21 Nov 2014 17:22:54 +0000 (09:22 -0800) | ||
commit | 3a758a2b78da2f49f7165678faf999e946a0c4b5 | |
tree | 440f1131f8807448d6f957d1afbc8a84481936a7 | tree | snapshot (tar.xz tar.gz zip) |
parent | f2f25589e727f0257ee95d9e8521b7f30d3616a4 | commit | diff |
netfilter: nf_log: account for size of NLMSG_DONE attribute
commit 9dfa1dfe4d5e5e66a991321ab08afe69759d797a upstream.
We currently neither account for the nlattr size, nor do we consider
the size of the trailing NLMSG_DONE when allocating nlmsg skb.
This can result in nflog to stop working, as __nfulnl_send() re-tries
sending forever if it failed to append NLMSG_DONE (which will never
work if buffer is not large enough).
Reported-by: Houcheng Lin <houcheng@gmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
commit 9dfa1dfe4d5e5e66a991321ab08afe69759d797a upstream.
We currently neither account for the nlattr size, nor do we consider
the size of the trailing NLMSG_DONE when allocating nlmsg skb.
This can result in nflog to stop working, as __nfulnl_send() re-tries
sending forever if it failed to append NLMSG_DONE (which will never
work if buffer is not large enough).
Reported-by: Houcheng Lin <houcheng@gmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netfilter/nfnetlink_log.c | diff | blob | history |