summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: b57203e)
raw | patch | inline | side by side (parent: b57203e)
author | Jan Kara <jack@suse.cz> | |
Wed, 22 Oct 2014 07:06:49 +0000 (09:06 +0200) | ||
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
Fri, 14 Nov 2014 16:48:00 +0000 (08:48 -0800) |
commit 474d2605d119479e5aa050f738632e63589d4bb5 upstream.
Due to a switched left and right side of an assignment,
dquot_writeback_dquots() never returned error. This could result in
errors during quota writeback to not be reported to userspace properly.
Fix it.
Coverity-id: 1226884
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Due to a switched left and right side of an assignment,
dquot_writeback_dquots() never returned error. This could result in
errors during quota writeback to not be reported to userspace properly.
Fix it.
Coverity-id: 1226884
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/quota/dquot.c | patch | blob | history |
diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index 38802d683969ed95b5177ca475fdea517bd7e1aa..7a10e047bc33bd039e0dbe7b82081254c47b64b4 100644 (file)
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
dqstats_inc(DQST_LOOKUPS);
err = sb->dq_op->write_dquot(dquot);
if (!ret && err)
- err = ret;
+ ret = err;
dqput(dquot);
spin_lock(&dq_list_lock);
}