summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: f83813a)
raw | patch | inline | side by side (parent: f83813a)
author | Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> | |
Sat, 17 May 2014 11:56:38 +0000 (20:56 +0900) | ||
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
Fri, 14 Nov 2014 16:47:54 +0000 (08:47 -0800) |
commit 475d0db742e3755c6b267f48577ff7cbb7dfda0d upstream.
total_objects could be 0 and is used as a denom.
While total_objects is a "long", total_objects == 0 unlikely happens for
3.12 and later kernels because 32-bit architectures would not be able to
hold (1 << 32) objects. However, total_objects == 0 may happen for kernels
between 3.1 and 3.11 because total_objects in prune_super() was an "int"
and (e.g.) x86_64 architecture might be able to hold (1 << 32) objects.
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
total_objects could be 0 and is used as a denom.
While total_objects is a "long", total_objects == 0 unlikely happens for
3.12 and later kernels because 32-bit architectures would not be able to
hold (1 << 32) objects. However, total_objects == 0 may happen for kernels
between 3.1 and 3.11 because total_objects in prune_super() was an "int"
and (e.g.) x86_64 architecture might be able to hold (1 << 32) objects.
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/super.c | patch | blob | history |
diff --git a/fs/super.c b/fs/super.c
index 68307c029228c51efc0e7967c90c39edd1a85113..e028b508db253ea3a134325fc5f8d2984554c1d9 100644 (file)
--- a/fs/super.c
+++ b/fs/super.c
total_objects = sb->s_nr_dentry_unused +
sb->s_nr_inodes_unused + fs_objects + 1;
+ if (!total_objects)
+ total_objects = 1;
if (sc->nr_to_scan) {
int dentries;