Misra C Fixes:

MISRA.CVALUE.IMPL.CAST
MISRA.CAST.CONST
UNREACH.GEN

Change-Id: Ia692073aef0a4ba23637849970ed80ece39787af
Signed-off-by: Sunil MS <x0190988@ti.com>

diff --git a/packages/ti/sdo/edma3/drv/sample/src/sample_arm_cs.c b/packages/ti/sdo/edma3/drv/sample/src/sample_arm_cs.c
index 3da2d919cc0d938052080face0c883f0f8ce8718..258e03d8875565a1a3217de50fe15b6a4e93a869 100644 (file)
--- a/packages/ti/sdo/edma3/drv/sample/src/sample_arm_cs.c
+++ b/packages/ti/sdo/edma3/drv/sample/src/sample_arm_cs.c
@@ -190,7 +190,7 @@ void edma3OsProtectExit (uint32_t edma3InstanceId,
 
         /* Enable EDMA3 TC error interrupt only */
         case EDMA3_OS_PROTECT_INTERRUPT_TC_ERROR :
-            switch (intState)
+            switch ((int32_t)intState)
                 {
                 case 0:
                 case 1:

diff --git a/packages/ti/sdo/edma3/drv/sample/src/sample_cs.c b/packages/ti/sdo/edma3/drv/sample/src/sample_cs.c
index 29fa2ad1696f3ac4d55364c8e4db7fd20f92abd0..2cfcc4ca851843ca1f4ee58d092e17b524545fed 100755 (executable)
--- a/packages/ti/sdo/edma3/drv/sample/src/sample_cs.c
+++ b/packages/ti/sdo/edma3/drv/sample/src/sample_cs.c
@@ -184,7 +184,7 @@ void edma3OsProtectExit (uint32_t edma3InstanceId,
 
         /* Enable EDMA3 TC error interrupt only */
         case EDMA3_OS_PROTECT_INTERRUPT_TC_ERROR :
-            switch (intState)
+            switch ((int32_t)intState)
                 {
                 case 0:
                 case 1:

diff --git a/packages/ti/sdo/edma3/drv/src/edma3_drv_adv.c b/packages/ti/sdo/edma3/drv/src/edma3_drv_adv.c
index 931b647efe2dfe3dd86596988167efb63e4e63ca..f8f380887907271e68e6a1b1573b8921d2d0367d 100755 (executable)
--- a/packages/ti/sdo/edma3/drv/src/edma3_drv_adv.c
+++ b/packages/ti/sdo/edma3/drv/src/edma3_drv_adv.c
@@ -2142,11 +2142,6 @@ EDMA3_DRV_Handle EDMA3_DRV_getInstHandle(uint32_t phyCtrllerInstId,
                {
                drvObject = &drvObj[phyCtrllerInstId];
 
-               if (NULL == drvObject)
-            {
-            result = EDMA3_DRV_E_INVALID_PARAM;
-            }
-
                /* If parameter checking is enabled... */
 #ifndef EDMA3_DRV_PARAM_CHECK_DISABLE
        /* Check regionId. */
@@ -2380,17 +2375,10 @@ EDMA3_DRV_Result EDMA3_DRV_setTcErrorInt(uint32_t phyCtrllerInstId,
         {
         drvObject = &drvObj[phyCtrllerInstId];
 
-        if (drvObject == NULL)
-            {
-            result =  EDMA3_DRV_E_INVALID_PARAM;
-            }
-               else
-                       {
-               if (tcId >= drvObject->gblCfgParams.numTcs)
+        if (tcId >= drvObject->gblCfgParams.numTcs)
                        {
                        result = EDMA3_DRV_E_INVALID_PARAM;
                        }
-                       }
                }
 
        if (EDMA3_DRV_SOK == result)

diff --git a/packages/ti/sdo/edma3/drv/src/edma3_drv_init.c b/packages/ti/sdo/edma3/drv/src/edma3_drv_init.c
index 5dc98bfe3b1d3f835de2b6248da535f6c6e2f255..6d1f4ed38d0e25f6d5de05f0a18ba7d92885186e 100755 (executable)
--- a/packages/ti/sdo/edma3/drv/src/edma3_drv_init.c
+++ b/packages/ti/sdo/edma3/drv/src/edma3_drv_init.c
@@ -435,12 +435,6 @@ EDMA3_DRV_Handle EDMA3_DRV_open (uint32_t phyCtrllerInstId,
         else
             {
             drvObject = &drvObj[phyCtrllerInstId];
-            if (NULL == drvObject)
-                {
-                result = EDMA3_DRV_E_INVALID_PARAM;
-                }
-            else
-                {
                 if (initCfg->regionId >= drvObject->gblCfgParams.numRegions)
                     {
                     result = EDMA3_DRV_E_INVALID_PARAM;
@@ -479,7 +473,6 @@ EDMA3_DRV_Handle EDMA3_DRV_open (uint32_t phyCtrllerInstId,
                             }
                         }
                     }
-                }
             }
         }
 

diff --git a/packages/ti/sdo/edma3/rm/sample/src/sample_arm_cs.c b/packages/ti/sdo/edma3/rm/sample/src/sample_arm_cs.c
index 5a350dedaa6092d1e21e943b673ead2f9087035d..7ecb4190c2d36ec575d73c403435679cf715556f 100644 (file)
--- a/packages/ti/sdo/edma3/rm/sample/src/sample_arm_cs.c
+++ b/packages/ti/sdo/edma3/rm/sample/src/sample_arm_cs.c
@@ -182,7 +182,7 @@ void edma3OsProtectExit (uint32_t edma3InstanceId,
 
         /* Enable EDMA3 TC error interrupt only */
         case EDMA3_OS_PROTECT_INTERRUPT_TC_ERROR :
-            switch (intState)
+            switch ((int32_t)intState)
                 {
                 case 0:
                 case 1:

diff --git a/packages/ti/sdo/edma3/rm/sample/src/sample_cs.c b/packages/ti/sdo/edma3/rm/sample/src/sample_cs.c
index 1ef9d2b3a15ba5062192aa911879ed1cda7c5136..dcf4db4f9c64964a086ab76ac7594e834c2fd62c 100755 (executable)
--- a/packages/ti/sdo/edma3/rm/sample/src/sample_cs.c
+++ b/packages/ti/sdo/edma3/rm/sample/src/sample_cs.c
@@ -183,7 +183,7 @@ void edma3OsProtectExit (uint32_t edma3InstanceId,
 \r
         /* Enable EDMA3 TC error interrupt only */\r
         case EDMA3_OS_PROTECT_INTERRUPT_TC_ERROR :\r
-            switch (intState)\r
+            switch ((int32_t)intState)\r
                 {\r
                 case 0:\r
                 case 1:\r

diff --git a/packages/ti/sdo/edma3/rm/src/edma3resmgr.c b/packages/ti/sdo/edma3/rm/src/edma3resmgr.c
index 3a7c010eaaeb6e9d95fd136526e403e487bc9207..fed46ebdbe10a4dc47de5d5c3482e6eb2bd66f58 100755 (executable)
--- a/packages/ti/sdo/edma3/rm/src/edma3resmgr.c
+++ b/packages/ti/sdo/edma3/rm/src/edma3resmgr.c
@@ -446,11 +446,10 @@ EDMA3_RM_Result EDMA3_RM_create (uint32_t phyCtrllerInstId,
         /* Initialize the global variables for the first time */
         if (FALSE == rmInitDone)
             {
-            edma3MemZero((void *)&(resMgrObj[count]),
-                               sizeof(resMgrObj));
-            edma3MemZero((void *)(&(edma3IntrParams[0U])),
-                sizeof(edma3IntrParams));
-
+                    edma3MemZero((void *)&(resMgrObj[0U]),
+                    sizeof(resMgrObj));
+                    edma3MemZero((void *)(&(edma3IntrParams[0U][0U])),
+                    sizeof(edma3IntrParams));
             rmInitDone = TRUE;
             }
 
@@ -1039,7 +1038,7 @@ EDMA3_RM_Result EDMA3_RM_close (EDMA3_RM_Handle hEdmaResMgr,
                 --rmObj->numOpens;
                 if (0 == rmObj->numOpens)
                     {
-                    edma3MemZero((void *)&(edma3RmChBoundRes[rmObj->phyCtrllerInstId]),
+                    edma3MemZero((void *)&(edma3RmChBoundRes[rmObj->phyCtrllerInstId][0]),
                                             sizeof(edma3RmChBoundRes[rmObj->phyCtrllerInstId]));
 
                     rmObj->state = EDMA3_RM_CLOSED;
@@ -6279,7 +6278,7 @@ void edma3MemCpy(void *dst, const void *src, uint32_t len)
 
     assert (src != NULL);
     assert (dst != NULL);
-    assert ((len%4) == 0);
+    assert ((len%4U) == 0);
 
     sr = (const uint32_t *)src;
     ds = (uint32_t *)dst;