| author | Chandler Carruth <chandlerc@gmail.com> | |
| Tue, 25 Feb 2014 03:50:14 +0000 (03:50 +0000) | ||
| committer | Chandler Carruth <chandlerc@gmail.com> | |
| Tue, 25 Feb 2014 03:50:14 +0000 (03:50 +0000) | ||
| commit | 2516e7fb22773bb841a63c64f31fd259620b7b77 | |
| tree | 0795c20065c8eccffe70692f6d5eb966e6280082 | tree | snapshot (tar.xz tar.gz zip) |
| parent | 3d9b85c7543611b39ae903723589a942d10496ea | commit | diff |
[SROA] Use a more direct way of determining whether we are processing
the destination operand or source operand of a memmove.
It so happens that it was impossible for SROA to try to rewrite
self-memmove where the operands are *identical*, because either such
a think is volatile (and we don't rewrite) or it is non-volatile, and we
don't even register it as a use of the alloca.
However, making the 'IsDest' test *rely* on this subtle fact is... Very
confusing for the reader. We should use the direct and readily available
test of the Use* which gives us concrete information about which operand
is being rewritten.
No functionality changed, I hope! ;]
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202103 91177308-0d34-0410-b5e6-96231b3b80d8
the destination operand or source operand of a memmove.
It so happens that it was impossible for SROA to try to rewrite
self-memmove where the operands are *identical*, because either such
a think is volatile (and we don't rewrite) or it is non-volatile, and we
don't even register it as a use of the alloca.
However, making the 'IsDest' test *rely* on this subtle fact is... Very
confusing for the reader. We should use the direct and readily available
test of the Use* which gives us concrete information about which operand
is being rewritten.
No functionality changed, I hope! ;]
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202103 91177308-0d34-0410-b5e6-96231b3b80d8
| lib/Transforms/Scalar/SROA.cpp | diff | blob | history |