| author | Chandler Carruth <chandlerc@gmail.com> | |
| Mon, 4 Aug 2014 21:29:59 +0000 (21:29 +0000) | ||
| committer | Chandler Carruth <chandlerc@gmail.com> | |
| Mon, 4 Aug 2014 21:29:59 +0000 (21:29 +0000) | ||
| commit | 8a74e2fc07444373997c58ca38ba080bc5035216 | |
| tree | c7f2a7b265b8d79ed3522ff26adec6bd90c5d444 | tree | snapshot (tar.xz tar.gz zip) |
| parent | 25c8b4774be24267cd27556e3c1a17cbc86f488f | commit | diff |
[SDAG] Fix a really, really terrible bug in the DAG combiner.
This code is completely wrong. It is also dead, as if it were to *ever*
run, it would crash. Fortunately, after my work to the combiner, it is
at least *possible* to reach the code, and llvm-stress has found a test
case. Thanks to Patrick for reporting.
It would be really good if anyone who remembers how this code works and
what it was intended to do could add some more obvious test coverage
instead of my completely contrived and reduced test case. My test case
was so brittle I left a bread crumb comment in it to help the next
person to stumble on it and not know what it was actually testing for.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@214785 91177308-0d34-0410-b5e6-96231b3b80d8
This code is completely wrong. It is also dead, as if it were to *ever*
run, it would crash. Fortunately, after my work to the combiner, it is
at least *possible* to reach the code, and llvm-stress has found a test
case. Thanks to Patrick for reporting.
It would be really good if anyone who remembers how this code works and
what it was intended to do could add some more obvious test coverage
instead of my completely contrived and reduced test case. My test case
was so brittle I left a bread crumb comment in it to help the next
person to stumble on it and not know what it was actually testing for.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@214785 91177308-0d34-0410-b5e6-96231b3b80d8
| lib/CodeGen/SelectionDAG/DAGCombiner.cpp | diff | blob | history | |
| test/CodeGen/X86/select.ll | diff | blob | history |