This reapplies r207235 with an additional bugfixes caught by the msan
authorAdrian Prantl <aprantl@apple.com>
Fri, 25 Apr 2014 20:49:25 +0000 (20:49 +0000)
committerAdrian Prantl <aprantl@apple.com>
Fri, 25 Apr 2014 20:49:25 +0000 (20:49 +0000)
commit988b78a8463130318956cbdcbf1f5f4e338f36eb
tree74f704d159ffea525dd44b77b03ce4637ba937bc
parent31494cb6c4172e97027aa31ed1f9c78754422111
This reapplies r207235 with an additional bugfixes caught by the msan
buildbot - do not insert debug intrinsics before phi nodes.

Debug info for optimized code: Support variables that are on the stack and
described by DBG_VALUEs during their lifetime.

Previously, when a variable was at a FrameIndex for any part of its
lifetime, this would shadow all other DBG_VALUEs and only a single
fbreg location would be emitted, which in fact is only valid for a small
range and not the entire lexical scope of the variable. The included
dbg-value-const-byref testcase demonstrates this.

This patch fixes this by
Local
- emitting dbg.value intrinsics for allocas that are passed by reference
- dropping all dbg.declares (they are now fully lowered to dbg.values)
SelectionDAG
- renamed constructors for SDDbgValue for better readability.
- fix UserValue::match() to handle indirect values correctly
- not inserting an MMI table entries for dbg.values that describe allocas.
- lowering dbg.values that describe allocas into *indirect* DBG_VALUEs.
CodeGenPrepare
- leaving dbg.values for an alloca were they are (see comment)
Other
- regenerated/updated instcombine.ll testcase and included source

rdar://problem/16679879
http://reviews.llvm.org/D3374

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@207269 91177308-0d34-0410-b5e6-96231b3b80d8
13 files changed:
include/llvm/CodeGen/SelectionDAG.h
lib/CodeGen/CodeGenPrepare.cpp
lib/CodeGen/LiveDebugVariables.cpp
lib/CodeGen/SelectionDAG/InstrEmitter.cpp
lib/CodeGen/SelectionDAG/SDNodeDbgValue.h
lib/CodeGen/SelectionDAG/SelectionDAG.cpp
lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h
lib/Transforms/Utils/Local.cpp
test/DebugInfo/X86/array.ll [new file with mode: 0644]
test/DebugInfo/X86/dbg-value-const-byref.ll
test/DebugInfo/X86/formal_parameter.ll
test/DebugInfo/X86/instcombine-instrinsics.ll