author | Alexey Samsonov <samsonov@google.com> | |
Mon, 18 Nov 2013 09:31:53 +0000 (09:31 +0000) | ||
committer | Alexey Samsonov <samsonov@google.com> | |
Mon, 18 Nov 2013 09:31:53 +0000 (09:31 +0000) | ||
commit | b21ab43cfc3fa0dacf5c95f04e58b6d804b59a16 | |
tree | 12f522231a5b3a875b1ac733a5bf1b1025088c7c | tree | snapshot (tar.xz tar.gz zip) |
parent | 69b2447b6a3fcc303e03cba8c7c50d745b0284d2 | commit | diff |
Revert r194865 and r194874.
This change is incorrect. If you delete virtual destructor of both a base class
and a subclass, then the following code:
Base *foo = new Child();
delete foo;
will not cause the destructor for members of Child class. As a result, I observe
plently of memory leaks. Notable examples I investigated are:
ObjectBuffer and ObjectBufferStream, AttributeImpl and StringSAttributeImpl.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@194997 91177308-0d34-0410-b5e6-96231b3b80d8
This change is incorrect. If you delete virtual destructor of both a base class
and a subclass, then the following code:
Base *foo = new Child();
delete foo;
will not cause the destructor for members of Child class. As a result, I observe
plently of memory leaks. Notable examples I investigated are:
ObjectBuffer and ObjectBufferStream, AttributeImpl and StringSAttributeImpl.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@194997 91177308-0d34-0410-b5e6-96231b3b80d8
115 files changed: