summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 31e081e)
raw | patch | inline | side by side (parent: 31e081e)
author | Rafael Espindola <rafael.espindola@gmail.com> | |
Fri, 12 Dec 2014 17:35:34 +0000 (17:35 +0000) | ||
committer | Rafael Espindola <rafael.espindola@gmail.com> | |
Fri, 12 Dec 2014 17:35:34 +0000 (17:35 +0000) |
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@224135 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm/Support/FileOutputBuffer.h | patch | blob | history | |
lib/Support/FileOutputBuffer.cpp | patch | blob | history | |
unittests/Support/FileOutputBufferTest.cpp | patch | blob | history |
index a7cfacd191b715cbc840002a37c0833fa78df87f..9f02a16e3d65928ab48ab21fe4bf8169dbe462b6 100644 (file)
/// is called, the file is deleted in the destructor. The optional parameter
/// is used if it turns out you want the file size to be smaller than
/// initially requested.
- std::error_code commit(int64_t NewSmallerSize = -1);
+ std::error_code commit();
/// If this object was previously committed, the destructor just deletes
/// this object. If this object was not committed, the destructor
index 57a0f60d27747ef8c31470c6aeb7d768d2ace846..e6e4da346520cfb53e585fb7118d6bd58dbfd7b1 100644 (file)
return std::error_code();
}
-std::error_code FileOutputBuffer::commit(int64_t NewSmallerSize) {
+std::error_code FileOutputBuffer::commit() {
// Unmap buffer, letting OS flush dirty pages to file on disk.
Region.reset();
- // If requested, resize file as part of commit.
- if ( NewSmallerSize != -1 ) {
- std::error_code EC = sys::fs::resize_file(Twine(TempPath), NewSmallerSize);
- if (EC)
- return EC;
- }
// Rename file to final name.
return sys::fs::rename(Twine(TempPath), Twine(FinalPath));
diff --git a/unittests/Support/FileOutputBufferTest.cpp b/unittests/Support/FileOutputBufferTest.cpp
index 911d51613b14fa169606ea0ed8bee9888f762ed7..c5e67d668ed8476423e1aed7019369c15b2b56cc 100644 (file)
memcpy(Buffer->getBufferStart(), "AABBCCDDEEFFGGHHIIJJ", 20);
// Write to end of buffer to verify it is writable.
memcpy(Buffer->getBufferEnd() - 20, "AABBCCDDEEFFGGHHIIJJ", 20);
- // Commit buffer, but size down to smaller size
- ASSERT_NO_ERROR(Buffer->commit(5000));
+ ASSERT_NO_ERROR(Buffer->commit());
}
// Verify file is correct size.
uint64_t File3Size;
ASSERT_NO_ERROR(fs::file_size(Twine(File3), File3Size));
- ASSERT_EQ(File3Size, 5000ULL);
+ ASSERT_EQ(File3Size, 8192000ULL);
ASSERT_NO_ERROR(fs::remove(File3.str()));
// TEST 4: Verify file can be made executable.