summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 16c8f54)
raw | patch | inline | side by side (parent: 16c8f54)
Cleanup some local variable initialization master ti_optee_client ti2019.01 ti2019.01-rc2 ti2019.01-rc3 ti2019.01-rc4 ti2019.01-rc5 ti2019.02 ti2019.02-rc1 ti2019.02-rc2 ti2019.02-rc3 ti2019.02-rc4 ti2019.03 ti2019.03-rc1 ti2019.03-rc2 ti2019.03-rc3 ti2019.03-rc4 ti2019.04 ti2019.04-rc1 ti2019.04-rc2 ti2019.04-rc3 ti2019.04-rc4 ti2019.04-rc5
author | Etienne Carriere <etienne.carriere@linaro.org> | |
Thu, 4 Apr 2019 19:00:25 +0000 (21:00 +0200) | ||
committer | Joakim Bech <joakim.bech@linaro.org> | |
Thu, 18 Apr 2019 11:31:02 +0000 (18:31 +0700) |
This change removes few useless memset() and replace few memset() with
an initialized structure where possible.
This change fixes some TEEC_Result variables initialization
using a valid enumerated ID.
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Acked-by: Joakim Bech <joakim.bech@linaro.org>
an initialized structure where possible.
This change fixes some TEEC_Result variables initialization
using a valid enumerated ID.
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Acked-by: Joakim Bech <joakim.bech@linaro.org>
libteec/src/tee_client_api.c | patch | blob | history | |
tee-supplicant/src/rpmb.c | patch | blob | history | |
tee-supplicant/src/tee_supplicant.c | patch | blob | history |
index 030b42d88880d8149e607a38203db92e4452cb73..7099f6df8354541999b6309ea52a4502aa02fe11 100644 (file)
{
struct tee_ioctl_open_session_arg *arg = NULL;
struct tee_ioctl_param *params = NULL;
- TEEC_Result res = 0;
+ TEEC_Result res = TEEC_ERROR_GENERIC;
uint32_t eorig = 0;
int rc = 0;
const size_t arg_size = sizeof(struct tee_ioctl_open_session_arg) +
{
struct tee_ioctl_invoke_arg *arg = NULL;
struct tee_ioctl_param *params = NULL;
- TEEC_Result res = 0;
+ TEEC_Result res = TEEC_ERROR_GENERIC;
uint32_t eorig = 0;
int rc = 0;
const size_t arg_size = sizeof(struct tee_ioctl_invoke_arg) +
if (!shm->flags || (shm->flags & ~(TEEC_MEM_INPUT | TEEC_MEM_OUTPUT)))
return TEEC_ERROR_BAD_PARAMETERS;
- memset(&data, 0, sizeof(data));
data.fd = fd;
rfd = ioctl(ctx->fd, TEE_IOC_SHM_REGISTER_FD, &data);
if (rfd < 0)
index b72d71421fb1593bcf1b028be281ef2ff3acf7e9..74931c73d2452ba4533dfd27a917eb69e61d1453 100644 (file)
static uint32_t read_ext_csd(int fd, uint8_t *ext_csd)
{
int st = 0;
- struct mmc_ioc_cmd cmd;
+ struct mmc_ioc_cmd cmd = {
+ .blksz = 512,
+ .blocks = 1,
+ .flags = MMC_RSP_R1 | MMC_CMD_ADTC,
+ .opcode = MMC_SEND_EXT_CSD,
+ };
- memset(&cmd, 0, sizeof(cmd));
- cmd.blksz = 512;
- cmd.blocks = 1;
- cmd.flags = MMC_RSP_R1 | MMC_CMD_ADTC;
- cmd.opcode = MMC_SEND_EXT_CSD;
mmc_ioc_cmd_set_data(cmd, ext_csd);
st = IOCTL(fd, MMC_IOC_CMD, &cmd);
int st = 0;
size_t i = 0;
uint16_t msg_type = ntohs(req_frm->msg_type);
- struct mmc_ioc_cmd cmd;
-
- memset(&cmd, 0, sizeof(cmd));
- cmd.blksz = 512;
- cmd.blocks = req_nfrm;
- cmd.data_ptr = (uintptr_t)req_frm;
- cmd.flags = MMC_RSP_R1 | MMC_CMD_ADTC;
- cmd.opcode = MMC_WRITE_MULTIPLE_BLOCK;
- cmd.write_flag = 1;
+ struct mmc_ioc_cmd cmd = {
+ .blksz = 512,
+ .blocks = req_nfrm,
+ .data_ptr = (uintptr_t)req_frm,
+ .flags = MMC_RSP_R1 | MMC_CMD_ADTC,
+ .opcode = MMC_WRITE_MULTIPLE_BLOCK,
+ .write_flag = 1,
+ };
for (i = 1; i < req_nfrm; i++) {
if (req_frm[i].msg_type != msg_type) {
index a8b413436979c2acdf35c8ea115a26dae9a9a7c3..88434ac1264414fea46f020a2a784456ace7d02f 100644 (file)
memset(&request, 0, sizeof(request));
DMSG("looping");
- memset(&request, 0, sizeof(request));
request.recv.num_params = RPC_NUM_PARAMS;
/* Let it be known that we can deal with meta parameters */